Skip to content

Commit 9576a8e

Browse files
committed
fix sl on empty inputs (#27588)
1 parent 11641f7 commit 9576a8e

File tree

2 files changed

+7
-3
lines changed

2 files changed

+7
-3
lines changed

ydb/core/kqp/runtime/kqp_stream_lookup_actor.cpp

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -606,6 +606,13 @@ class TKqpStreamLookupActor : public NActors::TActorBootstrapped<TKqpStreamLooku
606606
auto guard = BindAllocator();
607607

608608
NUdf::TUnboxedValue row;
609+
610+
YQL_ENSURE(!Input.IsInvalid());
611+
if (Input.IsFinish() || !Input.HasValue()) {
612+
LastFetchStatus = NUdf::EFetchStatus::Finish;
613+
return;
614+
}
615+
609616
while ((LastFetchStatus = Input.Fetch(row)) == NUdf::EFetchStatus::Ok) {
610617
StreamLookupWorker->AddInputRow(std::move(row));
611618
}

ydb/core/kqp/ut/join/kqp_index_lookup_join_ut.cpp

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -240,12 +240,10 @@ class TTester {
240240
bool OnlineReadOnly = false;
241241
NYdb::TParamsBuilder ParamsBuilder;
242242
bool NeedParams = false;
243-
bool FilterOptionalSide = true;
244243

245244
TTester& Run() {
246245
auto settings = TKikimrSettings();
247246
settings.AppConfig.MutableTableServiceConfig()->SetEnableKqpDataQueryStreamIdxLookupJoin(StreamLookup);
248-
settings.AppConfig.MutableTableServiceConfig()->SetFilterPushdownOverJoinOptionalSide(FilterOptionalSide);
249247

250248
TKikimrRunner kikimr(settings);
251249
auto db = kikimr.GetTableClient();
@@ -1183,7 +1181,6 @@ Y_UNIT_TEST_TWIN(TestEntityFramework, StreamLookupJoin) {
11831181
])",
11841182
.StreamLookup=StreamLookupJoin,
11851183
.DoValidateStats=false,
1186-
.FilterOptionalSide=false // remove this to get failure
11871184
};
11881185
tester.Run();
11891186
}

0 commit comments

Comments
 (0)