stable-25-3-1: Fix bad portions count (#28410)

Author: ydbot

ydb/core/tx/columnshard/counters/engine_logs.cpp

@@ -91,24 +91,24 @@ void TEngineLogsCounters::OnActualizationTask(const ui32 evictCount, const ui32
     }
 }
 
-void TEngineLogsCounters::TPortionsInfoGuard::OnNewPortion(const std::shared_ptr<NOlap::TPortionInfo>& portion) const {
+void TEngineLogsCounters::TPortionsInfoGuard::OnNewPortion(const std::shared_ptr<NOlap::TPortionInfo>& portion) {
     const ui32 producedId = (ui32)portion->GetProduced();
     PortionRecordCountGuards[producedId]->Add(portion->GetRecordsCount(), 1);
     PortionSizeGuards[producedId]->Add(portion->GetTotalBlobBytes(), 1);
 
     if (portion->GetTotalBlobBytes() <= GetBadPortionSizeLimit()) {
-        BadPortionsCount->Add(1);
+        BadPortionsCount.Add(1);
     }
 }
 
-void TEngineLogsCounters::TPortionsInfoGuard::OnDropPortion(const std::shared_ptr<NOlap::TPortionInfo>& portion) const {
+void TEngineLogsCounters::TPortionsInfoGuard::OnDropPortion(const std::shared_ptr<NOlap::TPortionInfo>& portion) {
     const ui32 producedId = (ui32)portion->GetProduced();
     THashSet<NOlap::TUnifiedBlobId> blobIds;
     PortionRecordCountGuards[producedId]->Sub(portion->GetRecordsCount(), 1);
     PortionSizeGuards[producedId]->Sub(portion->GetTotalBlobBytes(), 1);
 
     if (portion->GetTotalBlobBytes() <= GetBadPortionSizeLimit()) {
-        BadPortionsCount->Sub(1);
+        BadPortionsCount.Sub(1);
     }
 }
 

ydb/core/tx/columnshard/counters/engine_logs.h

@@ -241,13 +241,14 @@ class TEngineLogsCounters: public TCommonCountersOwner {
         std::vector<std::shared_ptr<TIncrementalHistogram::TGuard>> BlobGuards;
         std::vector<std::shared_ptr<TIncrementalHistogram::TGuard>> PortionRecordCountGuards;
         std::vector<std::shared_ptr<TIncrementalHistogram::TGuard>> PortionSizeGuards;
-        NMonitoring::TDynamicCounters::TCounterPtr BadPortionsCount;
+        TValueGuard BadPortionsCount;
 
     public:
         TPortionsInfoGuard(const std::vector<std::shared_ptr<TIncrementalHistogram>>& distrBlobs,
             const std::vector<std::shared_ptr<TIncrementalHistogram>>& distrPortionSize,
             const std::vector<std::shared_ptr<TIncrementalHistogram>>& distrRecordsCount,
-            NMonitoring::TDynamicCounters::TCounterPtr badPortionsCount)
+            NMonitoring::TDynamicCounters::TCounterPtr badPortionsCount) :
+            BadPortionsCount(badPortionsCount)
         {
             for (auto&& i : distrBlobs) {
                 BlobGuards.emplace_back(i->BuildGuard());
@@ -258,12 +259,11 @@ class TEngineLogsCounters: public TCommonCountersOwner {
             for (auto&& i : distrRecordsCount) {
                 PortionRecordCountGuards.emplace_back(i->BuildGuard());
             }
-            BadPortionsCount = badPortionsCount;
         }
 
 
-        void OnNewPortion(const std::shared_ptr<NOlap::TPortionInfo>& portion) const;
-        void OnDropPortion(const std::shared_ptr<NOlap::TPortionInfo>& portion) const;
+        void OnNewPortion(const std::shared_ptr<NOlap::TPortionInfo>& portion);
+        void OnDropPortion(const std::shared_ptr<NOlap::TPortionInfo>& portion);
 
     };