Merge branch 'master' into remove-check-node-id

Author: asmyasnikov

.golangci.yml

@@ -226,7 +226,6 @@ linters:
     - exhaustivestruct
     - exhaustruct
     - forbidigo
-    - funlen
     - gochecknoglobals
     - gocognit
     - godot
@@ -304,7 +303,10 @@ issues:
     - path: examples
       linters:
         - gomnd
-
+        - funlen
+    - path: tests
+      linters:
+        - funlen
       # Allow underscore and capital camel case for readability
       # Examples: Type_PRIMITIVE_TYPE_ID_UNSPECIFIED, Ydb_Discovery_V1, _voidValue
     - linters:

CHANGELOG.md

@@ -1,4 +1,5 @@
 * Removed check the node is available for query and table service sessions 
+* Refactored the `balancers.PreferLocations()' function - it is a clean/pure function
 
 ## v3.74.2
 * Added description to scan errors with use query service client scanner

balancers/balancers.go

@@ -6,6 +6,7 @@ import (
 
 	balancerConfig "github.com/ydb-platform/ydb-go-sdk/v3/internal/balancer/config"
 	"github.com/ydb-platform/ydb-go-sdk/v3/internal/conn"
+	"github.com/ydb-platform/ydb-go-sdk/v3/internal/xslices"
 	"github.com/ydb-platform/ydb-go-sdk/v3/internal/xstring"
 )
 
@@ -91,6 +92,10 @@ func PreferLocations(balancer *balancerConfig.Config, locations ...string) *bala
 	if len(locations) == 0 {
 		panic("empty list of locations")
 	}
+
+	// Prevent modify source locations
+	locations = xslices.Clone(locations)
+
 	for i := range locations {
 		locations[i] = strings.ToUpper(locations[i])
 	}

driver.go

@@ -306,7 +306,7 @@ func New(ctx context.Context, opts ...Option) (_ *Driver, err error) { //nolint:
 	return d, nil
 }
 
-//nolint:cyclop, nonamedreturns
+//nolint:cyclop, nonamedreturns, funlen
 func newConnectionFromOptions(ctx context.Context, opts ...Option) (_ *Driver, err error) {
 	ctx, driverCtxCancel := xcontext.WithCancel(xcontext.ValueOnly(ctx))
 	defer func() {

dsn.go

@@ -43,6 +43,7 @@ func UnregisterDsnParser(registrationID int) {
 	dsnParsers[registrationID] = nil
 }
 
+//nolint:funlen
 func parseConnectionString(dataSourceName string) (opts []Option, _ error) {
 	info, err := dsn.Parse(dataSourceName)
 	if err != nil {

internal/table/session.go

@@ -922,6 +922,8 @@ func (s *session) ExecuteSchemeQuery(
 }
 
 // DescribeTableOptions describes supported table options.
+//
+//nolint:funlen
 func (s *session) DescribeTableOptions(ctx context.Context) (
 	desc options.TableOptionsDescription,
 	err error,
@@ -1059,6 +1061,8 @@ func (s *session) DescribeTableOptions(ctx context.Context) (
 // Note that given ctx controls the lifetime of the whole read, not only this
 // StreamReadTable() call; that is, the time until returned result is closed
 // via Close() call or fully drained by sequential NextResultSet() calls.
+//
+//nolint:funlen
 func (s *session) StreamReadTable(
 	ctx context.Context,
 	path string,
@@ -1174,6 +1178,8 @@ func (s *session) ReadRows(
 // Note that given ctx controls the lifetime of the whole read, not only this
 // StreamExecuteScanQuery() call; that is, the time until returned result is closed
 // via Close() call or fully drained by sequential NextResultSet() calls.
+//
+//nolint:funlen
 func (s *session) StreamExecuteScanQuery(
 	ctx context.Context,
 	query string,

internal/value/value.go

@@ -788,6 +788,7 @@ func FloatValue(v float32) *floatValue {
 
 type int8Value int8
 
+//nolint:funlen
 func (v int8Value) castTo(dst interface{}) error {
 	switch vv := dst.(type) {
 	case *string:
@@ -964,6 +965,7 @@ func Int16Value(v int16) int16Value {
 
 type int32Value int32
 
+//nolint:funlen
 func (v int32Value) castTo(dst interface{}) error {
 	switch vv := dst.(type) {
 	case *string:

internal/xslices/clone.go

@@ -0,0 +1,12 @@
+//go:build go1.21
+// +build go1.21
+
+package xslices
+
+import "slices"
+
+// Clone returns a copy of the slice.
+// The elements are copied using assignment, so this is a shallow clone.
+func Clone[S ~[]E, E any](s S) S {
+	return slices.Clone(s)
+}

internal/xslices/clone_1.20.go

@@ -0,0 +1,14 @@
+//go:build !go1.21
+// +build !go1.21
+
+package xslices
+
+// Clone returns a copy of the slice.
+// The elements are copied using assignment, so this is a shallow clone.
+func Clone[S ~[]E, E any](s S) S {
+	// Preserve nil in case it matters.
+	if s == nil {
+		return nil
+	}
+	return append(S([]E{}), s...)
+}

metrics/driver.go

@@ -9,6 +9,8 @@ import (
 )
 
 // driver makes driver with New publishing
+//
+//nolint:funlen
 func driver(config Config) (t trace.Driver) {
 	config = config.WithSystem("driver")
 	endpoints := config.WithSystem("balancer").GaugeVec("endpoints", "az")