use resolved address instead of address in conn/pool (#1874)

Author: qrort

CHANGELOG.md

@@ -1,3 +1,4 @@
+* Fixed `conn/pool.Get()` behaviour for YDB databases with public IPs. Bug was introduced in v3.116.2
 * Added helper methods `log.WithFields` and `log.FieldsFromContext` for working with structured logging fields via context.
   These methods allow adding custom fields to the context, which are later extracted by the logger.
 

internal/conn/pool.go

@@ -46,8 +46,7 @@ func (p *Pool) Get(endpoint endpoint.Endpoint) Conn {
 		has bool
 	)
 
-	cc, has = p.conns.Get(endpoint.Key())
-	if has && cc.Endpoint().NodeID() == endpoint.NodeID() && cc.Endpoint().OverrideHost() == endpoint.OverrideHost() {
+	if cc, has = p.conns.Get(endpoint.Key()); has {
 		return cc
 	}
 

internal/endpoint/endpoint.go

@@ -57,7 +57,7 @@ type endpoint struct {
 
 func (e *endpoint) Key() Key {
 	return Key{
-		Address:      e.address,
+		Address:      e.Address(),
 		NodeID:       e.id,
 		HostOverride: e.sslNameOverride,
 	}
@@ -87,7 +87,7 @@ func (e *endpoint) String() string {
 
 	return fmt.Sprintf(`{id:%d,address:%q,local:%t,location:%q,loadFactor:%f,lastUpdated:%q}`,
 		e.id,
-		e.address,
+		e.Address(),
 		e.local,
 		e.location,
 		e.loadFactor,