Merge pull request #1058 from ydb-platform/enable_protogetter_linter

Enable protogetter linter

Author: asmyasnikov

.golangci.yml

@@ -243,7 +243,6 @@ linters:
     - maligned
     - nonamedreturns
     - paralleltest
-    - protogetter
     - scopelint
     - structcheck
     - testableexamples

internal/allocator/allocator.go

@@ -375,7 +375,7 @@ type structAllocator struct {
 
 func (a *structAllocator) Struct() (v *Ydb.StructType) {
 	v = structPool.Get()
-	if cap(v.Members) <= 0 {
+	if cap(v.GetMembers()) <= 0 {
 		v.Members = make([]*Ydb.StructMember, 0, 10)
 	}
 	a.allocations = append(a.allocations, v)
@@ -385,7 +385,7 @@ func (a *structAllocator) Struct() (v *Ydb.StructType) {
 
 func (a *structAllocator) free() {
 	for _, v := range a.allocations {
-		members := v.Members
+		members := v.GetMembers()
 		for i := range members {
 			members[i] = nil
 		}
@@ -447,7 +447,7 @@ func (a *tupleAllocator) Tuple() (v *Ydb.TupleType) {
 
 func (a *tupleAllocator) free() {
 	for _, v := range a.allocations {
-		elements := v.Elements
+		elements := v.GetElements()
 		for i := range elements {
 			elements[i] = nil
 		}
@@ -718,8 +718,8 @@ func (a *valueAllocator) Value() (v *Ydb.Value) {
 
 func (a *valueAllocator) free() {
 	for _, v := range a.allocations {
-		items := v.Items
-		pairs := v.Pairs
+		items := v.GetItems()
+		pairs := v.GetPairs()
 		for i := range items {
 			items[i] = nil
 		}

internal/discovery/discovery.go

@@ -80,9 +80,9 @@ func (c *Client) Discover(ctx context.Context) (endpoints []endpoint.Endpoint, e
 	}
 
 	location = result.GetSelfLocation()
-	endpoints = make([]endpoint.Endpoint, 0, len(result.Endpoints))
-	for _, e := range result.Endpoints {
-		if e.Ssl == c.config.Secure() {
+	endpoints = make([]endpoint.Endpoint, 0, len(result.GetEndpoints()))
+	for _, e := range result.GetEndpoints() {
+		if e.GetSsl() == c.config.Secure() {
 			endpoints = append(endpoints, endpoint.New(
 				net.JoinHostPort(e.GetAddress(), strconv.Itoa(int(e.GetPort()))),
 				endpoint.WithLocation(e.GetLocation()),

internal/grpcwrapper/rawscheme/entry.go

@@ -26,25 +26,25 @@ func (e *Entry) FromProto(proto *Ydb_Scheme.Entry) error {
 	if proto == nil {
 		return xerrors.WithStackTrace(errUnexpectedNilForSchemeEntry)
 	}
-	e.Name = proto.Name
-	e.Owner = proto.Owner
-	e.Type = EntryType(proto.Type)
+	e.Name = proto.GetName()
+	e.Owner = proto.GetOwner()
+	e.Type = EntryType(proto.GetType())
 
-	e.EffectivePermissions = make([]Permissions, len(proto.EffectivePermissions))
-	for i := range proto.EffectivePermissions {
-		if err := e.EffectivePermissions[i].FromProto(proto.EffectivePermissions[i]); err != nil {
+	e.EffectivePermissions = make([]Permissions, len(proto.GetEffectivePermissions()))
+	for i := range proto.GetEffectivePermissions() {
+		if err := e.EffectivePermissions[i].FromProto(proto.GetEffectivePermissions()[i]); err != nil {
 			return err
 		}
 	}
 
-	e.Permissions = make([]Permissions, len(proto.Permissions))
-	for i := range proto.Permissions {
-		if err := e.Permissions[i].FromProto(proto.Permissions[i]); err != nil {
+	e.Permissions = make([]Permissions, len(proto.GetPermissions()))
+	for i := range proto.GetPermissions() {
+		if err := e.Permissions[i].FromProto(proto.GetPermissions()[i]); err != nil {
 			return err
 		}
 	}
 
-	e.SizeBytes = proto.SizeBytes
+	e.SizeBytes = proto.GetSizeBytes()
 
 	return nil
 }
@@ -74,8 +74,8 @@ func (p *Permissions) FromProto(proto *Ydb_Scheme.Permissions) error {
 	if proto == nil {
 		return xerrors.WithStackTrace(errUnexpectedNilForSchemePermissions)
 	}
-	p.Subject = proto.Subject
-	p.PermissionNames = proto.PermissionNames
+	p.Subject = proto.GetSubject()
+	p.PermissionNames = proto.GetPermissionNames()
 
 	return nil
 }

internal/grpcwrapper/rawtopic/alter_topic.go

@@ -64,7 +64,7 @@ type AlterTopicResult struct {
 }
 
 func (r *AlterTopicResult) FromProto(proto *Ydb_Topic.AlterTopicResponse) error {
-	return r.Operation.FromProtoWithStatusCheck(proto.Operation)
+	return r.Operation.FromProtoWithStatusCheck(proto.GetOperation())
 }
 
 type AlterConsumer struct {

internal/grpcwrapper/rawtopic/controlplane_types.go

@@ -25,7 +25,7 @@ func (c *Consumer) MustFromProto(consumer *Ydb_Topic.Consumer) {
 	c.Important = consumer.GetImportant()
 	c.Attributes = consumer.GetAttributes()
 	c.ReadFrom.MustFromProto(consumer.GetReadFrom())
-	c.SupportedCodecs.MustFromProto(consumer.SupportedCodecs)
+	c.SupportedCodecs.MustFromProto(consumer.GetSupportedCodecs())
 }
 
 func (c *Consumer) ToProto() *Ydb_Topic.Consumer {
@@ -56,8 +56,8 @@ func (s *PartitioningSettings) FromProto(proto *Ydb_Topic.PartitioningSettings)
 		return xerrors.WithStackTrace(errUnexpectedNilPartitioningSettings)
 	}
 
-	s.MinActivePartitions = proto.MinActivePartitions
-	s.PartitionCountLimit = proto.PartitionCountLimit
+	s.MinActivePartitions = proto.GetMinActivePartitions()
+	s.PartitionCountLimit = proto.GetPartitionCountLimit()
 
 	return nil
 }

internal/grpcwrapper/rawtopic/create_topic.go

@@ -41,7 +41,7 @@ func (req *CreateTopicRequest) ToProto() *Ydb_Topic.CreateTopicRequest {
 	proto.Attributes = req.Attributes
 
 	proto.Consumers = make([]*Ydb_Topic.Consumer, len(req.Consumers))
-	for i := range proto.Consumers {
+	for i := range proto.GetConsumers() {
 		proto.Consumers[i] = req.Consumers[i].ToProto()
 	}
 
@@ -55,5 +55,5 @@ type CreateTopicResult struct {
 }
 
 func (r *CreateTopicResult) FromProto(proto *Ydb_Topic.CreateTopicResponse) error {
-	return r.Operation.FromProtoWithStatusCheck(proto.Operation)
+	return r.Operation.FromProtoWithStatusCheck(proto.GetOperation())
 }

internal/grpcwrapper/rawtopic/describe_topic.go

@@ -42,7 +42,7 @@ type DescribeTopicResult struct {
 }
 
 func (res *DescribeTopicResult) FromProto(protoResponse *Ydb_Topic.DescribeTopicResponse) error {
-	if err := res.Operation.FromProtoWithStatusCheck(protoResponse.Operation); err != nil {
+	if err := res.Operation.FromProtoWithStatusCheck(protoResponse.GetOperation()); err != nil {
 		return err
 	}
 
@@ -51,11 +51,11 @@ func (res *DescribeTopicResult) FromProto(protoResponse *Ydb_Topic.DescribeTopic
 		return xerrors.WithStackTrace(fmt.Errorf("ydb: describe topic result failed on unmarshal grpc result: %w", err))
 	}
 
-	if err := res.Self.FromProto(protoResult.Self); err != nil {
+	if err := res.Self.FromProto(protoResult.GetSelf()); err != nil {
 		return err
 	}
 
-	if err := res.PartitioningSettings.FromProto(protoResult.PartitioningSettings); err != nil {
+	if err := res.PartitioningSettings.FromProto(protoResult.GetPartitioningSettings()); err != nil {
 		return err
 	}
 
@@ -72,17 +72,17 @@ func (res *DescribeTopicResult) FromProto(protoResponse *Ydb_Topic.DescribeTopic
 		res.SupportedCodecs = append(res.SupportedCodecs, rawtopiccommon.Codec(v))
 	}
 
-	res.PartitionWriteSpeedBytesPerSecond = protoResult.PartitionWriteSpeedBytesPerSecond
-	res.PartitionWriteBurstBytes = protoResult.PartitionWriteBurstBytes
+	res.PartitionWriteSpeedBytesPerSecond = protoResult.GetPartitionWriteSpeedBytesPerSecond()
+	res.PartitionWriteBurstBytes = protoResult.GetPartitionWriteBurstBytes()
 
-	res.Attributes = protoResult.Attributes
+	res.Attributes = protoResult.GetAttributes()
 
-	res.Consumers = make([]Consumer, len(protoResult.Consumers))
+	res.Consumers = make([]Consumer, len(protoResult.GetConsumers()))
 	for i := range res.Consumers {
-		res.Consumers[i].MustFromProto(protoResult.Consumers[i])
+		res.Consumers[i].MustFromProto(protoResult.GetConsumers()[i])
 	}
 
-	res.MeteringMode = MeteringMode(protoResult.MeteringMode)
+	res.MeteringMode = MeteringMode(protoResult.GetMeteringMode())
 
 	return nil
 }

internal/grpcwrapper/rawtopic/drop_topic.go

@@ -23,5 +23,5 @@ type DropTopicResult struct {
 }
 
 func (r *DropTopicResult) FromProto(proto *Ydb_Topic.DropTopicResponse) error {
-	return r.Operation.FromProtoWithStatusCheck(proto.Operation)
+	return r.Operation.FromProtoWithStatusCheck(proto.GetOperation())
 }

internal/grpcwrapper/rawtopic/rawtopiccommon/codec.go

@@ -98,7 +98,7 @@ func (c *SupportedCodecs) ToProto() *Ydb_Topic.SupportedCodecs {
 func (c *SupportedCodecs) MustFromProto(proto *Ydb_Topic.SupportedCodecs) {
 	res := make([]Codec, len(proto.GetCodecs()))
 	for i := range proto.GetCodecs() {
-		res[i].MustFromProto(Ydb_Topic.Codec(proto.Codecs[i]))
+		res[i].MustFromProto(Ydb_Topic.Codec(proto.GetCodecs()[i]))
 	}
 	*c = res
 }