Merge pull request #1094 from ydb-platform/query-scan-optional

fixed `optional.castTo` with reflect

Author: asmyasnikov

internal/types/types_test.go

@@ -2,6 +2,8 @@ package types
 
 import (
 	"testing"
+
+	"github.com/stretchr/testify/require"
 )
 
 func TestTypeToString(t *testing.T) {
@@ -273,3 +275,101 @@ func TestTypeToString(t *testing.T) {
 		})
 	}
 }
+
+func TestEqual(t *testing.T) {
+	tests := []struct {
+		lhs   Type
+		rhs   Type
+		equal bool
+	}{
+		{
+			Bool,
+			Bool,
+			true,
+		},
+		{
+			Bool,
+			Text,
+			false,
+		},
+		{
+			Text,
+			Text,
+			true,
+		},
+		{
+			NewOptional(Bool),
+			NewOptional(Bool),
+			true,
+		},
+		{
+			NewOptional(Bool),
+			NewOptional(Text),
+			false,
+		},
+		{
+			NewOptional(Text),
+			NewOptional(Text),
+			true,
+		},
+	}
+	for _, tt := range tests {
+		t.Run("", func(t *testing.T) {
+			if equal := Equal(tt.lhs, tt.rhs); equal != tt.equal {
+				t.Errorf("Equal(%s, %s) = %v, want %v", tt.lhs, tt.rhs, equal, tt.equal)
+			}
+		})
+	}
+}
+
+func TestOptionalInnerType(t *testing.T) {
+	tests := []struct {
+		src        Type
+		innerType  Type
+		isOptional bool
+	}{
+		{
+			Bool,
+			nil,
+			false,
+		},
+		{
+			Text,
+			nil,
+			false,
+		},
+		{
+			NewOptional(Bool),
+			Bool,
+			true,
+		},
+		{
+			NewOptional(Text),
+			Text,
+			true,
+		},
+		{
+			NewOptional(NewTuple(Text, Bool, Uint64, NewOptional(Int64))),
+			NewTuple(Text, Bool, Uint64, NewOptional(Int64)),
+			true,
+		},
+	}
+	for _, tt := range tests {
+		t.Run("", func(t *testing.T) {
+			optional, isOptional := tt.src.(interface {
+				IsOptional()
+				InnerType() Type
+			})
+			require.Equal(t, tt.isOptional, isOptional)
+			var innerType Type
+			if isOptional {
+				innerType = optional.InnerType()
+			}
+			if tt.innerType == nil {
+				require.Nil(t, innerType)
+			} else {
+				require.True(t, Equal(tt.innerType, innerType))
+			}
+		})
+	}
+}

internal/value/errors.go

@@ -2,4 +2,7 @@ package value
 
 import "errors"
 
-var ErrCannotCast = errors.New("cannot cast")
+var (
+	ErrCannotCast                   = errors.New("cannot cast")
+	errDestinationTypeIsNotAPointer = errors.New("destination type is not a pointer")
+)