Skip to content

Commit 8c8fc28

Browse files
committed
fix: lint
1 parent 832da85 commit 8c8fc28

File tree

6 files changed

+11
-8
lines changed

6 files changed

+11
-8
lines changed

internal/grpcwrapper/rawtopic/describe_topic.go

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,8 +43,7 @@ type DescribeTopicResult struct {
4343

4444
func (res *DescribeTopicResult) FromProto(protoResponse *Ydb_Topic.DescribeTopicResponse) error {
4545
if err := res.Operation.FromProtoWithStatusCheck(protoResponse.GetOperation()); err != nil {
46-
return nil
47-
46+
return err
4847
}
4948

5049
protoResult := &Ydb_Topic.DescribeTopicResult{}

internal/grpcwrapper/rawtopic/rawtopicwriter/messages.go

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -217,7 +217,7 @@ func (r *WriteResult) fromProto(response *Ydb_Topic.StreamWriteMessage_WriteResp
217217
}
218218
}
219219
r.PartitionID = response.GetPartitionId()
220-
220+
221221
return r.WriteStatistics.fromProto(response.GetWriteStatistics())
222222
}
223223

@@ -231,9 +231,8 @@ func (wa *WriteAck) fromProto(pb *Ydb_Topic.StreamWriteMessage_WriteResponse_Wri
231231
return xerrors.WithStackTrace(errWriteResultResponseWriteAckIsNil)
232232
}
233233
wa.SeqNo = pb.GetSeqNo()
234-
235-
return wa.MessageWriteStatus.fromProto(pb.GetMessageWriteStatus())
236234

235+
return wa.MessageWriteStatus.fromProto(pb.GetMessageWriteStatus())
237236
}
238237

239238
// MessageWriteStatus is struct because it included in per-message structure and
@@ -250,7 +249,7 @@ func (s *MessageWriteStatus) fromProto(status interface{}) error {
250249
case *Ydb_Topic.StreamWriteMessage_WriteResponse_WriteAck_Written_:
251250
s.Type = WriteStatusTypeWritten
252251
s.WrittenOffset = v.Written.GetOffset()
253-
252+
254253
return nil
255254
case *Ydb_Topic.StreamWriteMessage_WriteResponse_WriteAck_Skipped_:
256255
s.Type = WriteStatusTypeSkipped

internal/table/scanner/scan_raw.go

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -604,8 +604,8 @@ func (s *rawConverter) unwrapVariantType(typ *Ydb.Type_VariantType, index uint32
604604

605605
return
606606
}
607-
return "", x.TupleItems.GetElements()[i]
608607

608+
return "", x.TupleItems.GetElements()[i]
609609

610610
case *Ydb.VariantType_StructItems:
611611
if i >= len(x.StructItems.GetMembers()) {
@@ -614,7 +614,7 @@ func (s *rawConverter) unwrapVariantType(typ *Ydb.Type_VariantType, index uint32
614614
return
615615
}
616616
m := x.StructItems.GetMembers()[i]
617-
617+
618618
return m.GetName(), m.GetType()
619619

620620
default:
@@ -657,6 +657,7 @@ func (s *rawConverter) pairsIn() int {
657657
return -1
658658
}
659659
s.stack.enter()
660+
660661
return len(x.v.GetPairs())
661662
}
662663

internal/value/type.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,10 +39,12 @@ func TypeFromYDB(x *Ydb.Type) Type {
3939

4040
case *Ydb.Type_TupleType:
4141
t := v.TupleType
42+
4243
return Tuple(TypesFromYDB(t.GetElements())...)
4344

4445
case *Ydb.Type_StructType:
4546
s := v.StructType
47+
4648
return Struct(StructFields(s.GetMembers())...)
4749

4850
case *Ydb.Type_DictType:

tests/slo/database/sql/storage.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ import (
1616
"slo/internal/generator"
1717
)
1818

19+
//nolint:goconst
1920
const (
2021
createTemplate = `
2122
CREATE TABLE ` + "`%s`" + ` (

tests/slo/native/storage.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ import (
1818
"slo/internal/generator"
1919
)
2020

21+
//nolint:goconst
2122
const (
2223
upsertTemplate = `
2324
PRAGMA TablePathPrefix("%s");

0 commit comments

Comments
 (0)