Skip to content

Commit 338d192

Browse files
authored
Merge pull request #992 from ydb-platform/promlinter
promlinter enabled
2 parents 847aa72 + ce8c48e commit 338d192

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

.golangci.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -243,7 +243,6 @@ linters:
243243
- nonamedreturns
244244
- nosnakecase
245245
- paralleltest
246-
- promlinter
247246
- protogetter
248247
- scopelint
249248
- structcheck

examples/serverless/url_shortener/service.go

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -89,13 +89,15 @@ func getService(ctx context.Context, dsn string, opts ...ydb.Option) (s *service
8989
calls = prometheus.NewGaugeVec(prometheus.GaugeOpts{
9090
Namespace: "app",
9191
Name: "calls",
92+
Help: "application calls counter",
9293
}, []string{
9394
"method",
9495
"success",
9596
})
9697
callsLatency = prometheus.NewHistogramVec(prometheus.HistogramOpts{
9798
Namespace: "app",
9899
Name: "latency",
100+
Help: "application calls latencies",
99101
Buckets: []float64{
100102
(1 * time.Millisecond).Seconds(),
101103
(5 * time.Millisecond).Seconds(),
@@ -114,6 +116,7 @@ func getService(ctx context.Context, dsn string, opts ...ydb.Option) (s *service
114116
callsErrors = prometheus.NewGaugeVec(prometheus.GaugeOpts{
115117
Namespace: "app",
116118
Name: "errors",
119+
Help: "application errors counter",
117120
}, []string{
118121
"method",
119122
})

0 commit comments

Comments
 (0)