fix reviews

Author: art22m

internal/topic/retriable_error.go

@@ -13,7 +13,8 @@ import (
 )
 
 const (
-	DefaultStartTimeout = time.Minute
+	DefaultStartTimeout          = time.Minute
+	connectionEstablishedTimeout = time.Minute
 )
 
 type RetrySettings struct {
@@ -46,7 +47,7 @@ var (
 func CheckResetReconnectionCounters(lastTry, now time.Time, connectionTimeout time.Duration) bool {
 	const resetAttemptEmpiricalCoefficient = 10
 	if connectionTimeout == value.InfiniteDuration {
-		return false
+		return now.Sub(lastTry) > connectionEstablishedTimeout
 	}
 	return now.Sub(lastTry) > connectionTimeout*resetAttemptEmpiricalCoefficient
 }

internal/topic/retriable_error_test.go

@@ -243,11 +243,17 @@ func TestCheckResetReconnectionCounters(t *testing.T) {
 		shouldReset       bool
 	}{
 		{
-			name:              "InfiniteConnectionTimeout",
-			lastTry:           time.Time{},
+			name:              "RecentLastTryWithInfiniteConnectionTimeout",
+			lastTry:           now.Add(-30 * time.Second),
 			connectionTimeout: value.InfiniteDuration,
 			shouldReset:       false,
 		},
+		{
+			name:              "OldLastTryWithInfiniteConnectionTimeout",
+			lastTry:           now.Add(-30 * time.Minute),
+			connectionTimeout: value.InfiniteDuration,
+			shouldReset:       true,
+		},
 		{
 			name:              "LastTryLessThanConnectionTimeout",
 			lastTry:           now.Add(-30 * time.Second),