* Removed check the node is available for table service sessions

Author: asmyasnikov

CHANGELOG.md

@@ -1,4 +1,4 @@
-* Diabled check the node is available for query service session 
+* Removed check the node is available for query and table service sessions 
 
 ## v3.74.2
 * Added description to scan errors with use query service client scanner

internal/table/client.go

@@ -25,44 +25,34 @@ import (
 // sessionBuilder is the interface that holds logic of creating sessions.
 type sessionBuilder func(ctx context.Context) (*session, error)
 
-type nodeChecker interface {
-	HasNode(id uint32) bool
-}
-
-type balancer interface {
-	grpc.ClientConnInterface
-	nodeChecker
-}
-
-func New(ctx context.Context, balancer balancer, config *config.Config) *Client {
+func New(ctx context.Context, cc grpc.ClientConnInterface, config *config.Config) *Client {
 	onDone := trace.TableOnInit(config.Trace(), &ctx,
 		stack.FunctionID("github.com/ydb-platform/ydb-go-sdk/3/internal/table.New"),
 	)
 	defer func() {
 		onDone(config.SizeLimit())
 	}()
 
-	return newClient(ctx, balancer, func(ctx context.Context) (s *session, err error) {
-		return newSession(ctx, balancer, config)
+	return newClient(ctx, cc, func(ctx context.Context) (s *session, err error) {
+		return newSession(ctx, cc, config)
 	}, config)
 }
 
 func newClient(
 	ctx context.Context,
-	balancer balancer,
+	cc grpc.ClientConnInterface,
 	builder sessionBuilder,
 	config *config.Config,
 ) *Client {
 	c := &Client{
-		clock:       config.Clock(),
-		config:      config,
-		cc:          balancer,
-		nodeChecker: balancer,
-		build:       builder,
-		index:       make(map[*session]sessionInfo),
-		idle:        list.New(),
-		waitQ:       list.New(),
-		limit:       config.SizeLimit(),
+		clock:  config.Clock(),
+		config: config,
+		cc:     cc,
+		build:  builder,
+		index:  make(map[*session]sessionInfo),
+		idle:   list.New(),
+		waitQ:  list.New(),
+		limit:  config.SizeLimit(),
 		waitChPool: sync.Pool{
 			New: func() interface{} {
 				ch := make(chan *session)
@@ -84,11 +74,10 @@ func newClient(
 // A Client is safe for use by multiple goroutines simultaneously.
 type Client struct {
 	// read-only fields
-	config      *config.Config
-	build       sessionBuilder
-	cc          grpc.ClientConnInterface
-	nodeChecker nodeChecker
-	clock       clockwork.Clock
+	config *config.Config
+	build  sessionBuilder
+	cc     grpc.ClientConnInterface
+	clock  clockwork.Clock
 
 	// read-write fields
 	mu                xsync.Mutex
@@ -404,7 +393,7 @@ func (c *Client) internalPoolGet(ctx context.Context, opts ...getOption) (s *ses
 		i++
 		s = tryGetIdleSession(c)
 		if s != nil {
-			if !isValidNode(c, s) {
+			if !s.isReady() {
 				closeInvalidSession(ctx, s)
 				s = nil
 
@@ -437,11 +426,6 @@ func tryGetIdleSession(c *Client) *session {
 	return s
 }
 
-//nolint:interfacer
-func isValidNode(c *Client, s *session) bool {
-	return c.nodeChecker == nil || c.nodeChecker.HasNode(s.NodeID())
-}
-
 func closeInvalidSession(ctx context.Context, s *session) {
 	_ = s.Close(ctx)
 }
@@ -599,9 +583,6 @@ func (c *Client) Put(ctx context.Context, s *session) (err error) {
 	case s.isClosed():
 		return xerrors.WithStackTrace(errSessionClosed)
 
-	case c.nodeChecker != nil && !c.nodeChecker.HasNode(s.NodeID()):
-		return xerrors.WithStackTrace(errNodeIsNotObservable)
-
 	default:
 		c.mu.Lock()
 		defer c.mu.Unlock()

internal/table/client_test.go

@@ -868,17 +868,17 @@ type StubBuilder struct {
 
 func newClientWithStubBuilder(
 	t testing.TB,
-	balancer balancer,
+	cc grpc.ClientConnInterface,
 	stubLimit int,
 	options ...config.Option,
 ) *Client {
 	c := newClient(
 		context.Background(),
-		balancer,
+		cc,
 		(&StubBuilder{
 			T:     t,
 			Limit: stubLimit,
-			cc:    balancer,
+			cc:    cc,
 		}).createSession,
 		config.New(options...),
 	)

internal/table/errors.go

@@ -32,9 +32,6 @@ var (
 	// operation could not be completed.
 	errNoProgress = xerrors.Wrap(errors.New("no progress"))
 
-	// errNodeIsNotObservable returned by a Client instance to indicate that required node is not observable
-	errNodeIsNotObservable = xerrors.Wrap(errors.New("node is not observable"))
-
 	// errParamsRequired returned by a Client instance to indicate that required params is not defined
 	errParamsRequired = xerrors.Wrap(errors.New("params required"))
 )

internal/table/session.go

@@ -113,6 +113,10 @@ func (s *session) isClosing() bool {
 	return s.Status() == table.SessionClosing
 }
 
+func (s *session) isReady() bool {
+	return s.Status() == table.SessionReady
+}
+
 func newSession(ctx context.Context, cc grpc.ClientConnInterface, config *config.Config) (
 	s *session, err error,
 ) {