enable interfacer linter (#1024)

* enable interfacer linter

Author: lastbyte32

.golangci.yml

@@ -235,7 +235,6 @@ linters:
     - gomoddirectives
     - ifshort
     - interfacebloat
-    - interfacer
     - ireturn
     - maintidx
     - maligned

examples/topic/cdc-cache-bus-freeseats/webserver.go

@@ -81,7 +81,7 @@ func (s *server) BuyTicketHandler(writer http.ResponseWriter, request *http.Requ
 	s.writeAnswer(writer, freeSeats, duration)
 }
 
-func (s *server) writeAnswer(writer http.ResponseWriter, freeSeats int64, duration time.Duration) {
+func (s *server) writeAnswer(writer io.Writer, freeSeats int64, duration time.Duration) {
 	_, _ = fmt.Fprintf(writer, "%v\n\nDuration: %v\n", freeSeats, duration)
 }
 

internal/cmd/gtrace/writer.go

@@ -601,7 +601,7 @@ func (w *Writer) constructParams(params []Param, names []string) (res []string)
 	return res
 }
 
-func (w *Writer) constructStruct(n *types.Named, s *types.Struct, vars []string) (string, []string) {
+func (w *Writer) constructStruct(n types.Type, s *types.Struct, vars []string) (string, []string) {
 	p := w.declare("p")
 	// maybe skip pointers from flattening to not allocate anyhing during trace.
 	w.line(`var `, p, ` `, w.typeString(n))

internal/table/client_test.go

@@ -18,6 +18,7 @@ import (
 	"google.golang.org/protobuf/proto"
 	"google.golang.org/protobuf/types/known/emptypb"
 
+	"github.com/ydb-platform/ydb-go-sdk/v3/internal/closer"
 	"github.com/ydb-platform/ydb-go-sdk/v3/internal/table/config"
 	"github.com/ydb-platform/ydb-go-sdk/v3/internal/xatomic"
 	"github.com/ydb-platform/ydb-go-sdk/v3/internal/xcontext"
@@ -769,7 +770,7 @@ func mustPutSession(t testing.TB, p *Client, s *session) {
 	}
 }
 
-func mustClose(t testing.TB, p *Client) {
+func mustClose(t testing.TB, p closer.Closer) {
 	wg := sync.WaitGroup{}
 	defer wg.Wait()
 	if err := p.Close(context.Background()); err != nil {

log/discovery.go

@@ -11,7 +11,7 @@ func Discovery(l Logger, d trace.Detailer, opts ...Option) (t trace.Discovery) {
 	return internalDiscovery(wrapLogger(l, opts...), d)
 }
 
-func internalDiscovery(l *wrapper, d trace.Detailer) (t trace.Discovery) {
+func internalDiscovery(l Logger, d trace.Detailer) (t trace.Discovery) {
 	t.OnDiscover = func(info trace.DiscoveryDiscoverStartInfo) func(trace.DiscoveryDiscoverDoneInfo) {
 		if d.Details()&trace.DiscoveryEvents == 0 {
 			return nil

log/driver.go

@@ -13,7 +13,7 @@ func Driver(l Logger, d trace.Detailer, opts ...Option) (t trace.Driver) {
 	return internalDriver(wrapLogger(l, opts...), d)
 }
 
-func internalDriver(l *wrapper, d trace.Detailer) (t trace.Driver) { //nolint:gocyclo
+func internalDriver(l Logger, d trace.Detailer) (t trace.Driver) { //nolint:gocyclo
 	t.OnResolve = func(
 		info trace.DriverResolveStartInfo,
 	) func(

log/retry.go

@@ -13,7 +13,7 @@ func Retry(l Logger, d trace.Detailer, opts ...Option) (t trace.Retry) {
 	return internalRetry(wrapLogger(l, opts...), d)
 }
 
-func internalRetry(l *wrapper, d trace.Detailer) (t trace.Retry) {
+func internalRetry(l Logger, d trace.Detailer) (t trace.Retry) {
 	t.OnRetry = func(
 		info trace.RetryLoopStartInfo,
 	) func(

log/topic.go

@@ -12,7 +12,7 @@ func Topic(l Logger, d trace.Detailer, opts ...Option) (t trace.Topic) {
 	return internalTopic(wrapLogger(l, opts...), d)
 }
 
-func internalTopic(l *wrapper, d trace.Detailer) (t trace.Topic) { //nolint:gocyclo
+func internalTopic(l Logger, d trace.Detailer) (t trace.Topic) { //nolint:gocyclo
 	t.OnReaderReconnect = func(
 		info trace.TopicReaderReconnectStartInfo,
 	) func(doneInfo trace.TopicReaderReconnectDoneInfo) {

table/types/types.go

@@ -120,7 +120,7 @@ const (
 // WriteTypeStringTo writes ydb type string representation into buffer
 //
 // Deprecated: use types.Type.Yql() instead
-func WriteTypeStringTo(buf *bytes.Buffer, t Type) {
+func WriteTypeStringTo(buf *bytes.Buffer, t Type) { //nolint: interfacer
 	buf.WriteString(t.Yql())
 }