Merge pull request #52 from dzenanz/master

Fixes for compiling on VS2019

Author: JohanMabille

CMakeLists.txt

@@ -248,6 +248,7 @@ macro(xtensor_zarr_create_target source target_name linkage output_name)
         ${target_name}
         PUBLIC nlohmann_json::nlohmann_json
         PUBLIC xtl
+        PUBLIC xtensor-zarr
     )
 
     set_target_properties(
@@ -261,6 +262,11 @@ macro(xtensor_zarr_create_target source target_name linkage output_name)
         OUTPUT_NAME "lib${output_name}"
     )
 
+    if (MSVC) # the object files can get big, so we need to "Increase Number of Sections in .Obj file"
+        # target_compile_definitions(${target_name} PUBLIC COMPILE_DEFINITIONS -Dbigobj) # doesn't work
+        set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /bigobj")
+    endif()
+
     # Compilation flags
     # =================
 

include/xtensor-zarr/xzarr_file_system_store.hpp

@@ -124,7 +124,7 @@ namespace xt
             {
                 if (!fs::is_directory(directory))
                 {
-                    XTENSOR_THROW(std::runtime_error, "Path is not a directory: " + std::string(directory));
+                    XTENSOR_THROW(std::runtime_error, "Path is not a directory: " + std::string(directory.string()));
                 }
             }
             else
@@ -209,7 +209,7 @@ namespace xt
         std::string path = m_root + '/' + prefix;
         for (const auto& entry: fs::directory_iterator(path))
         {
-            std::string p = entry.path();
+            std::string p = entry.path().string();
             if (fs::is_directory(p))
             {
                 prefixes.push_back(p.substr(m_root.size() + 1));
@@ -244,7 +244,7 @@ namespace xt
         std::vector<std::string> keys;
         for (const auto& entry: fs::recursive_directory_iterator(path))
         {
-            std::string p = entry.path();
+            std::string p = entry.path().string();
             keys.push_back(p.substr(m_root.size() + 1));
         }
         return keys;