Skip to content

Commit 0ab6257

Browse files
authored
Merge pull request #152 from BioDataAnalysis/emmenlau_minor_cmake_fixes
Minor cmake fixes
2 parents 0a9aee8 + 13895e0 commit 0ab6257

File tree

3 files changed

+11
-8
lines changed

3 files changed

+11
-8
lines changed

CMakeLists.txt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -88,10 +88,10 @@ if (CXXBLAS_DEBUG)
8888
endif()
8989

9090
OPTION(BUILD_TESTS "xtensor-blas test suite" OFF)
91-
OPTION(DOWNLOAD_GTEST "build gtest from downloaded sources" OFF)
91+
OPTION(BUILD_BENCHMARK "xtensor-blas test suite" OFF)
9292

93-
OPTION(BUILD_BENCHMARKS "xtensor-blas test suite" OFF)
94-
OPTION(DOWNLOAD_GBENCHMARK "build gtest from downloaded sources" OFF)
93+
OPTION(DOWNLOAD_GTEST "download gtest and build from source" OFF)
94+
OPTION(DOWNLOAD_GBENCHMARK "download google benchmark and build from source" OFF)
9595

9696
if(DOWNLOAD_GTEST OR GTEST_SRC_DIR)
9797
set(BUILD_TESTS ON)

benchmark/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ if (CMAKE_CURRENT_SOURCE_DIR STREQUAL CMAKE_SOURCE_DIR)
1212
project(xtensor-benchmark)
1313

1414
find_package(xtensor REQUIRED CONFIG)
15-
set(XTENSOR_INCLUDE_DIR ${xtensor_INCLUDE_DIR})
15+
set(XTENSOR_INCLUDE_DIR ${xtensor_INCLUDE_DIRS})
1616
endif ()
1717

1818
message(STATUS "Forcing tests build type to Release")

test/CMakeLists.txt

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -13,13 +13,17 @@ if (CMAKE_CURRENT_SOURCE_DIR STREQUAL CMAKE_SOURCE_DIR)
1313
project(xtensor-blas-test)
1414

1515
find_package(xtensor REQUIRED CONFIG)
16-
set(XTENSOR_INCLUDE_DIR ${xtensor_INCLUDE_DIR})
16+
set(XTENSOR_INCLUDE_DIR ${xtensor_INCLUDE_DIRS})
1717
find_package(xtensor-blas REQUIRED CONFIG)
1818
set(XTENSOR_BLAS_INCLUDE_DIR ${xblas_INCLUDE_DIRS})
1919
endif ()
2020

21-
message(STATUS "Forcing tests build type to Release")
22-
set(CMAKE_BUILD_TYPE Release CACHE STRING "Choose the type of build." FORCE)
21+
if(NOT CMAKE_BUILD_TYPE)
22+
message(STATUS "Setting tests build type to Release")
23+
set(CMAKE_BUILD_TYPE Release CACHE STRING "Choose the type of build." FORCE)
24+
else()
25+
message(STATUS "Tests build type is ${CMAKE_BUILD_TYPE}")
26+
endif()
2327

2428
include(CheckCXXCompilerFlag)
2529

@@ -110,7 +114,6 @@ include_directories(${GTEST_INCLUDE_DIRS} SYSTEM)
110114
include_directories(${XTENSOR_INCLUDE_DIR})
111115
include_directories(${XBLAS_INCLUDE_DIR})
112116

113-
find_package(xtensor REQUIRED)
114117
if(USE_OPENBLAS)
115118
find_package(OpenBLAS REQUIRED)
116119
set(BLAS_LIBRARIES ${CMAKE_INSTALL_PREFIX}${OpenBLAS_LIBRARIES})

0 commit comments

Comments
 (0)