Provide MSVC-compatible implementation of fabs on AVX512

serge-sans-paille · serge-sans-paille · commit eb419805746e · 2021-04-08T15:44:48.000+02:00
diff --git a/include/xsimd/types/xsimd_avx512_double.hpp b/include/xsimd/types/xsimd_avx512_double.hpp
@@ -449,8 +449,11 @@ namespace xsimd
 
             static batch_type abs(const batch_type& rhs)
             {
-                return (__m512d)(_mm512_and_epi64(_mm512_set1_epi64(0x7FFFFFFFFFFFFFFF),
-                                                  (__m512i)((__m512d)(rhs))));
+                __m512d rhs_asd = (__m512d)rhs;
+                __m512i rhs_asi = *reinterpret_cast<__m512i*>(&rhs_asd);
+                __m512i res_asi = _mm512_and_epi64(_mm512_set1_epi64(0x7FFFFFFFFFFFFFFF),
+                                                   rhs_asi);
+                return *reinterpret_cast<__m512d*>(&res_asi);
             }
 
             static batch_type fabs(const batch_type& rhs)
diff --git a/include/xsimd/types/xsimd_avx512_float.hpp b/include/xsimd/types/xsimd_avx512_float.hpp
@@ -472,8 +472,11 @@ namespace xsimd
 
             static batch_type abs(const batch_type& rhs)
             {
-                return (__m512)(_mm512_and_epi32((__m512i)((__m512)(rhs)),
-                                                 _mm512_set1_epi32(0x7fffffff)));
+                __m512 rhs_asf = (__m512)rhs;
+                __m512i rhs_asi = *reinterpret_cast<__m512i*>(&rhs_asf);
+                __m512i res_asi = _mm512_and_epi32(_mm512_set1_epi32(0x7FFFFFFF),
+                                                   rhs_asi);
+                return *reinterpret_cast<__m512*>(&res_asi);
             }
 
             static batch_type fabs(const batch_type& rhs)

Original file line number	Diff line number	Diff line change
`@@ -449,8 +449,11 @@ namespace xsimd`
`449`	`449`
`450`	`450`	`static batch_type abs(const batch_type& rhs)`
`451`	`451`	`{`
`452`		`- return (__m512d)(_mm512_and_epi64(_mm512_set1_epi64(0x7FFFFFFFFFFFFFFF),`
`453`		`- (__m512i)((__m512d)(rhs))));`
	`452`	`+ __m512d rhs_asd = (__m512d)rhs;`
	`453`	`+ __m512i rhs_asi = reinterpret_cast<__m512i>(&rhs_asd);`
	`454`	`+ __m512i res_asi = _mm512_and_epi64(_mm512_set1_epi64(0x7FFFFFFFFFFFFFFF),`
	`455`	`+ rhs_asi);`
	`456`	`+ return reinterpret_cast<__m512d>(&res_asi);`
`454`	`457`	`}`
`455`	`458`
`456`	`459`	`static batch_type fabs(const batch_type& rhs)`
Original file line number	Diff line number	Diff line change
`@@ -472,8 +472,11 @@ namespace xsimd`
`472`	`472`
`473`	`473`	`static batch_type abs(const batch_type& rhs)`
`474`	`474`	`{`
`475`		`- return (__m512)(_mm512_and_epi32((__m512i)((__m512)(rhs)),`
`476`		`- _mm512_set1_epi32(0x7fffffff)));`
	`475`	`+ __m512 rhs_asf = (__m512)rhs;`
	`476`	`+ __m512i rhs_asi = reinterpret_cast<__m512i>(&rhs_asf);`
	`477`	`+ __m512i res_asi = _mm512_and_epi32(_mm512_set1_epi32(0x7FFFFFFF),`
	`478`	`+ rhs_asi);`
	`479`	`+ return reinterpret_cast<__m512>(&res_asi);`
`477`	`480`	`}`
`478`	`481`
`479`	`482`	`static batch_type fabs(const batch_type& rhs)`