Implemented isnan for batch of complexes (#590)

Author: JohanMabille

include/xsimd/arch/generic/xsimd_generic_complex.hpp

@@ -61,6 +61,11 @@ namespace xsimd {
                                copysign(real_batch(real_value_type(0)), imag(self))),
                     batch_type(self));
     }
+
+    template <class A, class T>
+    batch_bool<T, A> isnan(batch<std::complex<T>, A> const& self, requires_arch<generic>) {
+      return batch_bool<T, A>(isnan(self.real()) || isnan(self.imag()));
+    }
   }
 }
 

include/xsimd/arch/generic/xsimd_generic_details.hpp

@@ -59,7 +59,7 @@ namespace xsimd {
   template<class T, class A>
   batch_bool<T, A> isinf(batch<T, A> const& self);
   template<class T, class A>
-  batch_bool<T, A> isnan(batch<T, A> const& self);
+  typename batch<T, A>::batch_bool_type isnan(batch<T, A> const& self);
   template<class T, class A>
   batch<T, A> ldexp(const batch<T, A>& x, const batch<as_integer_t<T>, A>& e);
   template<class T, class A>

include/xsimd/types/xsimd_api.hpp

@@ -852,7 +852,7 @@ batch_bool<T, A> isfinite(batch<T, A> const& x) {
  * @return a batch of booleans.
  */
 template<class T, class A>
-batch_bool<T, A> isnan(batch<T, A> const& x) {
+typename batch<T, A>::batch_bool_type isnan(batch<T, A> const& x) {
   return kernel::isnan<A>(x, A{});
 }
 

include/xsimd/types/xsimd_traits.hpp

@@ -148,6 +148,12 @@ namespace xsimd
         {
         };
 
+        template <class T2, class A>
+        struct simd_return_type_impl<bool, std::complex<T2>, A>
+            : std::enable_if<simd_condition<bool, T2>::value, batch_bool<T2, A>>
+        {
+        };
+
         template <class T1, class T2, class A>
         struct simd_return_type_impl<std::complex<T1>, T2, A>
             : std::enable_if<simd_condition<T1, T2>::value, batch<std::complex<T2>, A>>

test/test_batch_complex.cpp

@@ -574,6 +574,17 @@ class batch_complex_test : public testing::Test
         }
     }
 
+    void test_isnan() const
+    {
+        {
+            bool_array_type expected;
+            std::transform(lhs.cbegin(), lhs.cend(), expected.begin(),
+                            [](const value_type& l) { return std::isnan(l.real()) || std::isnan(l.imag()); });
+            typename batch_type::batch_bool_type res = isnan(batch_lhs());
+            EXPECT_BATCH_EQ(res, expected) << print_function_name("isnan");
+        }
+    }
+
 private:
 
     batch_type batch_lhs() const
@@ -647,3 +658,8 @@ TYPED_TEST(batch_complex_test, boolean_conversion)
 {
     this->test_boolean_conversion();
 }
+
+TYPED_TEST(batch_complex_test, isnan)
+{
+    this->test_isnan();
+}

test/test_traits.cpp

@@ -110,7 +110,7 @@ class complex_traits_test : public testing::Test
         EXPECT_TRUE(res1);
 
         using rtype2 = xsimd::simd_return_type<bool, value_type>;
-        constexpr bool res2 = std::is_same<rtype2, xsimd::batch_bool<value_type>>::value;
+        constexpr bool res2 = std::is_same<rtype2, xsimd::batch_bool<typename value_type::value_type>>::value;
         EXPECT_TRUE(res2);
     }
 };