Fix uninitialized read in lgamma implementation

serge-sans-paille · serge-sans-paille · commit 6c86b23162e6 · 2024-05-20T20:49:50.000Z
Fix #456 Fix #807
diff --git a/include/xsimd/arch/generic/xsimd_generic_math.hpp b/include/xsimd/arch/generic/xsimd_generic_math.hpp
@@ -1235,7 +1235,7 @@ namespace xsimd
                     inf_result = (x == constants::infinity<batch_type>()) || inf_result;
 #endif
                     auto ltza = a < batch_type(0.);
-                    batch_type r;
+                    batch_type r(0);
                     batch_type r1 = other(q);
                     if (any(ltza))
                     {

Original file line number	Diff line number	Diff line change
`@@ -1235,7 +1235,7 @@ namespace xsimd`
`1235`	`1235`	`inf_result = (x == constants::infinity<batch_type>()) \|\| inf_result;`
`1236`	`1236`	`#endif`
`1237`	`1237`	`auto ltza = a < batch_type(0.);`
`1238`		`- batch_type r;`
	`1238`	`+ batch_type r(0);`
`1239`	`1239`	`batch_type r1 = other(q);`
`1240`	`1240`	`if (any(ltza))`
`1241`	`1241`	`{`