Merge pull request #124 from xmlrunner/qa

pep8 / flake8 for test code.

Author: dnozay

tests/builder_test.py

@@ -135,7 +135,7 @@ def test_end_root_context(self):
 
     def test_end_nested_context(self):
         self.builder.begin_context('testsuite', 'name')
-        nested = self.builder.current_context()
+        self.builder.current_context()
 
         self.assertTrue(self.builder.end_context())
 
@@ -187,7 +187,7 @@ def test_append_invalid_unicode_cdata_section(self):
         self.assertEqual(cdata.data, self.invalid_chars_replace)
 
     def test_append_cdata_closing_tags_into_cdata_section(self):
-        self.builder.append_cdata_section('tag',']]>')
+        self.builder.append_cdata_section('tag', ']]>')
         self.builder.end_context()
         root_child = self.doc.childNodes[0]
         cdata_container = root_child.childNodes[0]

tests/django_example/app/admin.py

@@ -1,3 +1,3 @@
-from django.contrib import admin
+from django.contrib import admin  # NOQA
 
 # Register your models here.

tests/django_example/app/models.py

@@ -1,3 +1,3 @@
-from django.db import models
+from django.db import models  # NOQA
 
 # Create your models here.

tests/django_example/app/tests.py

@@ -1,6 +1,7 @@
 from django.test import TestCase
 
+
 # Create your tests here.
 class DummyTestCase(TestCase):
     def test_pass(self):
-        pass
+        pass

tests/django_example/app/views.py

@@ -1,3 +1,3 @@
-from django.shortcuts import render
+from django.shortcuts import render  # NOQA
 
 # Create your views here.

tests/django_example/app2/admin.py

@@ -1,3 +1,3 @@
-from django.contrib import admin
+from django.contrib import admin  # NOQA
 
 # Register your models here.

tests/django_example/app2/models.py

@@ -1,3 +1,3 @@
-from django.db import models
+from django.db import models  # NOQA
 
 # Create your models here.

tests/django_example/app2/tests.py

@@ -1,5 +1,6 @@
 from django.test import TestCase
 
+
 # Create your tests here.
 class DummyTestCase(TestCase):
     def test_pass(self):

tests/django_example/app2/views.py

@@ -1,3 +1,3 @@
-from django.shortcuts import render
+from django.shortcuts import render  # NOQA
 
 # Create your views here.

tests/django_test.py

@@ -1,7 +1,6 @@
 from xmlrunner.unittest import unittest
 
 import sys
-import os
 from os import path, chdir, getcwd
 
 try:
@@ -13,8 +12,10 @@
 
 TESTS_DIR = path.dirname(__file__)
 
+
 @unittest.skipIf(django is None, 'django not found')
 class DjangoTest(unittest.TestCase):
+
     def setUp(self):
         self._old_cwd = getcwd()
         self.project_dir = path.abspath(path.join(TESTS_DIR, 'django_example'))
@@ -27,30 +28,30 @@ def tearDown(self):
         chdir(self._old_cwd)
 
     def _check_runner(self, runner):
-        suite = runner.build_suite(test_labels=['app2','app'])
-        test_ids = [ test.id() for test in suite ]
+        suite = runner.build_suite(test_labels=['app2', 'app'])
+        test_ids = [test.id() for test in suite]
         self.assertEqual(test_ids, [
             'app2.tests.DummyTestCase.test_pass',
             'app.tests.DummyTestCase.test_pass',
         ])
         suite = runner.build_suite(test_labels=[])
-        test_ids = [ test.id() for test in suite ]
+        test_ids = [test.id() for test in suite]
         self.assertEqual(set(test_ids), set([
             'app.tests.DummyTestCase.test_pass',
             'app2.tests.DummyTestCase.test_pass',
         ]))
 
     def test_django_runner(self):
         from django.conf import settings
-        settings.configure(INSTALLED_APPS=['app','app2'])
+        settings.configure(INSTALLED_APPS=['app', 'app2'])
         runner_class = get_runner(settings)
         runner = runner_class()
         self._check_runner(runner)
 
     def test_django_xmlrunner(self):
         from django.conf import settings
         settings.configure(
-            INSTALLED_APPS=['app','app2'],
+            INSTALLED_APPS=['app', 'app2'],
             TEST_RUNNER='xmlrunner.extra.djangotestrunner.XMLTestRunner')
         runner_class = get_runner(settings)
         runner = runner_class()