improvement(ddd): adding more imput validation

Author: xmlking

libs/ddd/README.md

@@ -59,6 +59,11 @@ nx g @xmlking/nxp-ddd:entity user --domain booking
 nx g @xmlking/nxp-ddd:entity seat --domain boarding
 ```
 
+### Post action
+
+After generation all modules, you might have to remove `pathMatch: 'full'` and adjust your routes in some module's Router config .<br/>
+Optionally add `<router-outlet></router-outlet>` in shell component's HTML
+
 ## Running unit tests
 
 Run `nx test ddd` to execute the unit tests via [Jest](https://jestjs.io).

libs/ddd/src/schematics/domain/index.ts

@@ -14,6 +14,36 @@ import { DomainOptions } from './schema';
 
 export default function (options: DomainOptions): Rule {
   return (host: Tree) => {
+    const workspace = getWorkspace(host);
+    // getting project name
+    if (!options.app) {
+      if (workspace.defaultProject) {
+        options.app = workspace.defaultProject;
+      } else {
+        throw new SchematicsException('No Angular project selected and no default project in the workspace');
+      }
+    }
+
+    // Validating project name
+    const project = workspace.projects[options.app];
+    if (!project) {
+      throw new SchematicsException('The specified Angular project is not defined in this workspace');
+    }
+
+    // Checking if it is application
+    if (project.projectType !== 'application') {
+      throw new SchematicsException(`Domain requires an Angular project type of "application" in angular.json`);
+    }
+
+    const appName = options.app;
+    const appFolderName = dasherize(appName);
+    const appModulePath = `apps/${appFolderName}/src/app/app.module.ts`;
+
+    // Checking if appModulePath exists
+    if (!host.exists(appModulePath)) {
+      throw new SchematicsException(`Specified app ${options.app} does not exist: ${appModulePath} expected!`);
+    }
+
     const domainName = dasherize(options.name);
     const domainFolderName = domainName;
     const domainPath = `libs/${domainFolderName}/domain/src/lib`;
@@ -31,14 +61,6 @@ export default function (options: DomainOptions): Rule {
       };
     }
 
-    const appName = options.app ?? getWorkspace(host)?.defaultProject;
-    const appFolderName = dasherize(appName);
-    const appModulePath = `apps/${appFolderName}/src/app/app.module.ts`;
-
-    if (!host.exists(appModulePath)) {
-      throw new SchematicsException(`Specified app ${options.app} does not exist: ${appModulePath} expected!`);
-    }
-
     return chain([
       externalSchematic('@nrwl/angular', 'lib', {
         name: `shell${suffix}`,

libs/ddd/src/schematics/feature/index.ts

@@ -1,5 +1,5 @@
 import { normalize } from '@angular-devkit/core';
-import { dasherize } from '@angular-devkit/core/src/utils/strings';
+import { capitalize, dasherize } from '@angular-devkit/core/src/utils/strings';
 import {
   chain,
   externalSchematic,
@@ -10,10 +10,34 @@ import {
   SchematicsException,
   Tree,
 } from '@angular-devkit/schematics';
+import { getWorkspace } from '@schematics/angular/utility/config';
 import { FeatureOptions } from './schema';
 
 export default function (options: FeatureOptions): Rule {
   return (host: Tree) => {
+    const workspace = getWorkspace(host);
+    const domainProjectName = dasherize(
+      `${options.domain}Shell${options.platform ? capitalize(options.platform) : ''}`
+    );
+    const domainShellProjectName = dasherize(
+      `${options.domain}Domain${options.platform ? capitalize(options.platform) : ''}`
+    );
+
+    // Validating domain name
+    const domainProject = workspace.projects[domainProjectName];
+    if (!domainProject) {
+      throw new SchematicsException('The specified domain is not defined in this workspace');
+    } else if (domainProject.projectType !== 'library') {
+      throw new SchematicsException(`${domainProjectName} should be Angular project type of "library" in angular.json`);
+    }
+
+    const domainShellProject = workspace.projects[domainShellProjectName];
+    if (!domainShellProject) {
+      throw new SchematicsException('The specified domain shell is not defined in this workspace');
+    } else if (domainShellProject.projectType !== 'library') {
+      `${domainShellProjectName} should be Angular project type of "library" in angular.json`;
+    }
+
     const domainName = dasherize(options.domain);
     const domainFolderName = domainName;
 

libs/ddd/src/schematics/ng-add/index.ts

@@ -1,6 +1,34 @@
-import { chain, Rule } from '@angular-devkit/schematics';
-import { addNgxsToPackageJson, initLintingRules } from '../rules';
+import { chain, Rule, SchematicContext, Tree } from '@angular-devkit/schematics';
+import { NodePackageInstallTask } from '@angular-devkit/schematics/tasks';
+import { addDepsToPackageJson } from '@nrwl/workspace/src/utils/ast-utils';
+import { initLintingRules } from '../rules';
 
-export default function(): Rule {
-  return chain([initLintingRules(), addNgxsToPackageJson()]);
+const ngxsVersion = '^3.6.2';
+const dddVersion = '^0.2.0';
+export function addPackageJsonDependencies(): Rule {
+  return addDepsToPackageJson(
+    {
+      '@ngxs/devtools-plugin': ngxsVersion,
+      '@ngxs/form-plugin': ngxsVersion,
+      '@ngxs/logger-plugin': ngxsVersion,
+      '@ngxs/router-plugin': ngxsVersion,
+      '@ngxs/storage-plugin': ngxsVersion,
+      '@ngxs/store': ngxsVersion,
+    },
+    // always add the package under dev dependencies
+    { '@xmlking/nxp-ddd': dddVersion }
+  );
+}
+
+export function installPackageJsonDependencies(): Rule {
+  return (host: Tree, context: SchematicContext) => {
+    context.addTask(new NodePackageInstallTask());
+    context.logger.log('info', `🔍 Installing packages...`);
+
+    return host;
+  };
+}
+
+export default function (): Rule {
+  return chain([initLintingRules(), addPackageJsonDependencies(), installPackageJsonDependencies()]);
 }

libs/ddd/src/schematics/rules/add-ngxs-to-package-json.ts

@@ -1,8 +1,4 @@
 export { addExportsToBarrel } from './add-exports-to-barrel';
 export { addNgxsImportsToModule } from './add-ngxs-imports-to-module';
-export { addNgxsToPackageJson } from './add-ngxs-to-package-json';
 export { readWorkspaceName } from './read-workspace-name';
-export {
-  addDomainToLintingRules,
-  initLintingRules
-} from './update-linting-rules';
+export { addDomainToLintingRules, initLintingRules } from './update-linting-rules';