Skip to content

Auto-update ktx to v4.4.2 #8587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Auto-update ktx to v4.4.2 #8587

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/k/ktx/xmake.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ package("ktx")
add_urls("https://github.com/KhronosGroup/KTX-Software/archive/refs/tags/$(version).tar.gz",
"https://github.com/KhronosGroup/KTX-Software.git", {submodules = false})

add_versions("v4.4.2", "9412cb45045a503005acd47d98f9e8b47154634a50b4df21e17a1dfa8971d323")
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Nov 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

While adding the new version v4.4.2, it seems the patch for unbundling dependencies applied to version v4.4.0 will not be applied for this new version. The build for v4.4.2 will likely use the bundled astc-encoder dependency, which is probably not the desired behavior for this repository.

Please verify if the dep-unbundle.patch is still required for v4.4.2. If so, you should also apply it to this version. You could either add a new add_patches call for v4.4.2, or preferably, modify the existing one to apply to all 4.4.x versions using a semver range like ~4.4.0 to improve future maintainability.

add_versions("v4.4.0", "3585d76edcdcbe3a671479686f8c81c1c10339f419e4b02a9a6f19cc6e4e0612")

add_patches("4.4.0", "patches/4.4.0/dep-unbundle.patch", "2b883bcbfc19f80d72b812d68b606b6e2a4234d913ad92c45d8030bd94207a59")
Expand Down
Loading