Search tweaks

Converts dots in search result keys to underscores. Removes the page
parameter from the search endpoint since this is handled internally by
the paginator.

Author: mattantonelli

lib/xivapi/http.rb

@@ -41,7 +41,7 @@ def objectify(response)
     end
 
     def underscore(key)
-      key.gsub(/([a-z\d])([A-Z])/,'\1_\2').downcase
+      key.gsub(/([a-z\d])([A-Z])/,'\1_\2').gsub('.', '_').downcase
     end
   end
 end

lib/xivapi/request.rb

@@ -4,10 +4,9 @@ module XIVAPI::Request
   LODESTONE_LIMIT = 50.freeze
 
   def search(indexes: [], string: '', string_column: 'Name_en', string_algo: 'wildcard_plus',
-             page: 1, sort_field: nil, sort_order: nil, limit: 100, filters: [], columns: [])
+             sort_field: nil, sort_order: nil, limit: 100, filters: [], columns: [])
     params = { indexes: [*indexes].join(','), string: string, string_column: string_column, string_algo: string_algo,
-               page: page, sort_field: sort_field, sort_order: sort_order,
-               filters: [*filters].join(','), columns: [*columns].join(',') }
+               sort_field: sort_field, sort_order: sort_order, filters: [*filters].join(','), columns: [*columns].join(',') }
     XIVAPI::Paginator.new(self, params, 'search', limit)
   end