Fix search bug, small inconsistencies

Author: Kimon Kar

lib/character.js

@@ -1,6 +1,6 @@
 // https://xivapi.com/docs/Character
 const Lib = require('./Lib')
-let { makeStatus, correctCase } = require('../utils')
+let { firstCapital, makeStatus, correctCase } = require('../utils')
 
 class Character extends Lib {
 	constructor(parent) {
@@ -18,7 +18,7 @@ class Character extends Lib {
 		return new Promise((resolve, reject) => {
 			if(!name)
 				reject(Error('name must be defined'))
-			if(params.server && !this.parent.resources.servers.includes(this.parent.utils.firstCapital(params.server)))
+			if(params.server && !this.parent.resources.servers.includes(firstCapital(params.server)))
 				return(Error('server not valid'))
 
 			this.req(

lib/freecompany.js

@@ -1,6 +1,6 @@
 // https://xivapi.com/docs/Free-Company
 const Lib = require('./Lib')
-let { makeStatus, sanitizeInt, correctCase, makeCSV } = require('../utils')
+let { firstCapital, makeStatus, sanitizeInt, correctCase, makeCSV } = require('../utils')
 
 class FreeCompany extends Lib {
 	constructor(parent) {
@@ -18,7 +18,7 @@ class FreeCompany extends Lib {
 		return new Promise((resolve, reject) => {
 			if(typeof(name) === 'undefined')
 				reject(Error('name must be defined'))
-			if(params.server && !this.parent.resources.servers.includes(this.parent.utils.firstCapital(params.server)))
+			if(params.server && !this.parent.resources.servers.includes(firstCapital(params.server)))
 				reject(Error('server not valid'))
 
 			this.req(

lib/linkshell.js

@@ -1,6 +1,6 @@
 // https://xivapi.com/docs/Linkshell
 const Lib = require('./Lib')
-let { makeStatus, sanitizeInt, correctCase } = require('../utils')
+let { firstCapital, makeStatus, sanitizeInt, correctCase } = require('../utils')
 
 class Linkshell extends Lib {
 	constructor(parent) {
@@ -19,7 +19,7 @@ class Linkshell extends Lib {
 			if(typeof(name) === 'undefined')
 				reject(Error('name must be defined'))
 
-			if(params.server && !this.parent.resources.servers.includes(this.parent.utils.firstCapital(params.server)))
+			if(params.server && !this.parent.resources.servers.includes(firstCapital(params.server)))
 				reject(Error('server not valid'))
 
 			this.req(

lib/market.js

@@ -1,6 +1,6 @@
 // https://xivapi.com/docs/Welcome#section-4
 const Lib = require('./Lib')
-let { cleanContent, correctCase } = require('../utils')
+let { firstCapital, cleanContent, correctCase } = require('../utils')
 
 class Content extends Lib {
 	constructor(parent) {
@@ -9,13 +9,13 @@ class Content extends Lib {
 		cleanContent = cleanContent.bind(parent)
 	}
 
-	prices(id, server, params) {
+	prices(id, server, params = {}) {
 		return new Promise((resolve, reject) => {
 			if(typeof(id) === 'undefined')
 				reject(Error('id must be defined'))
 			if(typeof(server) === 'undefined')
 				reject(Error('server must be defined'))
-			if(!this.parent.resources.servers.includes(this.parent.utils.firstCapital(server)))
+			if(!this.parent.resources.servers.includes(firstCapital(server)))
 				reject(Error('server not valid'))
 
 			this.req(
@@ -44,7 +44,7 @@ class Content extends Lib {
 				reject(Error('id must be defined'))
 			if(typeof(server) === 'undefined')
 				reject(Error('server must be defined'))
-			if(!this.parent.resources.servers.includes(this.parent.utils.firstCapital(server)))
+			if(!this.parent.resources.servers.includes(firstCapital(server)))
 				reject(Error('server not valid'))
 
 
@@ -68,13 +68,13 @@ class Content extends Lib {
 		})
 	}
 
-	stock(category, server, params) {
+	stock(category, server, params = {}) {
 		return new Promise((resolve, reject) => {
 			if(typeof(category) === 'undefined')
 				reject(Error('category must be defined'))
 			if(typeof(server) === 'undefined')
 				reject(Error('server must be defined'))
-			if(!this.parent.resources.servers.includes(this.parent.utils.firstCapital(server)))
+			if(!this.parent.resources.servers.includes(firstCapital(server)))
 				reject(Error('server not valid'))
 
 			this.req(
@@ -93,7 +93,7 @@ class Content extends Lib {
 		})
 	}
 
-	categories(params) {
+	categories(params = {}) {
 		return new Promise((resolve, reject) => {
 			this.req(
 				'/market/categories',

lib/pvpteam.js

@@ -1,5 +1,5 @@
 const Lib = require('./Lib')
-let { makeStatus, sanitizeInt, correctCase } = require('../utils')
+let { firstCapital, makeStatus, sanitizeInt, correctCase } = require('../utils')
 
 class PvPTeam extends Lib {
 	constructor(parent) {
@@ -18,7 +18,7 @@ class PvPTeam extends Lib {
 			if(typeof(name) === 'undefined')
 				reject(Error('name must be defined'))
 
-			if(params.server && !this.parent.resources.servers.includes(this.parent.utils.firstCapital(params.server)))
+			if(params.server && !this.parent.resources.servers.includes(firstCapital(params.server)))
 				reject(Error('server not valid'))
 
 			this.req(

lib/search.js

@@ -12,6 +12,7 @@ let { req, reqJSON, cleanContent, correctCase, makeCSV } = require('../utils')
 */
 module.exports = function(input, params = {}) {
 	req = req.bind(this)
+	reqJSON = reqJSON.bind(this)
 	cleanContent = cleanContent.bind(this)
 
 	return new Promise((resolve, reject) => {