koji: Add supported git branches (eg: [8.3, master] for v8.3-* tags) #774
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rzr
force-pushed
the
phcoval/review/master
branch
from
05da6b2 to
e8eb4fb
Compare
rzr
force-pushed
the
phcoval/review/master
branch
from
e8eb4fb to
b07bb55
Compare
glehmann
approved these changes
Nov 25, 2025
Member
glehmann
left a comment
glehmann
left a comment
There was a problem hiding this comment.
Just a small remark, otherwise LGTM :)
rzr
force-pushed
the
phcoval/review/master
branch
from
b07bb55 to
4ba0323
Compare
ydirson
requested changes
Nov 26, 2025
Contributor
ydirson
left a comment
ydirson
left a comment
There was a problem hiding this comment.
In the commit message:
- you can drop the "To my understanding," prefix of that paragraph, your understanding is actually correct :)
- maybe the paragraph about 9.1 and 10 could be dropped, as well as the last "what is unclear to me"?
rzr
added a commit
that referenced
this pull request
Nov 26, 2025
Which is semantically different, as explained in review but from user perspective both will fail (but logs will be more accurate). Also relocate the smaller scope closer to test, for readability. Relate-to: #774 (comment) Co-authored-by: Yann Dirson <yann.dirson@vates.tech> Signed-off-by: Philippe Coval <philippe.coval@vates.tech>
rzr
force-pushed
the
phcoval/review/master
branch
from
2334a23 to
ecd5758
Compare
rzr
added a commit
that referenced
this pull request
Nov 27, 2025
Which is semantically different, as explained in review but from user perspective both will fail (but logs will be more accurate). Also relocate the smaller scope closer to test, for readability. Relate-to: #774 (comment) Co-authored-by: Yann Dirson <yann.dirson@vates.tech> Signed-off-by: Philippe Coval <philippe.coval@vates.tech>
rzr
force-pushed
the
phcoval/review/master
branch
from
ecd5758 to
95d6f3f
Compare
ydirson
requested changes
Nov 27, 2025
ydirson
reviewed
Nov 27, 2025
Contributor
ydirson
left a comment
ydirson
left a comment
There was a problem hiding this comment.
I'm not sure it is useful to keep separate commits here
Contributor
Author
sure I can squash them all , btw i have other commits that pylint the source, can they be part of this PR ? or later one |
Contributor
Changing what pylint does or dealing with pylint reports is a different topic, let's keep them separate so we don't hold this PR with remarks targetting the other topic |
rzr
added a commit
that referenced
this pull request
Nov 27, 2025
make `koji_build` accept builds for v8.3 and from both `master` and `8.3` Preparation for switch `master` to be "next" aka v9 The motivation of change is part of a bigger plan, to prepare a smooth transition to enable bleeding edge development on master branch. Of course maintenance will remain in v8.x branches. Once the master branch needs to be stabilized then a new 9.0 branch can be open (this mean declared in PROTECTED_TARGETS, and also move the `master` branch from `8.3` target to `9.0` for a future cycle) Note that `8.3` git branches are not created yet in repos, it would make sense to open them soon or later, ideally when master branches need to receive feature from next release. Coincidentaly thoses 8.3 branches will be used for maintenance of the LTS release and then developers/RE might consider back-porting fixes from master to 8.3. Extra remarks, from squashed changes About "Handle undeclared branches differently than empty set..." This was not obvious to me that non protected targets are granted. If target is not declared, and then branches name not checked, just presence of commits, more logs provided to users. About "Pylint source, fix redefined-builtin W0622" Fix redefined-builtin mistake on hash (BTW I noticed similar mistakes elsewhere to be fixed in later PR that pylint the script) About "Log exception on missing remote branches", I removed the tuple containing the results because it is useless and not working when there is no result. now it raises an exception (which will be ignored and attempt to look for commit in other branches, a log may be printed to help trouble shoot.) Relate-to: #774 (comment) Co-authored-by: Yann Dirson <yann.dirson@vates.tech> Signed-off-by: Philippe Coval <philippe.coval@vates.tech>
rzr
force-pushed
the
phcoval/review/master
branch
from
95d6f3f to
99d5ee5
Compare
rzr
added a commit
that referenced
this pull request
Nov 27, 2025
make `koji_build` accept builds for v8.3 and from both `master` and `8.3` Preparation for switch `master` to be "next" aka v9 The motivation of change is part of a bigger plan, to prepare a smooth transition to enable bleeding edge development on master branch. Of course maintenance will remain in v8.x branches. Once the master branch needs to be stabilized then a new 9.0 branch can be open (this mean declared in PROTECTED_TARGETS, and also move the `master` branch from `8.3` target to `9.0` for a future cycle) Note that `8.3` git branches are not created yet in repos, it would make sense to open them soon or later, ideally when master branches need to receive feature from next release. Coincidentaly thoses 8.3 branches will be used for maintenance of the LTS release and then developers/RE might consider back-porting fixes from master to 8.3. Extra remarks, from squashed changes About "Handle undeclared branches differently than empty set..." This was not obvious to me that non protected targets are granted. If target is not declared, and then branches name not checked, just presence of commits, more logs provided to users. About "Pylint source, fix redefined-builtin W0622" Fix redefined-builtin mistake on hash (BTW I noticed similar mistakes elsewhere to be fixed in later PR that pylint the script) About "Log exception on missing remote branches", I removed the expression "()" containing the results because it is useless and not working when there is no result. now it raises an exception (which will be ignored and attempt to look for commit in other branches, a log may be printed to help trouble shoot.) Relate-to: #774 (comment) Co-authored-by: Yann Dirson <yann.dirson@vates.tech> Signed-off-by: Philippe Coval <philippe.coval@vates.tech>
rzr
force-pushed
the
phcoval/review/master
branch
from
99d5ee5 to
764783a
Compare
rzr
added a commit
that referenced
this pull request
Nov 28, 2025
Prepares the switch to a future "8.3" branch in each rpms repo by allowing it in addition to "master" for a transitional period. Fix redefined-builtin mistake on hash (BTW I noticed similar mistakes elsewhere to be fixed in later PR that pylint the script) More checks and logs provided to help user Relate-to: #774 (comment) Co-authored-by: Yann Dirson <yann.dirson@vates.tech> Signed-off-by: Philippe Coval <philippe.coval@vates.tech>
rzr
force-pushed
the
phcoval/review/master
branch
from
764783a to
7fdb7d0
Compare
rzr
added a commit
that referenced
this pull request
Nov 28, 2025
Prepares the switch to a future "8.3" branch in each rpms repo by allowing it in addition to "master" for a transitional period. Fix redefined-builtin mistake on hash (BTW I noticed similar mistakes elsewhere to be fixed in later PR that pylint the script) More checks and logs provided to help user Relate-to: #774 (comment) Co-authored-by: Yann Dirson <yann.dirson@vates.tech> Signed-off-by: Philippe Coval <philippe.coval@vates.tech>
rzr
force-pushed
the
phcoval/review/master
branch
from
7fdb7d0 to
b7376f8
Compare
Prepares the switch to a future "8.3" branch in each rpms repo by allowing it in addition to "master" for a transitional period. Fix redefined-builtin mistake on hash (BTW I noticed similar mistakes elsewhere to be fixed in later PR that pylint the script) More checks and logs provided to help user Relate-to: #774 (comment) Co-authored-by: Yann Dirson <yann.dirson@vates.tech> Signed-off-by: Philippe Coval <philippe.coval@vates.tech>
rzr
force-pushed
the
phcoval/review/master
branch
from
b7376f8 to
558290d
Compare
ydirson
approved these changes
Nov 28, 2025
stormi
approved these changes
Nov 28, 2025
Contributor
Author
|
Thank you for your time involved in reviews. Should I merge it now to push more linter changes I have for next review ? |
Member
|
Yes, you can merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make
koji_buildaccept builds for v8.3 and from bothmasterand8.3Preparation for switch
masterto be "next" aka v9To my understanding, the motivation of change is part of a bigger plan, to prepare a smooth transition to enable bleeding edge development on master branch. Of course maintenance will remain in v8.x branches.
Once the master branch needs to be stabilized then a new 9.0 branch can be open (this mean declared in PROTECTED_TARGETS, and also move the
masterbranch from8.3target to9.0for a future cycle)Meanwhile the development on master is still open and might become the base for the next cycle (TBD 9.1 or 10).
Note that
8.3git branches are not created yet in repos, it would make sense to open them soon or later, ideally when master branches need to receive feature from next release. Coincidentaly thoses 8.3 branches will be used for maintenance of the LTS release and then developers/RE might consider back-porting fixes from master to 8.3.What is unclear to me in the plan is when the new koji target/tag v9 will be defined, or if an
unstabletarget will be added before, probably this will have to be coordinated with CI.