Merge pull request #545 from xamarin/dominique-ScrollControlIntoViewWhenTabbing

ermau · web-flow · commit 1b4da57c501b · 2019-03-01T12:44:04.000-05:00
[Mac] When tabbing scroll focused control into view.
diff --git a/Xamarin.PropertyEditing.Mac/Controls/BooleanEditorControl.cs b/Xamarin.PropertyEditing.Mac/Controls/BooleanEditorControl.cs
@@ -14,14 +14,7 @@ internal class BooleanEditorControl
 		public BooleanEditorControl (IHostResourceProvider hostResource)
 			: base (hostResource)
 		{
-			BooleanEditor = new NSButton {
-				AllowsMixedState = true,
-				ControlSize = NSControlSize.Small,
-				Font = NSFont.FromFontName (DefaultFontName, DefaultFontSize),
-				Title = string.Empty,
-				TranslatesAutoresizingMaskIntoConstraints = false,
-			};
-			BooleanEditor.SetButtonType (NSButtonType.Switch);
+			BooleanEditor = new FocusableBooleanButton ();
 
 			// update the value on 'enter'
 			BooleanEditor.Activated += (sender, e) => {
diff --git a/Xamarin.PropertyEditing.Mac/Controls/BrushEditorControl.cs b/Xamarin.PropertyEditing.Mac/Controls/BrushEditorControl.cs
@@ -9,20 +9,8 @@
 
 namespace Xamarin.PropertyEditing.Mac
 {
-	internal class ColorPopUpButton : NSPopUpButton
+	internal class ColorPopUpButton : FocusablePopUpButton
 	{
-		public ColorPopUpButton () : base ()
-		{
-		}
-
-		public ColorPopUpButton (CGRect frame) : base (frame, true)
-		{
-		}
-
-		public ColorPopUpButton (IntPtr handle) : base (handle)
-		{
-		}
-
 		public NSPopover Popover { get; set; }
 
 		public override void MouseDown (NSEvent theEvent)
diff --git a/Xamarin.PropertyEditing.Mac/Controls/CombinablePropertyEditor.cs b/Xamarin.PropertyEditing.Mac/Controls/CombinablePropertyEditor.cs
@@ -77,19 +77,8 @@ protected override void OnViewModelChanged (PropertyViewModel oldModel)
 
 				NSButton checkbox;
 				if (i >= this.combinableList.Count) {
-					checkbox = new NSButton {
-						AllowsExpansionToolTips = true,
-						AllowsMixedState = true,
-						Cell = {
-							LineBreakMode = NSLineBreakMode.TruncatingTail,
-							UsesSingleLineMode = true,
-						},
-						ControlSize = NSControlSize.Small,
-						Font = NSFont.FromFontName (DefaultFontName, DefaultFontSize),
-						TranslatesAutoresizingMaskIntoConstraints = false,
-					};
-
-					checkbox.SetButtonType (NSButtonType.Switch);
+					checkbox = new FocusableBooleanButton ();
+
 					checkbox.Activated += SelectionChanged;
 
 					AddSubview (checkbox);
diff --git a/Xamarin.PropertyEditing.Mac/Controls/Custom/FocusableBooleanButton.cs b/Xamarin.PropertyEditing.Mac/Controls/Custom/FocusableBooleanButton.cs
@@ -0,0 +1,33 @@
+using System;
+using AppKit;
+
+namespace Xamarin.PropertyEditing.Mac
+{
+	internal class FocusableBooleanButton : NSButton
+	{
+		public override bool CanBecomeKeyView { get { return Enabled; } }
+
+		public FocusableBooleanButton ()
+		{
+			AllowsExpansionToolTips = true;
+			AllowsMixedState = true;
+			Cell.LineBreakMode = NSLineBreakMode.TruncatingTail;
+			Cell.UsesSingleLineMode = true;
+			ControlSize = NSControlSize.Small;
+			Font = NSFont.FromFontName (PropertyEditorControl.DefaultFontName, PropertyEditorControl.DefaultFontSize);
+			Title = string.Empty;
+			TranslatesAutoresizingMaskIntoConstraints = false;
+
+			SetButtonType (NSButtonType.Switch);
+		}
+
+		public override bool BecomeFirstResponder ()
+		{
+			var willBecomeFirstResponder = base.BecomeFirstResponder ();
+			if (willBecomeFirstResponder) {
+				ScrollRectToVisible (Bounds);
+			}
+			return willBecomeFirstResponder;
+		}
+	}
+}
diff --git a/Xamarin.PropertyEditing.Mac/Controls/Custom/FocusableButton.cs b/Xamarin.PropertyEditing.Mac/Controls/Custom/FocusableButton.cs
@@ -0,0 +1,31 @@
+using System;
+using AppKit;
+
+namespace Xamarin.PropertyEditing.Mac
+{
+	internal class FocusableButton : NSButton
+	{
+		public override bool CanBecomeKeyView { get { return Enabled; } }
+
+		public FocusableButton ()
+		{
+			AllowsExpansionToolTips = true;
+			AllowsMixedState = true;
+			Cell.LineBreakMode = NSLineBreakMode.TruncatingTail;
+			Cell.UsesSingleLineMode = true;
+			ControlSize = NSControlSize.Small;
+			Font = NSFont.FromFontName (PropertyEditorControl.DefaultFontName, PropertyEditorControl.DefaultFontSize);
+			Title = string.Empty;
+			TranslatesAutoresizingMaskIntoConstraints = false;
+		}
+
+		public override bool BecomeFirstResponder ()
+		{
+			var willBecomeFirstResponder = base.BecomeFirstResponder ();
+			if (willBecomeFirstResponder) {
+				ScrollRectToVisible (Bounds);
+			}
+			return willBecomeFirstResponder;
+		}
+	}
+}
diff --git a/Xamarin.PropertyEditing.Mac/Controls/Custom/FocusableComboBox.cs b/Xamarin.PropertyEditing.Mac/Controls/Custom/FocusableComboBox.cs
@@ -1,10 +1,19 @@
-﻿using Foundation;
+using Foundation;
 using AppKit;
 
 namespace Xamarin.PropertyEditing.Mac
 {
-	class FocusableComboBox : NSComboBox
+	internal class FocusableComboBox : NSComboBox
 	{
+		public override bool BecomeFirstResponder ()
+		{
+			var willBecomeFirstResponder = base.BecomeFirstResponder ();
+			if (willBecomeFirstResponder) {
+				ScrollRectToVisible (Bounds);
+			}
+			return willBecomeFirstResponder;
+		}
+
 		public override bool ShouldBeginEditing (NSText textObject)
 		{
 			textObject.Delegate = new FocusableComboBoxDelegate ();
diff --git a/Xamarin.PropertyEditing.Mac/Controls/Custom/FocusablePopupButton.cs b/Xamarin.PropertyEditing.Mac/Controls/Custom/FocusablePopupButton.cs
@@ -0,0 +1,20 @@
+using System;
+using AppKit;
+using CoreGraphics;
+
+namespace Xamarin.PropertyEditing.Mac
+{
+	internal class FocusablePopUpButton : NSPopUpButton
+	{
+		public override bool CanBecomeKeyView { get { return Enabled; } }
+
+		public override bool BecomeFirstResponder ()
+		{
+			var willBecomeFirstResponder = base.BecomeFirstResponder ();
+			if (willBecomeFirstResponder) {
+				ScrollRectToVisible (Bounds);
+			}
+			return willBecomeFirstResponder;
+		}
+	}
+}
diff --git a/Xamarin.PropertyEditing.Mac/Controls/Custom/PropertyTextField.cs b/Xamarin.PropertyEditing.Mac/Controls/Custom/PropertyTextField.cs
@@ -11,5 +11,14 @@ public PropertyTextField ()
 			Cell.LineBreakMode = NSLineBreakMode.TruncatingTail;
 			Cell.UsesSingleLineMode = true;
 		}
+
+		public override bool BecomeFirstResponder ()
+		{
+			var willBecomeFirstResponder = base.BecomeFirstResponder ();
+			if (willBecomeFirstResponder) {
+				ScrollRectToVisible (Bounds);
+			}
+			return willBecomeFirstResponder;
+		}
 	}
 }
diff --git a/Xamarin.PropertyEditing.Mac/Controls/NumericEditorControl.cs b/Xamarin.PropertyEditing.Mac/Controls/NumericEditorControl.cs
@@ -140,7 +140,7 @@ protected override void OnViewModelChanged (PropertyViewModel oldModel)
 
 			if (ViewModel.HasInputModes) {
 				if (this.inputModePopup == null) {
-					this.inputModePopup = new NSPopUpButton {
+					this.inputModePopup = new FocusablePopUpButton {
 						Menu = new NSMenu (),
 						TranslatesAutoresizingMaskIntoConstraints = false,
 					};
diff --git a/Xamarin.PropertyEditing.Mac/Controls/ObjectEditorControl.cs b/Xamarin.PropertyEditing.Mac/Controls/ObjectEditorControl.cs
@@ -19,9 +19,8 @@ public ObjectEditorControl (IHostResourceProvider hostResources)
 			};
 			AddSubview (this.typeLabel);
 
-			this.createObject = new NSButton {
+			this.createObject = new FocusableButton {
 				Title = Properties.Resources.New,
-				TranslatesAutoresizingMaskIntoConstraints = false,
 				BezelStyle = NSBezelStyle.Rounded
 			};
 			this.createObject.Activated += OnNewPressed;
diff --git a/Xamarin.PropertyEditing.Mac/Controls/PredefinedValuesEditor.cs b/Xamarin.PropertyEditing.Mac/Controls/PredefinedValuesEditor.cs
@@ -37,7 +37,7 @@ public PredefinedValuesEditor (IHostResourceProvider hostResources)
 				ViewModel.ValueName = this.comboBox.SelectedValue.ToString ();
 			};
 
-			this.popUpButton = new NSPopUpButton {
+			this.popUpButton = new FocusablePopUpButton {
 				AllowsExpansionToolTips = true,
 				Cell = {
 					LineBreakMode = NSLineBreakMode.TruncatingTail,
diff --git a/Xamarin.PropertyEditing.Mac/Controls/StringEditorControl.cs b/Xamarin.PropertyEditing.Mac/Controls/StringEditorControl.cs
@@ -19,7 +19,8 @@ internal class StringEditorControl
 		private NSLayoutConstraint stringEditorWidthConstraint;
 
 		public override NSView FirstKeyView => this.stringEditor;
-		public override NSView LastKeyView => this.stringEditor;
+		private NSView lastKeyView;
+		public override NSView LastKeyView => this.lastKeyView;
 
 		internal NSPopUpButton inputModePopup;
 		private IReadOnlyList<InputMode> viewModelInputModes;
@@ -41,6 +42,8 @@ public StringEditorControl (IHostResourceProvider hostResource)
 			};
 			AddSubview (this.stringEditor);
 
+			this.lastKeyView = this.stringEditor;
+
 			this.stringEditorWidthConstraint = NSLayoutConstraint.Create (this.stringEditor, NSLayoutAttribute.Width, NSLayoutRelation.Equal, this, NSLayoutAttribute.Width, 1f, -117f);
 
 			this.AddConstraints (new[] {
@@ -72,7 +75,7 @@ protected override void OnViewModelChanged (PropertyViewModel oldModel)
 
 			if (ViewModel.HasInputModes) {
 				if (this.inputModePopup == null) {
-					this.inputModePopup = new NSPopUpButton {
+					this.inputModePopup = new FocusablePopUpButton {
 						Menu = new NSMenu (),
 						TranslatesAutoresizingMaskIntoConstraints = false,
 					};
@@ -90,6 +93,8 @@ protected override void OnViewModelChanged (PropertyViewModel oldModel)
 						NSLayoutConstraint.Create (this.inputModePopup, NSLayoutAttribute.Width, NSLayoutRelation.Equal, 1f, 80f),
 						NSLayoutConstraint.Create (this.inputModePopup, NSLayoutAttribute.Height, NSLayoutRelation.Equal, 1f, DefaultControlHeight - 3 ),
 					});
+
+					this.lastKeyView = this.inputModePopup;
 				}
 
 				this.inputModePopup.Menu.RemoveAllItems ();
diff --git a/Xamarin.PropertyEditing.Mac/Controls/TypeEditorControl.cs b/Xamarin.PropertyEditing.Mac/Controls/TypeEditorControl.cs
@@ -19,9 +19,8 @@ public TypeEditorControl (IHostResourceProvider hostResources)
 			};
 			AddSubview (this.typeLabel);
 
-			this.selectType = new NSButton {
+			this.selectType = new FocusableButton {
 				Title = Properties.Resources.Select,
-				TranslatesAutoresizingMaskIntoConstraints = false,
 				BezelStyle = NSBezelStyle.Rounded
 			};
 			this.selectType.Activated += OnSelectPressed;
diff --git a/Xamarin.PropertyEditing.Mac/Xamarin.PropertyEditing.Mac.csproj b/Xamarin.PropertyEditing.Mac/Xamarin.PropertyEditing.Mac.csproj
@@ -151,6 +151,9 @@
     <Compile Include="Controls\Custom\PropertyTextField.cs" />
     <Compile Include="Controls\ControlExtensions.cs" />
     <Compile Include="Controls\TypeEditorControl.cs" />
+    <Compile Include="Controls\Custom\FocusablePopupButton.cs" />
+    <Compile Include="Controls\Custom\FocusableBooleanButton.cs" />
+    <Compile Include="Controls\Custom\FocusableButton.cs" />
   </ItemGroup>
   <ItemGroup>
     <Folder Include="Controls\" />

Original file line number	Diff line number	Diff line change
`@@ -11,5 +11,14 @@ public PropertyTextField ()`
`11`	`11`	`Cell.LineBreakMode = NSLineBreakMode.TruncatingTail;`
`12`	`12`	`Cell.UsesSingleLineMode = true;`
`13`	`13`	`}`
	`14`	`+`
	`15`	`+ public override bool BecomeFirstResponder ()`
	`16`	`+ {`
	`17`	`+ var willBecomeFirstResponder = base.BecomeFirstResponder ();`
	`18`	`+ if (willBecomeFirstResponder) {`
	`19`	`+ ScrollRectToVisible (Bounds);`
	`20`	`+ }`
	`21`	`+ return willBecomeFirstResponder;`
	`22`	`+ }`
`14`	`23`	`}`
`15`	`24`	`}`