Update main module

Author: felicio

src/extension.js

@@ -6,42 +6,48 @@ const path = require('path');
 
 const snippets = require('./snippets');
 
-const EXTENSION_IDENTIFIER = 'javascript-snippets';
-const SEMICOLONS = 'semicolons';
-const SNIPPETS_PATH = path.resolve(__dirname, '../snippets/snippets.json');
-
-exports.activate = function activate(context) {
-  let configuration = vscode.workspace.getConfiguration(EXTENSION_IDENTIFIER);
-  const withSemicolons = configuration.get(SEMICOLONS);
-  generateSnippets(SNIPPETS_PATH, snippets(withSemicolons));
-
-  const subscription = vscode.workspace.onDidChangeConfiguration(function() {
-    configuration = listener(configuration, EXTENSION_IDENTIFIER, SEMICOLONS);
+exports.activate = context => {
+  const extensionId = 'javascript-snippets';
+  const snippetsPath = path.resolve(__dirname, '../snippets/snippets.json');
+  const property = 'semicolons';
+  let configuration = vscode.workspace.getConfiguration(extensionId);
+  const hasSemicolons = configuration.get(property);
+
+  generateSnippets(snippetsPath, snippets(hasSemicolons));
+
+  const subscription = vscode.workspace.onDidChangeConfiguration(() => {
+    configuration = listener(
+      configuration,
+      extensionId,
+      snippetsPath,
+      property,
+    );
   });
+
   context.subscriptions.push(subscription);
 };
 
-/** Listens for change in user's settings for value of `semicolons` property. */
-function listener(previousConfiguration, identifier, semicolons) {
+/** Listens for change in `semicolons` property of user's settings. */
+function listener(previousConfiguration, identifier, path, property) {
   const configuration = vscode.workspace.getConfiguration(identifier);
-  const withSemicolons = configuration.get(semicolons);
+  const hasSemicolons = configuration.get(property);
 
-  if (withSemicolons !== previousConfiguration.get(semicolons)) {
-    generateSnippets(SNIPPETS_PATH, snippets(withSemicolons));
+  if (hasSemicolons !== previousConfiguration.get(property)) {
+    generateSnippets(path, snippets(hasSemicolons));
 
-    // FIXME: Prompt user for reloading window, since editor does not seem to pickup overwritten content.
+    // TODO: Ask user to reload window, in order for change to take effect
   }
 
   return configuration;
 }
 
 /** Generates set of JavaScript snippets in JSON format and writes them to file. */
-function generateSnippets(path, snippets) {
-  let stream = fs.createWriteStream(path);
+function generateSnippets(path, data) {
+  const stream = fs.createWriteStream(path);
 
-  stream.on('error', function(error) {
+  stream.on('error', error => {
     // TODO: Throw error
   });
-  stream.write(JSON.stringify(snippets));
+  stream.write(JSON.stringify(data));
   stream.end();
 }