Update extension.js

Author: felicio

package.json

@@ -28,7 +28,7 @@
         "javascript-snippets.semicolons": {
           "type": "boolean",
           "default": true,
-          "description": "Uses semicolons"
+          "description": "Uses semicolons. Restart is requierd."
         }
       }
     },

src/extension.js

@@ -6,39 +6,35 @@ const path = require('path');
 
 const snippets = require('./snippets');
 
+/** Lazily activates extension once on emitted event. */
 exports.activate = context => {
   const extensionId = 'javascript-snippets';
-  const snippetsPath = path.resolve(__dirname, '../snippets/snippets.json');
-  const property = 'semicolons';
   let configuration = vscode.workspace.getConfiguration(extensionId);
-  const hasSemicolons = configuration.get(property);
 
   try {
-    generateSnippets(snippetsPath, snippets(hasSemicolons));
+    const hasSemicolons = configuration.get('semicolons');
+
+    generateSnippets(snippets(hasSemicolons));
   } catch (error) {
     // TODO: Handle error
   }
 
   const subscription = vscode.workspace.onDidChangeConfiguration(() => {
-    configuration = listener(
-      configuration,
-      extensionId,
-      snippetsPath,
-      property,
-    );
+    const previousConfiguration = configuration;
+    configuration = listener(previousConfiguration, extensionId);
   });
 
   context.subscriptions.push(subscription);
 };
 
-/** Listens for change in `semicolons` property of user's settings. */
-function listener(previousConfiguration, identifier, path, property) {
-  const configuration = vscode.workspace.getConfiguration(identifier);
-  const hasSemicolons = configuration.get(property);
+/** Listens for changes in extension configuration and return effective user's settings. */
+function listener(previousConfiguration, extensionId) {
+  const configuration = vscode.workspace.getConfiguration(extensionId);
 
-  if (hasSemicolons !== previousConfiguration.get(property)) {
+  const hasSemicolons = configuration.get('semicolons');
+  if (hasSemicolons !== previousConfiguration.get('semicolons')) {
     try {
-      generateSnippets(path, snippets(hasSemicolons));
+      generateSnippets(snippets(hasSemicolons));
 
       // TODO: Ask user to reload window, in order for change to take effect
     } catch (error) {
@@ -50,6 +46,8 @@ function listener(previousConfiguration, identifier, path, property) {
 }
 
 /** Synchronously generates code snippets in JSON format and writes them to file. */
-function generateSnippets(file, snippets) {
-  fs.writeFileSync(file, JSON.stringify(snippets));
+function generateSnippets(snippets) {
+  const snippetsPath = path.resolve(__dirname, '../snippets/snippets.json');
+
+  fs.writeFileSync(snippetsPath, JSON.stringify(snippets));
 }