[HttpKernel] Move conflicting origin IPs handling to catch block

Author: nicolas-grekas

src/Symfony/Component/HttpKernel/HttpKernel.php

@@ -63,6 +63,9 @@ public function handle(Request $request, $type = HttpKernelInterface::MASTER_REQ
         try {
             return $this->handleRaw($request, $type);
         } catch (\Exception $e) {
+            if ($e instanceof ConflictingHeadersException) {
+                $e = new BadRequestHttpException('The request headers contain conflicting information regarding the origin of this request.', $e);
+            }
             if (false === $catch) {
                 $this->finishRequest($request, $type);
 
@@ -115,13 +118,6 @@ public function terminateWithException(\Exception $exception)
      */
     private function handleRaw(Request $request, $type = self::MASTER_REQUEST)
     {
-        if (self::MASTER_REQUEST === $type && $request::getTrustedProxies()) {
-            try {
-                $request->getClientIps();
-            } catch (ConflictingHeadersException $e) {
-                throw new BadRequestHttpException('The request headers contain conflicting information regarding the origin of this request.', $e);
-            }
-        }
         $this->requestStack->push($request);
 
         // request

src/Symfony/Component/HttpKernel/Tests/HttpKernelTest.php

@@ -276,26 +276,20 @@ public function testVerifyRequestStackPushPopDuringHandle()
      */
     public function testInconsistentClientIpsOnMasterRequests()
     {
-        $kernel = new HttpKernel(new EventDispatcher(), $this->getResolver());
-        $request = new Request();
-        $request->setTrustedProxies(array('1.1.1.1'));
-        $request->server->set('REMOTE_ADDR', '1.1.1.1');
-        $request->headers->set('FORWARDED', '2.2.2.2');
-        $request->headers->set('X_FORWARDED_FOR', '3.3.3.3');
+        $dispatcher = new EventDispatcher();
+        $dispatcher->addListener(KernelEvents::REQUEST, function ($event) {
+            $event->getRequest()->getClientIp();
+        });
 
-        $kernel->handle($request, $kernel::MASTER_REQUEST, false);
-    }
+        $kernel = new HttpKernel($dispatcher, $this->getResolver());
 
-    public function testInconsistentClientIpsOnSubRequests()
-    {
-        $kernel = new HttpKernel(new EventDispatcher(), $this->getResolver());
         $request = new Request();
         $request->setTrustedProxies(array('1.1.1.1'));
         $request->server->set('REMOTE_ADDR', '1.1.1.1');
         $request->headers->set('FORWARDED', '2.2.2.2');
         $request->headers->set('X_FORWARDED_FOR', '3.3.3.3');
 
-        $this->assertInstanceOf('Symfony\Component\HttpFoundation\Response', $kernel->handle($request, $kernel::SUB_REQUEST, false));
+        $kernel->handle($request, $kernel::MASTER_REQUEST, false);
     }
 
     protected function getResolver($controller = null)