Fix tests

Author: chfoidl

src/Plugin/rest/resource/AuthCodeResource.php

@@ -135,7 +135,7 @@ public function post(Request $request) {
         'error' => [
           'code' => 'simple_oauth_auth_code_invalid_payload',
           'message' => 'Invalid payload: Missing field "email".',
-        ]
+        ],
       ], Response::HTTP_BAD_REQUEST);
     }
 
@@ -144,7 +144,7 @@ public function post(Request $request) {
         'error' => [
           'code' => 'simple_oauth_auth_code_invalid_payload',
           'message' => 'Invalid payload: Missing field "operation".',
-        ]
+        ],
       ], Response::HTTP_BAD_REQUEST);
     }
 
@@ -158,7 +158,7 @@ public function post(Request $request) {
         'error' => [
           'code' => 'simple_oauth_auth_code_invalid_payload',
           'message' => 'Invalid payload',
-        ]
+        ],
       ], Response::HTTP_BAD_REQUEST);
     }
 

tests/src/Kernel/AuthCodeGeneratorTest.php

@@ -60,17 +60,16 @@ protected function setUp(): void {
    * Test auth code generation.
    */
   public function testGenerateAuthCode() {
+    $now = new \DateTimeImmutable();
     $authCode = $this->authCodeGenerator->generateAuthCode(self::CLIENT_ID, $this->user);
 
     $this->assertNotNull($authCode);
     $payload = $this->decryptAuthCode($authCode);
-    $now = time();
-
     // Get auth code expiration time from client.
     $expirationTime = (int) $this->client->get('one_time_login_auth_code_expiration')->value;
 
     // Create a timestamp that is $expirationTime seconds into the future.
-    $timestamp = $expirationTime + $now;
+    $timestamp = $expirationTime + $now->getTimestamp();
 
     $this->assertEquals(self::CLIENT_ID, $payload['client_id']);
     $this->assertEquals($this->user->id(), $payload['user_id']);

tests/src/Kernel/AuthCodeResourceTest.php

@@ -13,7 +13,6 @@
 use Drupal\user\Entity\User;
 use Stack\StackedHttpKernel;
 use Symfony\Component\HttpFoundation\Request;
-use Symfony\Component\HttpKernel\Kernel;
 
 /**
  * Test the auth code rest resource.
@@ -148,7 +147,7 @@ public function testResource() {
     $request = $this->createJsonRequest('POST', $this->url->toString(), $payload);
     $response = $this->httpKernel->handle($request);
 
-    $this->assertEquals(401, $response->getStatusCode());
+    $this->assertEquals(403, $response->getStatusCode());
   }
 
   /**