Merge pull request #68 from wsfe/feat/redundant-emittings-removal

feat: remove redundant event emittings

Author: ChuChencheng

package.json

@@ -1,6 +1,6 @@
 {
   "name": "@wsfe/vue-tree",
-  "version": "3.0.9",
+  "version": "3.0.10",
   "types": "./types",
   "description": "A vue tree component using virtual list.",
   "main": "./dist/v3/vue-tree.umd.js",
@@ -23,6 +23,7 @@
     "docs": "vue-tsc --noEmit && vite build -c examples/vite.config.ts",
     "preview": "vite preview",
     "test": "jest --watch",
+    "test:ci": "jest",
     "prettier": "prettier --write \"{src,examples,tests}/**/*.{ts,js,json,vue,tsx,less,scss,less,html}\" --fix",
     "postinstall": "node ./scripts/postinstall.cjs"
   },

src/components/Tree.vue

@@ -735,7 +735,6 @@ export default defineComponent({
 
     //#region Handle node events
     function handleNodeCheck(node: TreeNode): void {
-      ctx.emit('check', node)
       if (!props.cascade && props.enableLeafOnly && !node.isLeaf) return
       nonReactive.store.setChecked(
         node[props.keyField],
@@ -746,12 +745,10 @@ export default defineComponent({
       )
     }
     function handleNodeSelect(node: TreeNode): void {
-      ctx.emit('select', node)
       if (props.enableLeafOnly && !node.isLeaf) return
       nonReactive.store.setSelected(node[props.keyField], !node.selected)
     }
     function handleNodeExpand(node: TreeNode): void {
-      ctx.emit('expand', node)
       nonReactive.store.setExpand(node[props.keyField], !node.expand)
     }
     function handleNodeDrop(

tests/unit/tree.spec.ts

@@ -180,6 +180,29 @@ describe('树展示测试', () => {
       done()
     })
   })
+
+  it('点击展开节点', done => {
+    const data = genData().data
+    const wrapper = mount(VTree as any, {
+      propsData: {
+        data
+      }
+    })
+    const vm = wrapper.vm
+
+    vm.$nextTick(() => {
+      const treeNodes: any[] = wrapper.findAllComponents({
+        name: 'CTreeNode'
+      }) as any[]
+
+      treeNodes[0].find('.ctree-tree-node__expand').trigger('click')
+
+      vm.$nextTick(() => {
+        expect(wrapper.emitted('expand')).toHaveLength(1)
+        done()
+      })
+    })
+  })
 })
 
 describe('树单选测试', () => {
@@ -254,6 +277,7 @@ describe('树单选测试', () => {
         expect(
           treeNodes[2].find('.ctree-tree-node__title_selected').exists()
         ).toBe(true)
+        expect(wrapper.emitted('select')).toHaveLength(1)
         done()
       })
     })
@@ -383,7 +407,7 @@ describe('树多选测试', () => {
         expect(modelValue.length).toBe(expectedCheck.length)
         expect(modelValue).toEqual(expect.arrayContaining(expectedCheck))
         expect(expectedCheck.length).toBeGreaterThan(2)
-
+        expect(wrapper.emitted('check')).toHaveLength(1)
         done()
       })
     })