Merge pull request #259 from wpengine/ryanmeier/remove-grunt-phpcs

[PI-3451] Replace grunt-phpcs with phpcs composer command.

Author: rfmeier

.travis.yml

@@ -29,7 +29,9 @@ matrix:
     - php: 7.3
       env: WP_VERSION=5.2 WP_MULTISITE=1
     - php: 7.3
-      env: WP_VERSION=latest WP_MULTISITE=1
+      env:
+        env: WP_VERSION=latest WP_MULTISITE=1 PHPCS=1
+        - PHPCS=1
     - php: 7.3
       env: NPM_TESTS=1
   exclude:
@@ -87,6 +89,10 @@ before_script:
     fi
 script:
   - |
+    if [[ "$PHPCS" == "1" ]]; then
+      composer phpcs
+    fi
+
     if [[ "$NPM_TESTS" == "1" ]]; then
       npm test
     else

Gruntfile.js

@@ -20,23 +20,13 @@ module.exports = function(grunt) {
 		},
 		phplint: {
 			plugin: phpPaths
-		},
-		phpcs: {
-			plugin: {
-				src: phpPaths
-			},
-			options: {
-				bin: 'vendor/bin/phpcs',
-				standard: 'src/ruleset-wordpress.xml'
-			}
 		}
 	});
 
 	grunt.loadNpmTasks('grunt-wp-readme-to-markdown');
 	grunt.loadNpmTasks('grunt-phplint');
-	grunt.loadNpmTasks('grunt-phpcs');
 
-	grunt.registerTask('default', ['phplint', 'phpcs']);
+	grunt.registerTask('default', ['phplint']);
 
 	grunt.registerTask('readme', ['wp_readme_to_markdown']);
 };

composer.json

@@ -20,6 +20,8 @@
 		],
 		"post-install-cmd": [
 			"cd php52; composer install; cd .."
-		]
+		],
+		"phpcs": "phpcs --standard=src/ruleset-wordpress.xml wpengine-phpcompat.php load-files.php src/*.php",
+		"phpcs:fix": "phpcbf --standard=src/ruleset-wordpress.xml wpengine-phpcompat.php load-files.php src/*.php"
 	}
 }

package-lock.json

@@ -3,7 +3,6 @@
   "devDependencies": {
     "grunt": "^0.4.5",
     "grunt-cli": "^1.2.0",
-    "grunt-phpcs": "^0.4.0",
     "grunt-phplint": "0.0.8",
     "grunt-wp-readme-to-markdown": "^2.0.0",
     "lodash": "4.17.13",