Merge pull request #89 from davidfurey/issue-88-type-alias-2

Reorder visitType check to fix bug

Author: woutervh-

src/transform-inline/visitor-type-check.ts

@@ -1156,9 +1156,7 @@ function visitTemplateLiteralType(type: ts.TemplateLiteralType, visitorContext:
 }
 
 export function visitType(type: ts.Type, visitorContext: VisitorContext): string {
-    if (type.aliasTypeArguments && visitorContext.previousTypeReference !== type && (type as ts.TypeReference).target) {
-        return visitTypeAliasReference(type as ts.TypeReference, visitorContext);
-    } else if ((ts.TypeFlags.Any & type.flags) !== 0) {
+    if ((ts.TypeFlags.Any & type.flags) !== 0) {
         // Any
         return visitAny(visitorContext);
     } else if ((ts.TypeFlags.Unknown & type.flags) !== 0) {
@@ -1191,6 +1189,8 @@ export function visitType(type: ts.Type, visitorContext: VisitorContext): string
     } else if (tsutils.isTypeReference(type) && visitorContext.previousTypeReference !== type) {
         // Type references.
         return visitTypeReference(type, visitorContext);
+    } else if (type.aliasTypeArguments && visitorContext.previousTypeReference !== type && (type as ts.TypeReference).target) {
+        return visitTypeAliasReference(type as ts.TypeReference, visitorContext);
     } else if ((ts.TypeFlags.TypeParameter & type.flags) !== 0) {
         // Type parameter
         return visitTypeParameter(type, visitorContext);

test/issue-88.ts

@@ -0,0 +1,26 @@
+import * as assert from 'assert';
+import { is } from '../index';
+
+/* https://github.com/woutervh-/typescript-is/issues/88 */
+
+interface Z<T> {
+    field: T;
+}
+
+type Y<T> = Z<T>
+
+type X = Y<string>
+
+describe('is', () => {
+    describe('Parameterised type alias of a parameterised type alias of an interface', () => {
+        it('should return true for object with field type string', () => {
+            assert.deepStrictEqual(is<X>({ field: 'some-string' }), true);
+        });
+        it('should return false for object with field type number', () => {
+            assert.deepStrictEqual(is<X>({ field: 0 }), false);
+        });
+        it('should return false for object without field', () => {
+            assert.deepStrictEqual(is<X>({}), false);
+        });
+    });
+});