Use Rome language server for JavaScript

Rome is a linter and formatter. It is very young but it supports
TypeScript, CSS support is planned and it will be a compiler too.

Hopefully it will reduce the amount of tooling necessary in Workbench.

https://rome.tools/

Author: sonnyp

re.sonny.Workbench.Devel.json

@@ -35,7 +35,11 @@
     {
       "name": "libportal",
       "buildsystem": "meson",
-      "config-opts": ["-Ddocs=false", "-Dvapi=false", "-Dbackends=gtk4"],
+      "config-opts": [
+        "-Ddocs=false",
+        "-Dvapi=false",
+        "-Dbackends=gtk4"
+      ],
       "sources": [
         {
           "type": "archive",
@@ -62,7 +66,6 @@
         {
           "type": "git",
           "url": "https://github.com/vala-lang/vala-language-server/",
-          "branch": "master",
           "commit": "bf978c0cda97cff946f355477ec8da08b1cb4e5e"
         }
       ],
@@ -112,11 +115,39 @@
         }
       ]
     },
+    {
+      "name": "rome",
+      "buildsystem": "simple",
+      "build-commands": [
+        "chmod +x rome",
+        "cp rome /app/bin/rome"
+      ],
+      "sources": [
+        {
+          "type": "archive",
+          "only-arches": [
+            "aarch64"
+          ],
+          "url": "https://registry.npmjs.org/@rometools/cli-linux-arm64/-/cli-linux-arm64-10.0.1.tgz",
+          "sha512": "2658d9b27b9dd4a09f7b7e9536c561fcbad8740ce06ca6dcb024f37828d6f513a4332363f29990fe021417167e3f284c160a301c80c68a1a0d7f89bea60a7190"
+        },
+        {
+          "type": "archive",
+          "only-arches": [
+            "x86_64"
+          ],
+          "url": "https://registry.npmjs.org/@rometools/cli-linux-x64/-/cli-linux-x64-10.0.1.tgz",
+          "sha512": "8d722a77d883c9951ec64eb70917c05c3038ccd0d41e912b52609e8e319a6f77610edd4a038d1f0ea29bfa4c59a40858ded42858d48d432a3be74cd7e4d6b02f"
+        }
+      ]
+    },
     {
       "name": "Workbench",
       "buildsystem": "meson",
       "builddir": true,
-      "config-opts": ["-Dprofile=development"],
+      "config-opts": [
+        "-Dprofile=development"
+      ],
       "sources": [
         {
           "type": "dir",

re.sonny.Workbench.json

@@ -35,7 +35,11 @@
     {
       "name": "libportal",
       "buildsystem": "meson",
-      "config-opts": ["-Ddocs=false", "-Dvapi=false", "-Dbackends=gtk4"],
+      "config-opts": [
+        "-Ddocs=false",
+        "-Dvapi=false",
+        "-Dbackends=gtk4"
+      ],
       "sources": [
         {
           "type": "archive",
@@ -63,7 +67,6 @@
         {
           "type": "git",
           "url": "https://github.com/vala-lang/vala-language-server/",
-          "branch": "master",
           "commit": "bf978c0cda97cff946f355477ec8da08b1cb4e5e"
         }
       ],
@@ -113,11 +116,39 @@
         }
       ]
     },
+    {
+      "name": "rome",
+      "buildsystem": "simple",
+      "build-commands": [
+        "chmod +x rome",
+        "cp rome /app/bin/rome"
+      ],
+      "sources": [
+        {
+          "type": "archive",
+          "only-arches": [
+            "aarch64"
+          ],
+          "url": "https://registry.npmjs.org/@rometools/cli-linux-arm64/-/cli-linux-arm64-10.0.1.tgz",
+          "sha512": "2658d9b27b9dd4a09f7b7e9536c561fcbad8740ce06ca6dcb024f37828d6f513a4332363f29990fe021417167e3f284c160a301c80c68a1a0d7f89bea60a7190"
+        },
+        {
+          "type": "archive",
+          "only-arches": [
+            "x86_64"
+          ],
+          "url": "https://registry.npmjs.org/@rometools/cli-linux-x64/-/cli-linux-x64-10.0.1.tgz",
+          "sha512": "8d722a77d883c9951ec64eb70917c05c3038ccd0d41e912b52609e8e319a6f77610edd4a038d1f0ea29bfa4c59a40858ded42858d48d432a3be74cd7e4d6b02f"
+        }
+      ]
+    },
     {
       "name": "Workbench",
       "buildsystem": "meson",
       "builddir": true,
-      "config-opts": ["-Dprofile=default"],
+      "config-opts": [
+        "-Dprofile=default"
+      ],
       "sources": [
         {
           "type": "dir",

rome.json

@@ -1,13 +1,23 @@
 {
   "formatter": {
     "enabled": true,
-    "ignore": ["icon-development-kit-www", ".flatpak", "src/lib", "troll"],
+    "ignore": [
+      "icon-development-kit-www",
+      ".flatpak",
+      "src/lib",
+      "troll"
+    ],
     "indentStyle": "space",
     "indentSize": 2
   },
   "linter": {
     "enabled": true,
-    "ignore": ["icon-development-kit-www", ".flatpak", "src/lib", "troll"],
+    "ignore": [
+      "icon-development-kit-www",
+      ".flatpak",
+      "src/lib",
+      "troll"
+    ],
     "rules": {
       "recommended": true,
       "correctness": {

src/PanelCode.js

@@ -1,17 +1,10 @@
 import Gio from "gi://Gio";
-import GLib from "gi://GLib";
 import GObject from "gi://GObject";
 
-import LSPClient from "./lsp/LSPClient.js";
+import { settings } from "./util.js";
 
-import {
-  getLanguage,
-  settings,
-  prepareSourceView,
-  handleDiagnostics,
-} from "./util.js";
-import WorkbenchHoverProvider from "./WorkbenchHoverProvider.js";
-import { getPid } from "../troll/src/util.js";
+import { setup as setupVala } from "./langs/vala.js";
+import { setup as setupJavaScript } from "./langs/javascript.js";
 
 export default function PanelCode({ builder, previewer, data_dir }) {
   const panel_code = builder.get_object("panel_code");
@@ -49,6 +42,7 @@ export default function PanelCode({ builder, previewer, data_dir }) {
   };
 
   setupVala({ data_dir });
+  setupJavaScript({ data_dir });
 
   function switchLanguage() {
     panel.language = dropdown_code_lang.selected_item.string;
@@ -60,102 +54,3 @@ export default function PanelCode({ builder, previewer, data_dir }) {
 
   return panel;
 }
-
-function setupVala({ data_dir }) {
-  const buffer_vala = getLanguage("vala").document.buffer;
-  const state_file = getLanguage("vala").document.file;
-  const provider = new WorkbenchHoverProvider();
-
-  const api_file = Gio.File.new_for_path(
-    GLib.build_filenamev([pkg.pkgdatadir, "workbench-api.vala"]),
-  );
-
-  let document_version = 0;
-  prepareSourceView({
-    source_view: getLanguage("vala").document.source_view,
-    provider,
-  });
-
-  const vls = createVLSClient({
-    buffer: buffer_vala,
-    provider,
-  });
-
-  async function setupLSP() {
-    if (vls.proc) return;
-    vls.start();
-
-    api_file.copy(
-      Gio.File.new_for_path(data_dir).get_child("workbench.vala"),
-      Gio.FileCopyFlags.OVERWRITE,
-      null,
-      null,
-    );
-
-    // https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#initialize
-    await vls.request("initialize", {
-      processId: getPid(),
-      clientInfo: {
-        name: "re.sonny.Workbench",
-        version: pkg.name,
-      },
-      rootPath: data_dir,
-      rootUri: Gio.File.new_for_path(data_dir).get_uri(),
-    });
-
-    await vls.notify("textDocument/didOpen", {
-      textDocument: {
-        uri: state_file.get_uri(),
-        languageId: "vala",
-        version: ++document_version,
-        text: buffer_vala.text,
-      },
-    });
-  }
-  setupLSP().catch(logError);
-
-  function createVLSClient({ buffer, provider }) {
-    const vls = new LSPClient([
-      // "/usr/lib/sdk/vala/bin/vala-language-server",
-      "vala-language-server",
-    ]);
-    vls.connect("exit", () => {
-      console.debug("vls exit");
-    });
-    vls.connect("output", (_self, message) => {
-      console.debug(`vls OUT:\n${JSON.stringify(message)}`);
-    });
-    vls.connect("input", (_self, message) => {
-      console.debug(`vls IN:\n${JSON.stringify(message)}`);
-    });
-
-    vls.connect(
-      "notification::textDocument/publishDiagnostics",
-      (_self, { diagnostics, uri }) => {
-        if (!state_file.equal(Gio.File.new_for_uri(uri))) {
-          return;
-        }
-        handleDiagnostics({ language: "Vala", diagnostics, buffer, provider });
-      },
-    );
-
-    buffer.connect("modified-changed", () => {
-      if (!buffer.get_modified()) return;
-      updateVLS().catch(logError);
-    });
-
-    return vls;
-  }
-
-  async function updateVLS() {
-    await setupLSP();
-
-    await vls.notify("textDocument/didChange", {
-      textDocument: {
-        uri: state_file.get_uri(),
-        version: ++document_version,
-      },
-      contentChanges: [{ text: buffer_vala.text }],
-    });
-  }
-}