Do not swallow previewer crasher errors

See #669

Author: sonnyp

Makefile

@@ -65,3 +65,11 @@ clean:
 	rm -f src/Library/**/libworkbenchcode.so
 	rm -f src/Library/**/biome.json
 	rm -rf src/Library/**/__pycache__
+	rm re.sonny.Workbench.Devel.flatpak
+	rm re.sonny.Workbench.flatpak
+	rm -rf _build
+	rm -rf .flatpak
+	rm -rf .flatpak-builder
+	rm -rf flatpak
+	rm -rf flatpak-builder
+	rm -rf repo

src/Previewer/Previewer.js

@@ -192,7 +192,8 @@ export default function Previewer({
 
     if (settings.get_boolean("safe-mode")) {
       // console.time("detectCrash");
-      if (await detectCrash(text, target_id)) return;
+      const crashed = await detectCrash(text, target_id);
+      if (crashed) return;
       // console.timeEnd("detectCrash");
     }
 

src/Previewer/crasher.vala

@@ -1,15 +1,14 @@
 public void main (string[] args) {
-	  Adw.init ();
+    Adw.init ();
 
     var builder = new Gtk.Builder();
     var output = new Gtk.Window ();
 
-	  try {
-	    builder.add_from_string(args[1], -1);
+    try {
+      builder.add_from_string(args[1], -1);
       var object = builder.get_object(args[2]) as Gtk.Widget;
       output.set_child(object);
-
-    // We are only interested in crashes here
-    // Previewer.js will handle errors
-	  } catch {}
+    } catch (Error e) {
+      GLib.error(e.message);
+    }
 }

src/Previewer/utils.js

@@ -142,7 +142,9 @@ export async function detectCrash(str, object_id) {
   const flags = Gio.SubprocessFlags.NONE;
   const proc = Gio.Subprocess.new(["workbench-crasher", str, object_id], flags);
 
-  const success = await proc.wait_check_async(null).catch((_err) => false);
+  const success = await proc.wait_check_async(null).catch((_err) => {
+    return false;
+  });
   return !success;
 }
 

src/libworkbench/meson.build

@@ -105,7 +105,7 @@ libworkbench_gir = gnome.generate_gir(libworkbench,
 )
 
 # Vala API Bindings
-libworkbench_vapi = gnome.generate_vapi(libworkbench_api_name,
+gnome.generate_vapi(libworkbench_api_name,
        sources: libworkbench_gir[0],
       packages: ['gio-2.0', 'gtk4', 'gtksourceview-5'],
        install: true,

src/meson.build

@@ -38,7 +38,7 @@ subdir('Previewer')
 subdir('langs/python')
 
 gjspack = find_program('../troll/gjspack/bin/gjspack')
-gresource = custom_target('gjspack',
+custom_target('gjspack',
   input: ['main.js', '../po/POTFILES'],
   output: app_id + '.src.gresource',
   command: [