Enable frozen_strings_literal (#626)

Author: mokagio

.rubocop.yml

@@ -30,13 +30,6 @@ Style/EmptyMethod:
 Style/TrailingCommaInArrayLiteral:
   EnforcedStyleForMultiline: consistent_comma
 
-# Enabling the 'frozen_string_literal: true' comment is nice but should be done with extra care
-# because enabling it on code that accidentally mutates string literals will crash at runtime
-# (e.g. `name = 'Hello'` then later `name << ' world'` will crash if the comment is enabled)
-# So we might enable it at some point, be we will need very careful review that this doesn't break everything.
-Style/FrozenStringLiteralComment:
-  Enabled: false
-
 # Unicode is pretty standard by now, and we want to be able to use em-dash, ellipsis, and unicode characters
 # to provide nice Monodraw.app graphs and similar, without being limited only by ascii.
 Style/AsciiComments:
@@ -48,7 +41,7 @@ Style/AsciiComments:
 # which would be incorrect and not what we want
 Style/StringConcatenation:
   Enabled: false
-  
+
 # This rule was enforced after upgrading Rubocop from `1.22.1` to `1.50.2`. We are disabling this rule for the
 # time being so that we don't see any unexpected behavior when running Release Toolkit actions that could be
 # changed by this rule. See https://github.com/wordpress-mobile/release-toolkit/pull/464#pullrequestreview-1396569629

CHANGELOG.md

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 source('https://rubygems.org')
 
 gemspec

Gemfile

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'rake'
 require 'tmpdir'
 
@@ -30,7 +32,7 @@ task :docstats, [:path] do |_, args|
   sh('yard', 'stats', '--list-undoc', path)
 end
 
-GEM_NAME = 'fastlane-plugin-wpmreleasetoolkit'.freeze
+GEM_NAME = 'fastlane-plugin-wpmreleasetoolkit'
 VERSION_FILE = File.join('lib', 'fastlane', 'plugin', 'wpmreleasetoolkit', 'version.rb')
 
 desc 'Create a new version of the release-toolkit gem'

Rakefile

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 lib = File.expand_path('lib', __dir__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require 'fastlane/plugin/wpmreleasetoolkit/version'

fastlane-plugin-wpmreleasetoolkit.gemspec

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 lane :test do
   wpmreleasetoolkit
 end

fastlane/Fastfile

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'fastlane/plugin/wpmreleasetoolkit/version'
 
 module Fastlane

lib/fastlane/plugin/wpmreleasetoolkit.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'fastlane/action'
 require_relative '../../helper/android/android_localize_helper'
 

lib/fastlane/plugin/wpmreleasetoolkit/actions/android/an_localize_libs_action.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'fastlane/action'
 require_relative '../../helper/metadata/release_note_metadata_block'
 require_relative '../../helper/metadata/release_note_short_metadata_block'

lib/fastlane/plugin/wpmreleasetoolkit/actions/android/an_update_metadata_source_action.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'fastlane/action'
 require_relative '../../helper/android/android_localize_helper'