Skip to content

Ensure that the order is not marked as 'On Hold' when saving the card fails after a successful payment. #427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: trunk
Choose a base branch
from
Draft

Ensure that the order is not marked as 'On Hold' when saving the card fails after a successful payment. #427

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
86c4ab3
Skip marking the order as 'On Hold' when saving the card fails after …
iamdharmesh Dec 1, 2025
c24f324
Apply doc comment update suggestion.
iamdharmesh Dec 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions includes/Framework/PaymentGateway/Payment_Gateway.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2094,8 +2094,18 @@ protected function maybe_tokenize( $response, $order ) {
$order = $this->get_payment_tokens_handler()->create_token( $order, $response );
} catch ( \Exception $e ) {

// handle the case of a "tokenize-after-sale" request failing by marking the order as on-hold with an explanatory note
if ( ! $response->transaction_held() && ! ( $this->supports( self::FEATURE_CREDIT_CARD_AUTHORIZATION ) && $this->perform_credit_card_authorization( $order ) ) ) {
/*
* Handle the request failing by marking the order as on-hold with an explanatory note
*
* Exclude the tokenize_after_sale() case, to avoid marking the order as on-hold when tokenization is done after sale.
* This is for handling the edge case where Square successfully charged for the order, but failed to tokenize/save the same card.
* @see https://linear.app/a8c/issue/SQUARE-208/store-then-charge-cards
*/
if (
! $response->transaction_held() &&
! ( $this->supports( self::FEATURE_CREDIT_CARD_AUTHORIZATION ) && $this->perform_credit_card_authorization( $order ) ) &&
! $this->tokenize_after_sale()
) {

// transaction has already been successful, but we've encountered an issue with the post-tokenization, add an order note to that effect and continue on
$message = sprintf(
Expand Down
Loading