refactor, move oldvalue to inside onChange

we only trigger item load when onChange value changed to be .eligible, however, if eligibility was already .eligible when view appeared (like with mocked data, as is instant), onChange never fired which would make items to never load

Author: iamgabrielma

Modules/Sources/PointOfSale/Presentation/PointOfSaleDashboardView.swift

@@ -150,13 +150,13 @@ struct PointOfSaleDashboardView: View {
             }
         }
         .onChange(of: posModel.entryPointController.eligibilityState) { oldValue, newValue in
-            guard newValue == .eligible else { return }
-            loadItemsIfEligible()
+            guard case .eligible = newValue, oldValue != newValue else { return }
+            loadItemsWhenEligible()
         }
         .ignoresSafeArea(.keyboard)
         .onAppear {
             trackTimeForInitialLoadingState()
-            loadItemsIfEligible()
+            loadItemsWhenEligible()
         }
         .onChange(of: viewState) { oldValue, newValue in
             if newValue == .content && oldValue != newValue {
@@ -247,8 +247,7 @@ private extension PointOfSaleDashboardView {
         }
     }
 
-    func loadItemsIfEligible() {
-        guard posModel.entryPointController.eligibilityState == .eligible else { return }
+    func loadItemsWhenEligible() {
         Task { @MainActor in
             await posModel.purchasableItemsController.loadItems(base: .root)
             await posModel.couponsController.loadItems(base: .root)