Fix backwards compatibility: only set discount_type when explicitly provided

Author: layoutd

README.md

@@ -58,7 +58,7 @@ Generate coupons with a minimum discount amount.
 Generate coupons with a maximum discount amount.
 - `wp wc generate coupons <nr of coupons> --max=50`
 
-Generate coupons with a specific discount type. Options are `fixed_cart` or `percent`. If not specified, a random type will be chosen.
+Generate coupons with a specific discount type. Options are `fixed_cart` or `percent`. If not specified, defaults to WooCommerce default (fixed_cart).
 - `wp wc generate coupons <nr of coupons> --discount_type=percent --min=5 --max=25`
 
 ### Customers

includes/CLI.php

@@ -396,7 +396,7 @@ function () use ( $progress ) {
 		array(
 			'name'        => 'discount_type',
 			'type'        => 'assoc',
-			'description' => 'The type of discount for the coupon. If not specified, a random type will be chosen.',
+			'description' => 'The type of discount for the coupon. If not specified, defaults to WooCommerce default (fixed_cart).',
 			'optional'    => true,
 			'options'     => array( 'fixed_cart', 'percent' ),
 		),

includes/Generator/Coupon.php

@@ -80,11 +80,6 @@ public static function generate( $save = true, $assoc_args = array() ) {
 			);
 		}
 
-		// If no discount type specified, randomly choose one for backwards compatibility
-		if ( empty( $discount_type ) ) {
-			$discount_type = wp_rand( 0, 1 ) === 0 ? 'fixed_cart' : 'percent';
-		}
-
 		$code        = substr( self::$faker->promotionCode( 1 ), 0, -1 ); // Omit the random digit.
 		$amount      = self::$faker->numberBetween( $min, $max );
 		$coupon_code = sprintf(
@@ -93,12 +88,18 @@ public static function generate( $save = true, $assoc_args = array() ) {
 			$amount
 		);
 
+		$props = array(
+			'code'   => $coupon_code,
+			'amount' => $amount,
+		);
+
+		// Only set discount_type if explicitly provided
+		if ( ! empty( $discount_type ) ) {
+			$props['discount_type'] = $discount_type;
+		}
+
 		$coupon = new \WC_Coupon( $coupon_code );
-		$coupon->set_props( array(
-			'code'          => $coupon_code,
-			'amount'        => $amount,
-			'discount_type' => $discount_type,
-		) );
+		$coupon->set_props( $props );
 
 		if ( $save ) {
 			$data_store = WC_Data_Store::load( 'coupon' );