Skip to content

Commit 6242519

Browse files
committed
docs: improve docs
1 parent bab3827 commit 6242519

File tree

4 files changed

+162
-27
lines changed

4 files changed

+162
-27
lines changed

CONTRIBUTING.md

Lines changed: 23 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -6,26 +6,34 @@ Thank you for your interest in contributing! This repository welcomes contributi
66

77
### 1. Add New Problems
88

9-
Use an LLM assistant (Cursor, GitHub Copilot Chat, Amazon Q) with the rule files:
9+
For adding new LeetCode problems, please refer to the comprehensive guide:
1010

11-
- Include `.amazonq/rules/problem-creation.md` in your LLM context
12-
- Ask: "Create LeetCode problem [number] ([name])"
11+
📖 **[LLM-Assisted Problem Creation Guide](docs/llm-assisted-problem-creation.md)**
1312

14-
### 2. Enhance Test Cases
13+
This document provides detailed instructions for using LLM assistants to generate new problems with proper templates, test cases, and documentation.
1514

16-
- Include `.amazonq/rules/test-quality-assurance.md` in your LLM context
17-
- Ask: "Enhance test cases for [problem_name] problem"
15+
**Acceptance Criteria:**
1816

19-
### 3. Improve Helper Classes
17+
- All GitHub Actions CI checks must pass (includes linting, testing, security scanning, reproducibility verification, and minimum 10 test cases per problem)
18+
- Proper type hints and code formatting
19+
- Complete the solution (documentation is auto-generated)
2020

21-
- Add new data structure helpers in `leetcode_py/data_structures/`
22-
- Follow existing patterns with generic types and visualization support
21+
### 2. Other Contributions
2322

24-
### 4. Bug Fixes & Improvements
23+
All other contributions are welcome! This includes:
2524

26-
- Fix issues in existing problems
27-
- Improve documentation
28-
- Enhance CI/CD workflows
25+
- Bug fixes and improvements
26+
- Documentation enhancements
27+
- Helper class improvements
28+
- CI/CD workflow enhancements
29+
- Test case enhancements
30+
- New data structure visualizations
31+
32+
**For small changes:** Feel free to open a pull request directly.
33+
34+
**For larger changes:** Please open an issue for discussion first.
35+
36+
I'm also open to feedback and suggestions for improving the project!
2937

3038
## Development Setup
3139

@@ -36,20 +44,14 @@ poetry install
3644
make test
3745
```
3846

39-
## Code Standards
40-
41-
- Follow [PEP 8](https://peps.python.org/pep-0008/) Python style guide
42-
- Use modern type hints per [PEP 585](https://peps.python.org/pep-0585/)/[PEP 604](https://peps.python.org/pep-0604/): `list[str]`, `dict[str, int]`, `Type | None`
43-
- Automated linting enforced by CI (black, isort, ruff, mypy)
44-
- Minimum 12 test cases per problem
45-
4647
## Pull Request Process
4748

4849
1. Fork the repository
4950
2. Create a feature branch
5051
3. Make your changes
5152
4. Run `make lint` and `make test`
52-
5. Submit a pull request with clear description
53+
5. Ensure all GitHub Actions CI checks pass
54+
6. Submit a pull request with clear description
5355

5456
## Questions?
5557

README.md

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,22 +6,25 @@
66
[![codecov](https://codecov.io/gh/wisarootl/leetcode-py/graph/badge.svg?token=TI97VUIA4Z)](https://codecov.io/gh/wisarootl/leetcode-py)
77
[![tests](https://img.shields.io/github/actions/workflow/status/wisarootl/leetcode-py/ci-test.yml?branch=main&label=tests&logo=github)](https://github.com/wisarootl/zerv/actions/workflows/ci-test.yml)
88
[![release](https://img.shields.io/github/actions/workflow/status/wisarootl/leetcode-py/cd.yml?branch=main&label=release&logo=github)](https://github.com/wisarootl/zerv/actions/workflows/cd.yml)
9+
[![downloads](https://static.pepy.tech/personalized-badge/leetcode-py-sdk?period=total&units=international_system&left_color=grey&right_color=brightgreen&left_text=pypi%20downloads)](https://pepy.tech/projects/leetcode-py-sdk)
10+
[![python](https://img.shields.io/badge/python-3.10%20%7C%203.11%20%7C%203.12%20%7C%203.13-brightgreen?logo=python)](https://pypi.org/project/leetcode-py-sdk/)
911

1012
A Python package to generate professional LeetCode practice environments. Features automated problem generation from LeetCode URLs, beautiful data structure visualizations (TreeNode, ListNode, GraphNode), and comprehensive testing with 10+ test cases per problem. Built with professional development practices including CI/CD, type hints, and quality gates.
1113

1214
**What makes this different:**
1315

14-
- 🤖 **[LLM-Assisted Workflow](https://github.com/wisarootl/leetcode-py#llm-assisted-problem-creation)**: Generate new problems instantly with AI assistance
16+
- 🤖 **[LLM-Assisted Workflow](https://github.com/wisarootl/leetcode-py/blob/main/docs/llm-assisted-problem-creation.md)**: Generate new problems instantly with AI assistance
1517
- 🎨 **Visual Debugging**: Interactive tree/graph rendering with Graphviz and anytree
1618
- 🧪 **Production Testing**: Comprehensive test suites with edge cases and reproducibility verification
1719
- 🚀 **Modern Python**: PEP 585/604 type hints, Poetry, and professional tooling
1820
- 📊 **Quality Assurance**: 95%+ test coverage, security scanning, automated linting
21+
-**[Powerful CLI](https://github.com/wisarootl/leetcode-py/blob/main/docs/cli-usage.md)**: Generate problems anywhere with `lcpy` command
1922

2023
## 🎯 What's Included
2124

2225
**Current**: All 75 problems from [Grind 75](https://www.techinterviewhandbook.org/grind75/) - the most essential coding interview questions curated by the creator of Blind 75.
2326

24-
**Future**: Planned expansion to all free Grind problems for comprehensive interview preparation.
27+
**Future**: Planned expansion to all free Grind problems for comprehensive interview preparation. [Contributions welcome!](CONTRIBUTING.md)
2528

2629
## 🚀 Quick Start
2730

docs/cli-usage.md

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -156,10 +156,7 @@ problem_name/
156156
Available tags for bulk operations:
157157

158158
- `grind-75` - Essential 75 coding interview problems
159-
- `blind-75` - Original Blind 75 problems
160-
- `neetcode-150` - NeetCode 150 problems
161-
- `top-interview` - Top interview questions
162-
- `easy`, `medium`, `hard` - Difficulty-based tags
159+
- `grind` - Original Blind 75 problems
163160

164161
## Output Directory
165162

docs/improvement-checklist.md

Lines changed: 133 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,133 @@
1+
# Documentation Improvement Checklist
2+
3+
## High Priority Fixes
4+
5+
### README.md Critical Issues
6+
7+
- [ ] **Fix badge links**: Update tests and release badges from `wisarootl/zerv` to `wisarootl/leetcode-py`
8+
- [ ] **Python version consistency**: Change "Python 3.13+" to "Python 3.10+" to match badge
9+
- [ ] **Fix pip install command**: Update from `pip install leetcode-py` to `pip install leetcode-py-sdk`
10+
11+
### Navigation & Structure
12+
13+
- [ ] **Add Table of Contents**: Include TOC at top of README for better navigation
14+
- [ ] **Consolidate CLI sections**: Reduce redundancy between Quick Start, Usage Patterns, and CLI guide
15+
- [ ] **Reorganize sections**: Move Development Setup after CLI usage for better flow
16+
17+
## Content Enhancements
18+
19+
### README.md Improvements
20+
21+
- [ ] **Add "Getting Started in 5 Minutes"**: Absolute minimum steps for new users
22+
- [ ] **Performance metrics**: Add statistics like "Generate 75 problems in under 30 seconds"
23+
- [ ] **User personas**: Different paths for beginner vs advanced developers
24+
- [ ] **Comparison table**: Compare with other LeetCode practice tools
25+
- [ ] **More concrete examples**: Show before/after of problem generation
26+
27+
### CLI Usage Guide
28+
29+
- [ ] **Add troubleshooting section**: Common CLI errors and solutions
30+
- [ ] **Performance tips**: Best practices for bulk operations
31+
- [ ] **Combine multiple options**: Examples of complex CLI combinations
32+
- [ ] **Error handling examples**: Show specific error messages and fixes
33+
34+
### LLM-Assisted Problem Creation Guide
35+
36+
- [ ] **Prerequisites checklist**: Clear setup requirements at top
37+
- [ ] **Test case verification**: Section on verifying generated test correctness
38+
- [ ] **More prompt examples**: Expand good vs bad prompt examples
39+
- [ ] **Integration examples**: Show how it fits into development workflow
40+
41+
### CONTRIBUTING.md
42+
43+
- [ ] **Examples of contribution types**: Clarify "small changes" vs "larger changes"
44+
- [ ] **Link to issue templates**: Reference different contribution types
45+
- [ ] **Development workflow**: More detailed setup and testing instructions
46+
47+
## New Documentation
48+
49+
### Missing Documentation Files
50+
51+
- [ ] **API Reference** (`docs/api-reference.md`): Document helper classes with examples
52+
- TreeNode methods and usage
53+
- ListNode methods and usage
54+
- GraphNode methods and usage
55+
- DictTree methods and usage
56+
- [ ] **Troubleshooting Guide** (`docs/troubleshooting.md`): Common issues and solutions
57+
- [ ] **FAQ** (`docs/faq.md`): Frequently asked questions
58+
- [ ] **Performance Guide** (`docs/performance.md`): Optimization tips and benchmarks
59+
60+
### Enhanced Examples
61+
62+
- [ ] **Data structure examples**: Concrete usage of TreeNode, ListNode, etc.
63+
- [ ] **Integration examples**: How to use with existing projects
64+
- [ ] **Advanced usage**: Complex scenarios and edge cases
65+
66+
## Visual & Media
67+
68+
### Image Consistency
69+
70+
- [ ] **Standardize screenshots**: Ensure consistent IDE theme across all images
71+
- [ ] **Update outdated images**: Verify all screenshots reflect current UI
72+
- [ ] **Add missing visuals**: More examples of CLI output and generated files
73+
74+
### Links & References
75+
76+
- [ ] **Verify all links**: Check internal and external links work
77+
- [ ] **Add more references**: Link to LeetCode, Grind 75, related tools
78+
- [ ] **Fix image accessibility**: Ensure all images load correctly
79+
80+
## Technical Improvements
81+
82+
### SEO & Discoverability
83+
84+
- [ ] **Improve meta descriptions**: Better GitHub search results
85+
- [ ] **Add keywords**: More searchable terms in descriptions
86+
- [ ] **Tag optimization**: Better categorization and tagging
87+
88+
### Code Quality
89+
90+
- [ ] **Code example validation**: Ensure all code snippets work
91+
- [ ] **Import statement examples**: Show correct import patterns
92+
- [ ] **Error handling**: Better error message examples
93+
94+
## Organization & Maintenance
95+
96+
### File Structure
97+
98+
- [ ] **Organize docs folder**: Better categorization of documentation
99+
- [ ] **Cross-references**: Better linking between related docs
100+
- [ ] **Version consistency**: Ensure all docs reflect current version
101+
102+
### Content Maintenance
103+
104+
- [ ] **Regular review schedule**: Plan for keeping docs updated
105+
- [ ] **User feedback integration**: Process for incorporating user suggestions
106+
- [ ] **Automated checks**: Validate links and code examples in CI
107+
108+
## Implementation Priority
109+
110+
### Phase 1 (Immediate)
111+
112+
1. Fix badge links
113+
2. Update Python version consistency
114+
3. Fix pip install command
115+
4. Add Table of Contents
116+
117+
### Phase 2 (Short-term)
118+
119+
1. Create API reference
120+
2. Add troubleshooting guide
121+
3. Enhance CLI documentation
122+
4. Improve visual consistency
123+
124+
### Phase 3 (Long-term)
125+
126+
1. Create comprehensive FAQ
127+
2. Add performance guide
128+
3. Develop user persona paths
129+
4. Build comparison resources
130+
131+
---
132+
133+
**Note**: This checklist should be reviewed and updated regularly as the project evolves and user feedback is received.

0 commit comments

Comments
 (0)