Merge rust-bitcoin/rust-secp256k1#802: musig: Take references to pub nonce and part sig in partial_verify

6c8b1b81c2c52ca4e6c66dd0402a66fd923c439f run cargo fmt (Andrew Poelstra)
cd6ecb11760e8219119da5b0be3f655bac9e6f1e musig: Take references to pub nonce and part sig in partial_verify (Steven Roose)

Pull request description:

  We've been building on sanket's old branch for quite a while and I noticed the unnecessary taking by value there. These types are quite big (132 bytes for the pub nonce), so since they're just ref'd internally as well, it makes sense to do this.

  I assume the musig API is still not released yet, so this can be changed without breaking?

ACKs for top commit:
  apoelstra:
    On 6c8b1b81c2c52ca4e6c66dd0402a66fd923c439f successfully ran local tests; would ACK but I am the last pusher and Github will not let me

Tree-SHA512: d3af93f20fce3a8863b3681a942d3186ca59523d7e0e90464bf24c563185e8ec14d8a129c797336fe9d8b5ad6166313fb8932d397f7aeee0526819be9ce128f0

Author: william2332-limf

examples/musig.rs

@@ -84,11 +84,11 @@ fn main() {
     let partial_sign2 = session.partial_sign(&secp, sec_nonce2, &keypair2, &musig_key_agg_cache);
 
     let is_partial_signature_valid =
-        session.partial_verify(&secp, &musig_key_agg_cache, partial_sign1, pub_nonce1, pubkey1);
+        session.partial_verify(&secp, &musig_key_agg_cache, &partial_sign1, &pub_nonce1, pubkey1);
     assert!(is_partial_signature_valid);
 
     let is_partial_signature_valid =
-        session.partial_verify(&secp, &musig_key_agg_cache, partial_sign2, pub_nonce2, pubkey2);
+        session.partial_verify(&secp, &musig_key_agg_cache, &partial_sign2, &pub_nonce2, pubkey2);
     assert!(is_partial_signature_valid);
 
     let partial_sigs = [partial_sign1, partial_sign2];

src/musig.rs

@@ -1226,8 +1226,8 @@ impl Session {
     /// assert!(session.partial_verify(
     ///     &secp,
     ///     &key_agg_cache,
-    ///     partial_sig1,
-    ///     pub_nonce1,
+    ///     &partial_sig1,
+    ///     &pub_nonce1,
     ///     pub_key1,
     /// ));
     /// # }
@@ -1236,8 +1236,8 @@ impl Session {
         &self,
         secp: &Secp256k1<C>,
         key_agg_cache: &KeyAggCache,
-        partial_sig: PartialSignature,
-        pub_nonce: PublicNonce,
+        partial_sig: &PartialSignature,
+        pub_nonce: &PublicNonce,
         pub_key: PublicKey,
     ) -> bool {
         let cx = secp.ctx().as_ptr();
@@ -1591,12 +1591,42 @@ mod tests {
         let partial_sign2 = session.partial_sign(&secp, sec_nonce2, &keypair2, &key_agg_cache);
 
         // Test partial signature verification
-        assert!(session.partial_verify(&secp, &key_agg_cache, partial_sign1, pub_nonce1, pubkey1));
-        assert!(session.partial_verify(&secp, &key_agg_cache, partial_sign2, pub_nonce2, pubkey2));
+        assert!(session.partial_verify(
+            &secp,
+            &key_agg_cache,
+            &partial_sign1,
+            &pub_nonce1,
+            pubkey1
+        ));
+        assert!(session.partial_verify(
+            &secp,
+            &key_agg_cache,
+            &partial_sign2,
+            &pub_nonce2,
+            pubkey2
+        ));
         // Test that they are invalid if you switch keys
-        assert!(!session.partial_verify(&secp, &key_agg_cache, partial_sign2, pub_nonce2, pubkey1));
-        assert!(!session.partial_verify(&secp, &key_agg_cache, partial_sign2, pub_nonce1, pubkey2));
-        assert!(!session.partial_verify(&secp, &key_agg_cache, partial_sign2, pub_nonce1, pubkey1));
+        assert!(!session.partial_verify(
+            &secp,
+            &key_agg_cache,
+            &partial_sign2,
+            &pub_nonce2,
+            pubkey1
+        ));
+        assert!(!session.partial_verify(
+            &secp,
+            &key_agg_cache,
+            &partial_sign2,
+            &pub_nonce1,
+            pubkey2
+        ));
+        assert!(!session.partial_verify(
+            &secp,
+            &key_agg_cache,
+            &partial_sign2,
+            &pub_nonce1,
+            pubkey1
+        ));
 
         // Test PartialSignature serialization/deserialization
         let serialized_partial_sig = partial_sign1.serialize();