Skip to content

Commit 9f8e572

Browse files
authored
Correct canceling popovers step
Discovered while replacing the dontFireEvents variable with the more readable fireEvents.
1 parent eaceee9 commit 9f8e572

File tree

1 file changed

+18
-19
lines changed

1 file changed

+18
-19
lines changed

source

Lines changed: 18 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -1827,7 +1827,7 @@ a.setAttribute('href', 'https://example.com/'); // change the content attribute
18271827

18281828
<li><p>If <var>removedNode</var>'s <code data-x="attr-popover">popover</code> attribute is not in
18291829
the <span data-x="attr-popover-none-state">no popover state</span>, then run the <span>hide
1830-
popover algorithm</span> given <var>removedNode</var>, false, true, and false.</p></li>
1830+
popover algorithm</span> given <var>removedNode</var>, false, false, and false.</p></li>
18311831
</ol>
18321832

18331833
<p>A <dfn id="insert-an-element-into-a-document" data-x="node is inserted into a document"
@@ -59601,7 +59601,7 @@ interface <dfn interface>HTMLDialogElement</dfn> : <span>HTMLElement</span> {
5960159601

5960259602
<ol>
5960359603
<li><p>Run <span data-x="hide-all-popovers-until">hide all popovers until</span> given null,
59604-
false, and false.</p></li>
59604+
false, and true.</p></li>
5960559605

5960659606
<li><p>Let <var>control</var> be null.</p></li>
5960759607

@@ -81413,7 +81413,7 @@ dictionary <dfn dictionary>DragEventInit</dfn> : <span>MouseEventInit</span> {
8141381413

8141481414
<li><p>If <var>oldValue</var> and <var>value</var> are in different <span
8141581415
data-x="attr-popover">states</span>, then run the <span>hide popover algorithm</span> given
81416-
<var>element</var>, true, false, and false.</p></li>
81416+
<var>element</var>, true, true, and false.</p></li>
8141781417
</ol>
8141881418

8141981419
<dl class="domintro">
@@ -81505,7 +81505,7 @@ dictionary <dfn dictionary>DragEventInit</dfn> : <span>MouseEventInit</span> {
8150581505
ancestor</span> algorithm given <var>element</var>.</p></li>
8150681506

8150781507
<li><p>Run <span data-x="hide-all-popovers-until">hide all popovers until</span> given
81508-
<var>ancestor</var>, false, and false.</p></li>
81508+
<var>ancestor</var>, false, and true.</p></li>
8150981509

8151081510
<li>
8151181511
<p>If <var>originalType</var> is not equal to the value of <var>element</var>'s <code
@@ -81602,13 +81602,13 @@ dictionary <dfn dictionary>DragEventInit</dfn> : <span>MouseEventInit</span> {
8160281602
method steps are:</p>
8160381603

8160481604
<ol>
81605-
<li><p>Run the <span>hide popover algorithm</span> given <span>this</span>, true, false, and
81605+
<li><p>Run the <span>hide popover algorithm</span> given <span>this</span>, true, true, and
8160681606
true.</p></li>
8160781607
</ol>
8160881608

8160981609
<p>To <dfn data-x="hide popover algorithm">hide a popover</dfn> given an <span data-x="HTML
8161081610
elements">HTML element</span> <var>element</var>, a boolean <var>focusPreviousElement</var>, a
81611-
boolean <var>dontFireEvents</var>, and a boolean <var>throwExceptions</var>:</p>
81611+
boolean <var>fireEvents</var>, and a boolean <var>throwExceptions</var>:</p>
8161281612

8161381613
<ol>
8161481614
<li>
@@ -81631,8 +81631,7 @@ dictionary <dfn dictionary>DragEventInit</dfn> : <span>MouseEventInit</span> {
8163181631

8163281632
<ol>
8163381633
<li><p>Run <span data-x="hide-all-popovers-until">hide all popovers until</span> given
81634-
<var>element</var>, <var>focusPreviousElement</var>, and
81635-
<var>dontFireEvents</var>.</p></li>
81634+
<var>element</var>, <var>focusPreviousElement</var>, and <var>fireEvents</var>.</p></li>
8163681635

8163781636
<li>
8163881637
<p>If <var>element</var> is not in <var>document</var>'s <span>auto popover list</span>:</p>
@@ -81656,7 +81655,7 @@ dictionary <dfn dictionary>DragEventInit</dfn> : <span>MouseEventInit</span> {
8165681655
<li><p>Set <var>element</var>'s <span>popover invoker</span> to null.</p></li>
8165781656

8165881657
<li>
81659-
<p>If <var>dontFireEvents</var> is false:</p>
81658+
<p>If <var>fireEvents</var> is true:</p>
8166081659

8166181660
<ol>
8166281661
<li><p><span data-x="concept-event-fire">Fire an event</span> named <code
@@ -81689,7 +81688,7 @@ dictionary <dfn dictionary>DragEventInit</dfn> : <span>MouseEventInit</span> {
8168981688
<li><p>Set <var>element</var>'s <span>popover visibility state</span> to <span
8169081689
data-x="popover-hidden-state">hidden</span>.</p></li>
8169181690

81692-
<li><p>If <var>dontFireEvents</var> is false, then <span>queue a popover toggle event task</span>
81691+
<li><p>If <var>fireEvents</var> is true, then <span>queue a popover toggle event task</span>
8169381692
given <var>element</var>, "<code data-x="">open</code>", and "<code
8169481693
data-x="">closed</code>".</p></li>
8169581694

@@ -81715,7 +81714,7 @@ dictionary <dfn dictionary>DragEventInit</dfn> : <span>MouseEventInit</span> {
8171581714
<ol>
8171681715
<li><p>If <span>this</span>'s <span>popover visibility state</span> is <span
8171781716
data-x="popover-showing-state">showing</span>, and <var>force</var> is not present or false, then
81718-
run the <span>hide popover algorithm</span> given <span>this</span>, true, false, and
81717+
run the <span>hide popover algorithm</span> given <span>this</span>, true, true, and
8171981718
true.</p></li>
8172081719

8172181720
<li><p>Otherwise, if <var>force</var> is not present or true, then run <span>show popover</span>
@@ -81724,7 +81723,7 @@ dictionary <dfn dictionary>DragEventInit</dfn> : <span>MouseEventInit</span> {
8172481723

8172581724
<p>To <dfn data-x="hide-all-popovers-until">hide all popovers until</dfn>, given an <span
8172681725
data-x="HTML elements">HTML element</span> <var>endpoint</var>, a boolean
81727-
<var>focusPreviousElement</var>, and a boolean <var>dontFireEvents</var>:</p>
81726+
<var>focusPreviousElement</var>, and a boolean <var>fireEvents</var>:</p>
8172881727

8172981728
<ol>
8173081729
<li><p>Let <var>document</var> be <var>endpoint</var>'s <span>node document</span>.</p></li>
@@ -81741,7 +81740,7 @@ dictionary <dfn dictionary>DragEventInit</dfn> : <span>MouseEventInit</span> {
8174181740

8174281741
<ol>
8174381742
<li><p>Run the <span>hide popover algorithm</span> given <var>popover</var>,
81744-
<var>focusPreviousElement</var>, <var>dontFireEvents</var>, and false.</p></li>
81743+
<var>focusPreviousElement</var>, <var>fireEvents</var>, and false.</p></li>
8174581744

8174681745
<li><p>Set <var>popover</var> to <var>document</var>'s <span>topmost auto
8174781746
popover</span>.</p></li>
@@ -81779,8 +81778,8 @@ dictionary <dfn dictionary>DragEventInit</dfn> : <span>MouseEventInit</span> {
8177981778

8178081779
<ol>
8178181780
<li><p>Run the <span>hide popover algorithm</span> given <var>document</var>'s <span>auto
81782-
popover list</span>'s last element, <var>focusPreviousElement</var>,
81783-
<var>dontFireEvents</var>, and false.</p></li>
81781+
popover list</span>'s last element, <var>focusPreviousElement</var>, <var>fireEvents</var>, and
81782+
false.</p></li>
8178481783
</ol>
8178581784
</li>
8178681785
</ol>
@@ -82066,7 +82065,7 @@ dictionary <dfn dictionary>DragEventInit</dfn> : <span>MouseEventInit</span> {
8206682065
<li><p>If <var>popover</var>'s <span>popover visibility state</span> is <span
8206782066
data-x="popover-showing-state">showing</span> and the result of running <span>check popover
8206882067
validity</span> given <var>popover</var> and true is true, then run the <span>hide popover
82069-
algorithm</span> given <var>popover</var>, true, false, and false.</p></li>
82068+
algorithm</span> given <var>popover</var>, true, true, and false.</p></li>
8207082069

8207182070
<li>
8207282071
<p>Otherwise, if <var>popover</var>'s <span>popover visibility state</span> is <span
@@ -82139,11 +82138,11 @@ dictionary <dfn dictionary>DragEventInit</dfn> : <span>MouseEventInit</span> {
8213982138
a popover whose <code data-x="attr-popover">popover</code> attribute is in the <span
8214082139
data-x="attr-popover-auto-state">auto</span> state will close the popover.</p>
8214182140

82142-
<p id="canceling-popovers"><strong>Canceling popovers</strong>: When <code>Document</code> has a
82141+
<p id="canceling-popovers"><strong>Canceling popovers</strong>: when <code>Document</code> has a
8214382142
<span>topmost auto popover</span> showing, user agents may provide a user interface that, upon
8214482143
activation, <span data-x="queue an element task">queues an element task</span> on the <span>user
8214582144
interaction task source</span> given <span>topmost auto popover</span> to run the <span>hide
82146-
popover algorithm</span> given the <span>topmost auto popover</span>, true, and false.</p>
82145+
popover algorithm</span> given the <span>topmost auto popover</span>, true, true, and false.</p>
8214782146

8214882147
<p>To <dfn>light dismiss open popovers</dfn>, given an <code>Event</code> <var>event</var>:</p>
8214982148

@@ -82188,7 +82187,7 @@ dictionary <dfn dictionary>DragEventInit</dfn> : <span>MouseEventInit</span> {
8218882187
<li><p>Set <var>document</var>'s <span>popover pointerdown target</span> to null.</p></li>
8218982188

8219082189
<li><p>If <var>sameTarget</var> is true, then run <span data-x="hide-all-popovers-until">hide
82191-
all popovers until</span> given <var>ancestor</var>, false, and false.</p></li>
82190+
all popovers until</span> given <var>ancestor</var>, false, and true.</p></li>
8219282191
</ol>
8219382192
</li>
8219482193
</ol>

0 commit comments

Comments
 (0)