Skip to content

Override "Accept-Language" header if WebDriver BiDi emulated language is present. #1869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Nov 19, 2025
Merged

Override "Accept-Language" header if WebDriver BiDi emulated language is present. #1869

Changes from 7 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
61a4217
Override "Accept-Language" header if WebDriver BiDi emulated language…
lutien Oct 22, 2025
7d60108
Update fetch.bs
lutien Oct 23, 2025
268b10f
Update fetch.bs
lutien Oct 23, 2025
b53ec8c
Fix indentation.
lutien Oct 23, 2025
15e5eb4
Merge some conditions.
lutien Oct 23, 2025
dea205f
Update fetch.bs
lutien Nov 18, 2025
f861fd2
Encode "emulatedLanguage" before setting it as header value.
lutien Nov 18, 2025
feeb5d9
Put encoding of "emulatedLanguage" in a separate step.
lutien Nov 19, 2025
daf6f4b
wrapping
annevk Nov 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions fetch.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4659,6 +4659,20 @@ the response. [[!HTTP-CACHING]]
<var>request</var>'s <a for=request>header list</a>.
</ol>

<li>
<p>If <var>request</var>'s <a for=request>header list</a>
<a for="header list">does not contain</a> `<code>Accept-Language</code>` and <var>request</var>'s
<a for=request>client</a> is non-null:

<ol>
<li><p>Let <var>emulatedLanguage</var> be the <a>WebDriver BiDi emulated language</a> for
<var>request</var>'s <a for=request>client</a>.

<li><p>If <var>emulatedLanguage</var> is non-null, then <a for="header list">append</a>
(`<code>Accept-Language</code>, <var>emulatedLanguage</var>, <a>isomorphic encoded</a>)
Copy link
Member

@annevk annevk Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a ` missing. I also find this confusing as this could also be read as a three-tuple.

Copy link
Contributor Author

@lutien lutien Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, I've added "`". And moved encoding into a separate step to avoid having the three-tuple situation.

to <var>request</var>'s <a for=request>header list</a>.
</ol>

<li><p>If <var>request</var>'s <a for=request>header list</a>
<a for="header list">does not contain</a> `<code>Accept-Language</code>`, then user agents should
<a for="header list">append</a> (`<code>Accept-Language</code>, an appropriate
Expand Down