As discovered in #41 we accept invalid variants for the order argument

The argument then is silently dropped. This commit changes the
behaviour in such a way that now an error is generated for such
cases.

Author: weiznich

wundergraph/src/query_builder/selection/mod.rs

@@ -375,24 +375,24 @@ where
         Self::Table: 'static,
     {
         use juniper::LookAheadMethods;
-        if let Some(LookAheadValue::List(order)) =
-            select.argument("order").map(LookAheadArgument::value)
-        {
-            let order_stmts = <Self::Columns as BuildOrder<Self::Table, DB>>::build_order(
-                order,
-                |local_index| {
-                    Self::FieldList::map_table_field(local_index, |global| {
-                        Self::FIELD_NAMES[global]
-                    })
-                    .expect("Field is there")
-                },
-            )?;
-            for s in order_stmts {
-                query = query.then_order_by(s);
+        match select.argument("order").map(LookAheadArgument::value) {
+            Some(LookAheadValue::List(order)) => {
+                let order_stmts = <Self::Columns as BuildOrder<Self::Table, DB>>::build_order(
+                    order,
+                    |local_index| {
+                        Self::FieldList::map_table_field(local_index, |global| {
+                            Self::FIELD_NAMES[global]
+                        })
+                        .expect("Field is there")
+                    },
+                )?;
+                for s in order_stmts {
+                    query = query.then_order_by(s);
+                }
+                Ok(query)
             }
-            Ok(query)
-        } else {
-            Ok(query)
+            Some(_) => Err(WundergraphError::CouldNotBuildFilterArgument),
+            None => Ok(query),
         }
     }
 

wundergraph/tests/order.rs

@@ -86,3 +86,43 @@ fn order_desc() {
 ]"###
     );
 }
+
+#[test]
+fn invalid_order() {
+    let (schema, pool) = get_example_schema();
+    let ctx = MyContext::new(pool.get().unwrap());
+
+    let res = execute_query(
+        &schema,
+        &ctx,
+        "
+{
+    Heros(order: {column: heroName, direction: DESC}) {
+        heroName
+    }
+}
+",
+    );
+    assert!(res.is_ok());
+    assert_json_snapshot!(
+        res.as_json(), @r###"
+    [
+      null,
+      [
+        {
+          "locations": [
+            {
+              "column": 5,
+              "line": 3
+            }
+          ],
+          "message": "Could not build filter from arguments",
+          "path": [
+            "Heros"
+          ]
+        }
+      ]
+    ]
+    "###
+    );
+}