Expose connection logic to C++ FFI #20
Open
+125
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change exposes the basic functionality required to establish a dcSCTP connection from a C++ application. It adds FFI bindings for `connect`, `handle_input`, and `poll_event`. To model this in C++, `poll_event` now returns an `Event` struct, which can be used to distinguish between different socket events such as `OnConnected` and `SendPacket`. As the cxx FFI doesn't support rich types such as std::variant, having a fat struct as interface between Rust and C++ is simple and doesn't add much overhead. The C++ example in `dcsctp-cxx/examples/main.cpp` has been updated to demonstrate the explicit connection handshake between two sockets, mirroring the logic in the `establish_connection` Rust test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change exposes the basic functionality required to establish a dcSCTP connection from a C++ application. It adds FFI bindings for
connect,handle_input, andpoll_event.To model this in C++,
poll_eventnow returns anEventstruct, which can be used to distinguish between different socket events such asOnConnectedandSendPacket. As the cxx FFI doesn't support rich types such as std::variant, having a fat struct as interface between Rust and C++ is simple and doesn't add much overhead.The C++ example in
dcsctp-cxx/examples/main.cpphas been updated to demonstrate the explicit connection handshake between two sockets, mirroring the logic in theestablish_connectionRust test.