From 73b7e9eebfcb9f2cd862b6061cc431a1d13d539a Mon Sep 17 00:00:00 2001
From: Ankur Gupta <ankur.gupta6519@gmail.com>
Date: Sat, 23 May 2020 11:05:31 +0530
Subject: [PATCH 1/2] Adding setup.txt file which describes environment setup
 for development

---
 setup.txt | 15 +++++++++++++++
 1 file changed, 15 insertions(+)
 create mode 100644 setup.txt

diff --git a/setup.txt b/setup.txt
new file mode 100644
index 000000000..bb15af665
--- /dev/null
+++ b/setup.txt
@@ -0,0 +1,15 @@
+These are the steps to setup our personal environment for development
+1. Run our docker apprtc:1.0 with following CLI:
+    docker run --network host --rm -it -v <local_path_to_this_apprtc_repo>:/root/apprtc <apprtc-image-name>:1.0 bash
+2. On docker terminal run following commands:
+    a. cd /root/apprtc
+    b. npm install
+    c. pip install -r requirements.txt
+    d. grunt build
+3. With above steps you have apprtc code is built and ready to on docker server with following CLI:
+    a. cd /root/apprtc
+    b. dev_appserver.py ./out/app_engine
+4. You can open <local)path_to_this_apprtc_repo> in your preferred IDE to browse through javascript code in src/webapp/js folder.
+5. Get started with read of README in js directory.
+
+--update this setup.txt as required--

From e2f7d7691d1176834566ec516131b83296523d0a Mon Sep 17 00:00:00 2001
From: Ankur Gupta <ankur.gupta6519@gmail.com>
Date: Fri, 29 May 2020 22:59:42 +0530
Subject: [PATCH 2/2] Query regarding ice server failure

---
 src/web_app/js/call.js                 | 6 +++---
 src/web_app/js/peerconnectionclient.js | 5 +++--
 2 files changed, 6 insertions(+), 5 deletions(-)

diff --git a/src/web_app/js/call.js b/src/web_app/js/call.js
index 8c0e41457..428434d79 100644
--- a/src/web_app/js/call.js
+++ b/src/web_app/js/call.js
@@ -400,11 +400,11 @@ Call.prototype.maybeGetIceServers_ = function() {
               this.params_.peerConnectionConfig.iceServers =
               servers.concat(iceServers);
             }.bind(this)).catch(function(error) {
-          if (this.onstatusmessage) {
+          if (this.onstatusmessage) { //How this becomes true
             // Error retrieving ICE servers.
             var subject =
-                encodeURIComponent('AppRTC demo ICE servers not working');
-            this.onstatusmessage(
+                encodeURIComponent('AppRTC demo ICE servers not working'); //what is the utility of this variable
+            this.onstatusmessage(       // How this message gets activated
                 'No TURN server; unlikely that media will traverse networks. ' +
                 'If this persists please ' +
                 '<a href="mailto:discuss-webrtc@googlegroups.com?' +
diff --git a/src/web_app/js/peerconnectionclient.js b/src/web_app/js/peerconnectionclient.js
index 0c17ddb2e..98553c314 100644
--- a/src/web_app/js/peerconnectionclient.js
+++ b/src/web_app/js/peerconnectionclient.js
@@ -216,7 +216,8 @@ PeerConnectionClient.prototype.setLocalSdpAndNotify_ =
           sessionDescription.sdp,
           this.params_);
       this.pc_.setLocalDescription(sessionDescription)
-          .then(trace.bind(null, 'Set session description success.'))
+          .then(trace.bind(null, '' +
+              'Set session description success.'))
           .catch(this.onError_.bind(this, 'setLocalDescription'));
 
       if (this.onsignalingmessage) {
@@ -331,7 +332,7 @@ PeerConnectionClient.prototype.onSignalingStateChanged_ = function() {
   if (!this.pc_) {
     return;
   }
-  trace('Signaling state changed to: ' + this.pc_.signalingState);
+  trace(' Signaling state changed to: ' + this.pc_.signalingState);
 
   if (this.onsignalingstatechange) {
     this.onsignalingstatechange();