fix clippy and fmt

Author: yngrtc

dtls/src/extension/extension_server_name.rs

@@ -21,7 +21,7 @@ impl ExtensionServerName {
 
     pub fn size(&self) -> usize {
         //TODO: check how to do cryptobyte?
-        2 + 2 + 1 + 2 + self.server_name.as_bytes().len()
+        2 + 2 + 1 + 2 + self.server_name.len()
     }
 
     pub fn marshal<W: Write>(&self, writer: &mut W) -> Result<()> {

ice/src/agent/agent_internal.rs

@@ -984,7 +984,7 @@ impl AgentInternal {
     ) -> bool {
         self.find_remote_candidate(local.network_type(), remote)
             .await
-            .map_or(false, |remote_candidate| {
+            .is_some_and(|remote_candidate| {
                 remote_candidate.seen(false);
                 true
             })

ice/src/agent/agent_test.rs

@@ -1599,8 +1599,8 @@ async fn test_agent_credentials() -> Result<()> {
     let a = Agent::new(AgentConfig::default()).await?;
     {
         let ufrag_pwd = a.internal.ufrag_pwd.lock().await;
-        assert!(ufrag_pwd.local_ufrag.as_bytes().len() * 8 >= 24);
-        assert!(ufrag_pwd.local_pwd.as_bytes().len() * 8 >= 128);
+        assert!(ufrag_pwd.local_ufrag.len() * 8 >= 24);
+        assert!(ufrag_pwd.local_pwd.len() * 8 >= 128);
     }
     a.close().await?;
 

ice/src/agent/agent_vnet_test.rs

@@ -1002,7 +1002,7 @@ async fn test_write_use_valid_pair() -> Result<(), Error> {
     log::debug!("controlled_agent start_connectivity_checks done...");
 
     let test_message = "Test Message";
-    let mut read_buf = vec![0u8; test_message.as_bytes().len()];
+    let mut read_buf = vec![0u8; test_message.len()];
     controlled_agent_conn.recv(&mut read_buf).await?;
 
     assert_eq!(read_buf, test_message.as_bytes(), "should match");

mdns/src/message/resource/txt.rs

@@ -43,7 +43,7 @@ impl ResourceBody for TxtResource {
             let (t, new_off) = unpack_str(msg, off)?;
             off = new_off;
             // Check if we got too many bytes.
-            if length < n + t.as_bytes().len() + 1 {
+            if length < n + t.len() + 1 {
                 return Err(Error::ErrCalcLen);
             }
             n += t.len() + 1;

rtcp/src/compound_packet/mod.rs

@@ -66,10 +66,7 @@ impl Packet for CompoundPacket {
     }
 
     fn equal(&self, other: &(dyn Packet + Send + Sync)) -> bool {
-        other
-            .as_any()
-            .downcast_ref::<CompoundPacket>()
-            .map_or(false, |a| self == a)
+        other.as_any().downcast_ref::<CompoundPacket>() == Some(self)
     }
 
     fn cloned(&self) -> Box<dyn Packet + Send + Sync> {

rtcp/src/extended_report/dlrr.rs

@@ -77,10 +77,7 @@ impl Packet for DLRRReportBlock {
         self
     }
     fn equal(&self, other: &(dyn Packet + Send + Sync)) -> bool {
-        other
-            .as_any()
-            .downcast_ref::<DLRRReportBlock>()
-            .map_or(false, |a| self == a)
+        other.as_any().downcast_ref::<DLRRReportBlock>() == Some(self)
     }
     fn cloned(&self) -> Box<dyn Packet + Send + Sync> {
         Box::new(self.clone())

rtcp/src/extended_report/mod.rs

@@ -199,10 +199,7 @@ impl Packet for ExtendedReport {
     }
 
     fn equal(&self, other: &(dyn Packet + Send + Sync)) -> bool {
-        other
-            .as_any()
-            .downcast_ref::<ExtendedReport>()
-            .map_or(false, |a| self == a)
+        other.as_any().downcast_ref::<ExtendedReport>() == Some(self)
     }
 
     fn cloned(&self) -> Box<dyn Packet + Send + Sync> {

rtcp/src/extended_report/prt.rs

@@ -71,7 +71,7 @@ impl Packet for PacketReceiptTimesReportBlock {
         other
             .as_any()
             .downcast_ref::<PacketReceiptTimesReportBlock>()
-            .map_or(false, |a| self == a)
+            == Some(self)
     }
     fn cloned(&self) -> Box<dyn Packet + Send + Sync> {
         Box::new(self.clone())

rtcp/src/extended_report/rle.rs

@@ -163,10 +163,7 @@ impl Packet for RLEReportBlock {
         self
     }
     fn equal(&self, other: &(dyn Packet + Send + Sync)) -> bool {
-        other
-            .as_any()
-            .downcast_ref::<RLEReportBlock>()
-            .map_or(false, |a| self == a)
+        other.as_any().downcast_ref::<RLEReportBlock>() == Some(self)
     }
     fn cloned(&self) -> Box<dyn Packet + Send + Sync> {
         Box::new(self.clone())