Add MSRV policy and update MSRV to 1.60.0 (#337)

lookback-hugotunius · web-flow · commit de6e781ec437 · 2022-11-02T11:47:04.000+01:00
diff --git a/.github/workflows/cargo.yml b/.github/workflows/cargo.yml
@@ -20,7 +20,7 @@ jobs:
       matrix:
         os: ["ubuntu-latest", "macos-latest"]
         toolchain:
-          - 1.57.0 # min supported version (https://github.com/webrtc-rs/webrtc/#toolchain)
+          - 1.60.0 # min supported version (https://github.com/webrtc-rs/webrtc/#toolchain)
           - stable
     runs-on: ${{ matrix.os }}
     steps:
@@ -54,7 +54,7 @@ jobs:
     strategy:
       matrix:
         toolchain:
-          - 1.57.0 # min supported version (https://github.com/webrtc-rs/webrtc/#toolchain)
+          - 1.60.0 # min supported version (https://github.com/webrtc-rs/webrtc/#toolchain)
           - stable
     runs-on: windows-latest
     steps:
diff --git a/README.md b/README.md
@@ -58,7 +58,7 @@
 - [Overview](#overview)
 - [Features](#features)
 - [Building](#building)
-  - [Toolchain](#toolchain)
+  - [Toolchain(MSRV)](#toolchain)
   - [Monorepo Setup](#monorepo-setup)
   - [Testing with Local Dependencies](#testing-with-local-dependencies)
 - [Open Source License](#open-source-license) 
@@ -108,7 +108,11 @@ This project is still in active and early development stage, please refer to the
 
 ### Toolchain
 
-webrtc-rs currently requires Rust 1.57.0+ to build.
+**Minimum Supported Rust Version:** `1.60.0`
+
+Our minimum supported rust version(MSRV) policy is to support versions of the compiler released within the last six months. We don't eagerly bump the minimum version we support, instead the minimum will be bumped on a needed by needed basis, usually because downstream dependencies force us to.
+
+**Note:** Changes to the minimum supported version are not consider breaking from a [semver](https://semver.org/) perspective.
 
 ### Monorepo Setup
 
diff --git a/data/CHANGELOG.md b/data/CHANGELOG.md
@@ -2,6 +2,8 @@
 
 ## Unreleased
 
+* Increased minimum support rust version to `1.60.0`.
+
 ## 0.5.0
 
 * [#16 [PollDataChannel] reset shutdown_fut future after done](https://github.com/webrtc-rs/data/pull/16) by [@melekes](https://github.com/melekes).
diff --git a/data/Cargo.toml b/data/Cargo.toml
@@ -8,7 +8,7 @@ license = "MIT/Apache-2.0"
 documentation = "https://docs.rs/webrtc-data"
 homepage = "https://webrtc.rs"
 repository = "https://github.com/webrtc-rs/data"
-rust-version = "1.57.0"
+rust-version = "1.60.0"
 
 # See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html
 
diff --git a/dtls/CHANGELOG.md b/dtls/CHANGELOG.md
@@ -2,6 +2,8 @@
 
 ## Unreleased
 
+* Increased minimum support rust version to `1.60.0`.
+
 ## v0.6.0
 
 * [#254 [DTLS] Add NamedCurve::P384](https://github.com/webrtc-rs/webrtc/pull/254) contributed by [neonphog](https://github.com/neonphog)
diff --git a/dtls/Cargo.toml b/dtls/Cargo.toml
@@ -8,7 +8,7 @@ license = "MIT/Apache-2.0"
 documentation = "https://docs.rs/webrtc-dtls"
 homepage = "https://webrtc.rs"
 repository = "https://github.com/webrtc-rs/dtls"
-rust-version = "1.57.0"
+rust-version = "1.60.0"
 
 # See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html
 
diff --git a/examples/Cargo.toml b/examples/Cargo.toml
@@ -8,7 +8,7 @@ license = "MIT/Apache-2.0"
 documentation = "https://docs.rs/examples"
 homepage = "https://webrtc.rs"
 repository = "https://github.com/webrtc-rs/examples"
-rust-version = "1.57.0"
+rust-version = "1.60.0"
 
 # See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html
 
diff --git a/ice/CHANGELOG.md b/ice/CHANGELOG.md
@@ -2,6 +2,8 @@
 
 ## Unreleased
 
+* Increased minimum support rust version to `1.60.0`.
+
 ## v0.8.2
 
 * Add IP filter to ICE `AgentConfig` [#306](https://github.com/webrtc-rs/webrtc/pull/306) and [#318](https://github.com/webrtc-rs/webrtc/pull/318).
diff --git a/ice/Cargo.toml b/ice/Cargo.toml
@@ -8,7 +8,7 @@ license = "MIT/Apache-2.0"
 documentation = "https://docs.rs/webrtc-ice"
 homepage = "https://webrtc.rs"
 repository = "https://github.com/webrtc-rs/ice"
-rust-version = "1.57.0"
+rust-version = "1.60.0"
 
 # See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html
 
diff --git a/interceptor/CHANGELOG.md b/interceptor/CHANGELOG.md
@@ -5,6 +5,7 @@
 * Further extended stats interceptors to collect stats for `RemoteOutoundRTPStats` and improve `RemoteInboundRTPStats` collection. [#282](https://github.com/webrtc-rs/webrtc/pull/282) by [@k0nserv](https://github.com/k0nserv).
 * When generating periodic TWCC feedback packets we no longer burst several packets in a row to catch up, i.e., we now use `MissedTickBehavior::Skip` instead of the default `MissedTickBehavior::Burst` for the ticker in question. [#323](https://github.com/webrtc-rs/webrtc/pull/323) by [@k0nserv](https://github.com/k0nserv).
 * Don't generate empty TWCC packets that libWebRTC will ignore. [#324](https://github.com/webrtc-rs/webrtc/pull/324) by [@k0nserv](https://github.com/k0nserv).
+* Increased minimum support rust version to `1.60.0`.
  
 
 ## v0.8.0
diff --git a/interceptor/Cargo.toml b/interceptor/Cargo.toml
@@ -8,7 +8,7 @@ license = "MIT/Apache-2.0"
 documentation = "https://docs.rs/interceptor"
 homepage = "https://webrtc.rs"
 repository = "https://github.com/webrtc-rs/interceptor"
-rust-version = "1.57.0"
+rust-version = "1.60.0"
 
 [dependencies]
 util = { version = "0.6.0", path = "../util", package = "webrtc-util", default-features = false, features = ["marshal", "sync"] }
diff --git a/mdns/CHANGELOG.md b/mdns/CHANGELOG.md
@@ -2,6 +2,8 @@
 
 ## Unreleased
 
+* Increased minimum support rust version to `1.60.0`.
+
 ## v0.5.0
 
 * Increased min verison of `log` dependency to `0.4.16`. [#250 Fix log at ^0.4.16 to make tests compile](https://github.com/webrtc-rs/webrtc/pull/250) by [@k0nserv](https://github.com/k0nserv).
diff --git a/mdns/Cargo.toml b/mdns/Cargo.toml
@@ -8,7 +8,7 @@ license = "MIT/Apache-2.0"
 documentation = "https://docs.rs/webrtc-mdns"
 homepage = "https://webrtc.rs"
 repository = "https://github.com/webrtc-rs/mdns"
-rust-version = "1.57.0"
+rust-version = "1.60.0"
 
 # See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html
 
diff --git a/media/CHANGELOG.md b/media/CHANGELOG.md
@@ -2,10 +2,12 @@
 
 ## Unreleased
 
+* Improve handling of padding packets in `SampleBuiler`. Prior to this `SampleBuilder` would sometimes, incorrectly, drop packets that carry media when they appeared adjacent to runs of padding packets. Contributed by [@k0nserv](https://github.com/k0nserv) in [#309](https://github.com/webrtc-rs/webrtc/pull/309)
+* Increased minimum support rust version to `1.60.0`.
+
 ### Breaking
 
 * Introduced a new field in `Sample`, `prev_padding_packets`, that reflects the number of observed padding only packets while building the Sample. This can be use to differentiate inconsequential padding packets being dropped from those carrying media. Contributed by [@k0nserv](https://github.com/k0nserv) in [#303](https://github.com/webrtc-rs/webrtc/pull/303).
-* Improve handling of padding packets in `SampleBuiler`. Prior to this `SampleBuilder` would sometimes, incorrectly, drop packets that carry media when they appeared adjacent to runs of padding packets. Contributed by [@k0nserv](https://github.com/k0nserv) in [#309](https://github.com/webrtc-rs/webrtc/pull/309)
 
 ## v0.4.7
 
diff --git a/media/Cargo.toml b/media/Cargo.toml
@@ -8,7 +8,7 @@ license = "MIT/Apache-2.0"
 documentation = "https://docs.rs/webrtc-media"
 homepage = "https://webrtc.rs"
 repository = "https://github.com/webrtc-rs/media"
-rust-version = "1.57.0"
+rust-version = "1.60.0"
 
 # See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html
 
diff --git a/rtcp/CHANGELOG.md b/rtcp/CHANGELOG.md
@@ -2,6 +2,8 @@
 
 ## Unreleased
 
+* Increased minimum support rust version to `1.60.0`.
+
 ## v0.7.0
 
 * [#14 Prevent crash in RTCP NACK writing](https://github.com/webrtc-rs/rtcp/pull/14) by [@pthatcher](https://github.com/pthatcher).
diff --git a/rtcp/Cargo.toml b/rtcp/Cargo.toml
@@ -8,7 +8,7 @@ license = "MIT/Apache-2.0"
 documentation = "https://docs.rs/rtcp"
 homepage = "https://webrtc.rs"
 repository = "https://github.com/webrtc-rs/rtcp"
-rust-version = "1.57.0"
+rust-version = "1.60.0"
 
 [dependencies]
 util = { version = "0.6.0", path = "../util", package = "webrtc-util", default-features = false, features = ["marshal"] }
diff --git a/rtp/CHANGELOG.md b/rtp/CHANGELOG.md
@@ -2,6 +2,8 @@
 
 ## Unreleased
 
+* Increased minimum support rust version to `1.60.0`.
+
 ## v0.6.7
 
 * Bumped util dependecy to `0.6.0`.
diff --git a/rtp/Cargo.toml b/rtp/Cargo.toml
@@ -8,7 +8,7 @@ license = "MIT/Apache-2.0"
 documentation = "https://docs.rs/rtp"
 homepage = "https://webrtc.rs"
 repository = "https://github.com/webrtc-rs/rtp"
-rust-version = "1.57.0"
+rust-version = "1.60.0"
 
 [dependencies]
 util = { version = "0.6.0", path = "../util", package = "webrtc-util", default-features = false, features = ["marshal"] }
diff --git a/sctp/CHANGELOG.md b/sctp/CHANGELOG.md
@@ -2,6 +2,8 @@
 
 ## Unreleased
 
+* Increased minimum support rust version to `1.60.0`.
+
 ## v0.6.1
 
 * Increased min verison of `log` dependency to `0.4.16`. [#250 Fix log at ^0.4.16 to make tests compile](https://github.com/webrtc-rs/webrtc/pull/250) by [@k0nserv](https://github.com/k0nserv).
diff --git a/sctp/Cargo.toml b/sctp/Cargo.toml
@@ -8,7 +8,7 @@ license = "MIT/Apache-2.0"
 documentation = "https://docs.rs/webrtc-sctp"
 homepage = "https://webrtc.rs"
 repository = "https://github.com/webrtc-rs/sctp"
-rust-version = "1.57.0"
+rust-version = "1.60.0"
 
 # See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html
 
diff --git a/sdp/CHANGELOG.md b/sdp/CHANGELOG.md
@@ -2,6 +2,8 @@
 
 ## Unreleased
 
+* Increased minimum support rust version to `1.60.0`.
+
 ## v0.5.2
 
 * [#10 update deps + loosen some requirements](https://github.com/webrtc-rs/sdp/pull/10) by [@melekes](https://github.com/melekes).
diff --git a/sdp/Cargo.toml b/sdp/Cargo.toml
@@ -8,7 +8,7 @@ license = "MIT/Apache-2.0"
 documentation = "https://docs.rs/sdp"
 homepage = "https://webrtc.rs"
 repository = "https://github.com/webrtc-rs/sdp"
-rust-version = "1.57.0"
+rust-version = "1.60.0"
 
 [dependencies]
 url = "2.2"
diff --git a/srtp/CHANGELOG.md b/srtp/CHANGELOG.md
@@ -2,6 +2,9 @@
 
 ## Unreleased
 
+* Increased minimum support rust version to `1.60.0`.
+
+
 ## v0.9.0
 
 * [#8 update deps + loosen some requirements](https://github.com/webrtc-rs/srtp/pull/8) by [@melekes](https://github.com/melekes).
diff --git a/srtp/Cargo.toml b/srtp/Cargo.toml
@@ -8,7 +8,7 @@ license = "MIT/Apache-2.0"
 documentation = "https://docs.rs/webrtc-srtp"
 homepage = "https://webrtc.rs"
 repository = "https://github.com/webrtc-rs/srtp"
-rust-version = "1.57.0"
+rust-version = "1.60.0"
 
 [dependencies]
 util = { version = "0.6.0", path = "../util", package = "webrtc-util", default-features = false, features = [
diff --git a/stun/CHANGELOG.md b/stun/CHANGELOG.md
@@ -2,10 +2,14 @@
 
 ## Unreleased
 
+* Increased minimum support rust version to `1.60.0`.
+ 
+
 ## v0.4.3
 
 * [#9 update deps + loosen some requirements ](https://github.com/webrtc-rs/stun/pull/9) by [@melekes](https://github.com/melekes).
 
+
 ## Prior to 0.4.3
 
 Before 0.4.3 there was no changelog, previous changes are sometimes, but not always, available in the [GitHub Releases](https://github.com/webrtc-rs/stun/releases).
diff --git a/stun/Cargo.toml b/stun/Cargo.toml
@@ -8,7 +8,7 @@ license = "MIT/Apache-2.0"
 documentation = "https://docs.rs/stun"
 homepage = "https://webrtc.rs"
 repository = "https://github.com/webrtc-rs/stun"
-rust-version = "1.57.0"
+rust-version = "1.60.0"
 
 [features]
 default = []
diff --git a/turn/CHANGELOG.md b/turn/CHANGELOG.md
@@ -4,6 +4,7 @@
 
 * Added `delete_allocations_by_username` method on `Server`. This method provides possibility to manually delete allocation [#263](https://github.com/webrtc-rs/webrtc/pull/263) by [@logist322](https://github.com/logist322).
 * Added `get_allocations_info` method on `Server`. This method provides possibility to get information about allocations [#288](https://github.com/webrtc-rs/webrtc/pull/288) by [@logist322](https://github.com/logist322).
+* Increased minimum support rust version to `1.60.0`.
 
 
 ## v0.6.0
diff --git a/turn/Cargo.toml b/turn/Cargo.toml
@@ -8,7 +8,7 @@ license = "MIT/Apache-2.0"
 documentation = "https://docs.rs/turn"
 homepage = "https://webrtc.rs"
 repository = "https://github.com/webrtc-rs/turn"
-rust-version = "1.57.0"
+rust-version = "1.60.0"
 
 # See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html
 
diff --git a/util/CHANGELOG.md b/util/CHANGELOG.md
@@ -5,6 +5,7 @@
 ## v0.6.0
 
 * Increase min verison of `log` dependency to `0.4.16`. [#250 Fix log at ^0.4.16 to make tests compile](https://github.com/webrtc-rs/webrtc/pull/250) by [@k0nserv](https://github.com/k0nserv).
+* Increased minimum support rust version to `1.60.0`.
 
 ## Prior to 0.6.0
 
diff --git a/util/Cargo.toml b/util/Cargo.toml
@@ -8,7 +8,7 @@ license = "MIT/Apache-2.0"
 documentation = "https://docs.rs/webrtc-util"
 homepage = "https://webrtc.rs"
 repository = "https://github.com/webrtc-rs/util"
-rust-version = "1.57.0"
+rust-version = "1.60.0"
 
 # See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html
 
@@ -54,8 +54,7 @@ tokio-test = "0.4.0" # must match the min version of the `tokio` crate above
 env_logger = "0.9.0"
 chrono = "0.4.19"
 criterion = { version = "0.3.5", features = ["stable"]}
-async-global-executor = ">=2.0.0,<=2.2.0" # Transitive dependency due to Criterion, fixed to 2.2.0 because 2.3.0 requires Rust 1.59.0
-blocking = ">= 1.2.0" # Fix of async-global-executor usage which breaks on earlier versions. Can be removed after https://github.com/async-rs/async-global-executor/pull/12 is released
+async-global-executor = "2.3.1"
 
 [[bench]]
 name = "bench"
diff --git a/webrtc/CHANGELOG.md b/webrtc/CHANGELOG.md
@@ -10,6 +10,7 @@ directions that should not send. [#316](https://github.com/webrtc-rs/webrtc/pull
 * Add support for a mime type "audio/telephone-event" (rfc4733) [#322](https://github.com/webrtc-rs/webrtc/pull/322)
 * Fixed a panic that would sometimes happen when collecting stats. [#327](https://github.com/webrtc-rs/webrtc/pull/327) by [@k0nserv](https://github.com/k0nserv).
 * Added new extension marshaller/unmarshaller for VideoOrientation, and made marshallers serializable via serde [#331](https://github.com/webrtc-rs/webrtc/pull/331) [#332](https://github.com/webrtc-rs/webrtc/pull/332)
+* Updated minimum rust version to `1.60.0`
 
 
 #### Breaking changes
diff --git a/webrtc/Cargo.toml b/webrtc/Cargo.toml
@@ -9,7 +9,7 @@ documentation = "https://docs.rs/webrtc"
 homepage = "https://webrtc.rs"
 repository = "https://github.com/webrtc-rs/webrtc"
 readme = "../README.md"
-rust-version = "1.57.0"
+rust-version = "1.60.0"
 
 # See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html
 
@@ -51,7 +51,7 @@ hex = "0.4.3"
 # fixes "the trait bound `time::Month: From<u8>` is not satisfied"
 # https://github.com/est31/rcgen/pull/88
 # Version 0.3.14 requires Rust 1.59.0 which we don't currently support
-time = ">=0.3.1,<=0.3.13"
+time = "~0.3.1"
 
 [dev-dependencies]
 tokio-test = "0.4.0" # must match the min version of the `tokio` crate above
