fix: support serialization of RegExp (#102)

Author: qnighy

src/WorkerPool.js

@@ -7,6 +7,7 @@ import asyncMapSeries from 'neo-async/mapSeries';
 
 import readBuffer from './readBuffer';
 import WorkerError from './WorkerError';
+import { replacer, reviver } from './serializer';
 
 const workerPath = require.resolve('./worker');
 
@@ -107,7 +108,7 @@ class PoolWorker {
 
   writeJson(data) {
     const lengthBuffer = Buffer.alloc(4);
-    const messageBuffer = Buffer.from(JSON.stringify(data), 'utf-8');
+    const messageBuffer = Buffer.from(JSON.stringify(data, replacer), 'utf-8');
     lengthBuffer.writeInt32BE(messageBuffer.length, 0);
     this.writePipe.write(lengthBuffer);
     this.writePipe.write(messageBuffer);
@@ -141,7 +142,7 @@ class PoolWorker {
         }
         this.state = 'message read';
         const messageString = messageBuffer.toString('utf-8');
-        const message = JSON.parse(messageString);
+        const message = JSON.parse(messageString, reviver);
         this.state = 'process message';
         this.onWorkerMessage(message, (err) => {
           if (err) {

src/serializer.js

@@ -0,0 +1,21 @@
+export function replacer(_key, value) {
+  if (value instanceof RegExp) {
+    return {
+      __serialized_type: 'RegExp',
+      source: value.source,
+      flags: value.flags,
+    };
+  }
+  return value;
+}
+
+export function reviver(_key, value) {
+  if (typeof value === 'object' && value !== null) {
+    // eslint-disable-next-line no-underscore-dangle
+    if (value.__serialized_type === 'RegExp') {
+      return new RegExp(value.source, value.flags);
+    }
+  }
+
+  return value;
+}

src/worker.js

@@ -6,6 +6,7 @@ import loaderRunner from 'loader-runner';
 import asyncQueue from 'neo-async/queue';
 
 import readBuffer from './readBuffer';
+import { replacer, reviver } from './serializer';
 
 const writePipe = fs.createWriteStream(null, { fd: 3 });
 const readPipe = fs.createReadStream(null, { fd: 4 });
@@ -93,7 +94,7 @@ function writeJson(data) {
   });
 
   const lengthBuffer = Buffer.alloc(4);
-  const messageBuffer = Buffer.from(JSON.stringify(data), 'utf-8');
+  const messageBuffer = Buffer.from(JSON.stringify(data, replacer), 'utf-8');
   lengthBuffer.writeInt32BE(messageBuffer.length, 0);
 
   writePipeWrite(lengthBuffer);
@@ -319,7 +320,7 @@ function readNextMessage() {
         return;
       }
       const messageString = messageBuffer.toString('utf-8');
-      const message = JSON.parse(messageString);
+      const message = JSON.parse(messageString, reviver);
 
       onMessage(message);
       setImmediate(() => readNextMessage());

test/sass-loader-example/assets/color_palette.scss

@@ -0,0 +1 @@
+$white: #FFFFFF;

test/sass-loader-example/style.scss

@@ -1,4 +1,5 @@
 @import '_shared';
+@import 'color_palette';
 
 body {
   background: red;

test/sass-loader-example/webpack.config.js

@@ -16,6 +16,9 @@ module.exports = (env) => {
   };
   const sassLoaderOptions = {
     sourceMap: true,
+    sassOptions: {
+      includePaths: [path.resolve(__dirname, 'assets')],
+    },
   };
   if (+env.threads > 0) {
     threadLoader.warmup(workerPool, ['babel-loader', 'babel-preset-env']);

test/serializer.test.js

@@ -0,0 +1,31 @@
+const { replacer, reviver } = require('../src/serializer');
+
+test('round-trips plain objects', () => {
+  const json = JSON.stringify(
+    {
+      a: 1,
+      b: 'foo',
+      c: [null, false],
+    },
+    replacer
+  );
+  expect(JSON.parse(json, reviver)).toEqual({
+    a: 1,
+    b: 'foo',
+    c: [null, false],
+  });
+});
+
+test('round-trips regular expressions', () => {
+  const json = JSON.stringify(
+    {
+      r: /hoge/g,
+      s: /^(\w\s)+$/m,
+    },
+    replacer
+  );
+  expect(JSON.parse(json, reviver)).toEqual({
+    r: /hoge/g,
+    s: /^(\w\s)+$/m,
+  });
+});