ensure writable tbb_browser_dir

fix: Your Tor Browser profile cannot be loaded

Author: milahu

tbselenium/tbdriver.py

@@ -22,20 +22,6 @@
 DEFAULT_BANNED_PORTS = "9050,9051,9150,9151"
 GECKO_DRIVER_EXE_PATH = shutil.which("geckodriver")
 
-import os, stat
-def get_perm(path):
-    return stat.S_IMODE(os.lstat(path)[stat.ST_MODE])
-    #return os.stat(path).st_mode # ?
-
-# https://stackoverflow.com/a/6878204/10440128
-def make_writeable_recursive(path):
-    os.chmod(path, get_perm(path) | os.ST_WRITE)
-    for root, dirs, files in os.walk(path, topdown=False):
-        for dir in [os.path.join(root, d) for d in dirs]:
-            os.chmod(dir, get_perm(dir) | os.ST_WRITE)
-        for file in [os.path.join(root, f) for f in files]:
-            os.chmod(file, get_perm(file) | os.ST_WRITE)
-
 class TorBrowserDriver(FirefoxDriver):
     """
     Extend Firefox webdriver to automate Tor Browser.
@@ -241,16 +227,18 @@ def setup_tbb_paths(self, tbb_browser_dir, tbb_path, tbb_fx_binary_path,
         # if not isdir(tor_data_dir):
         #     raise TBDriverPathError("Invalid Tor data directory %s" % tor_data_dir)
 
-        # tor_data_dir must be writable
+        # tbb_browser_dir must be writable, but its contents can be read-only
         # fix: Your Tor Browser profile cannot be loaded. It may be missing or inaccessible.
-        if not os.access(tor_data_dir, os.W_OK):
-            temp_tor_data_dir = tempfile.mkdtemp(prefix="tbselenium-tor_data_dir-")
-            # print(f"not writable tor_data_dir {tor_data_dir} - using tempdir {temp_tor_data_dir}")
-            self.remove_on_exit.append(temp_tor_data_dir)
-            # copy the contents of tor_data_dir and make them writable
-            shutil.copytree(tor_data_dir, temp_tor_data_dir, dirs_exist_ok=True)
-            make_writeable_recursive(temp_tor_data_dir)
-            tor_data_dir = temp_tor_data_dir
+        if not os.access(tbb_browser_dir, os.W_OK):
+            temp_tbb_browser_dir = tempfile.mkdtemp(prefix="tbselenium-tbb_browser_dir-")
+            # print(f"not writable tbb_browser_dir {tbb_browser_dir} - using tempdir {temp_tbb_browser_dir}")
+            self.remove_on_exit.append(temp_tbb_browser_dir)
+            # symlink the contents of tbb_browser_dir
+            for name in os.listdir(tbb_browser_dir):
+                src = tbb_browser_dir + "/" + name
+                dst = temp_tbb_browser_dir + "/" + name
+                os.symlink(src, dst, target_is_directory=os.path.isdir(src))
+            tbb_browser_dir = temp_tbb_browser_dir
 
         #self.tbb_path = abspath(tbb_path)
         self.tbb_browser_dir = abspath(tbb_browser_dir)