Skip to content

Commit 77e4c6b

Browse files
authored
Fix error with axios and proxies (#897)
* Fix error with axios and proxies * Update dependabot with axios remove * Temporal consoles in test for debugging error * Remove debugging console in test
1 parent 6d56e17 commit 77e4c6b

File tree

4 files changed

+44
-154
lines changed

4 files changed

+44
-154
lines changed

.github/dependabot.yml

Lines changed: 30 additions & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -1,36 +1,32 @@
11
version: 2
22
updates:
3-
- package-ecosystem: npm
4-
directory: "/"
5-
schedule:
6-
interval: weekly
7-
time: "11:00"
8-
open-pull-requests-limit: 10
9-
versioning-strategy: increase-if-necessary
10-
ignore:
11-
- dependency-name: "got"
12-
update-types: ["version-update:semver-major"]
13-
- dependency-name: "mocha"
14-
update-types: ["version-update:semver-major"]
15-
- dependency-name: "axios"
16-
update-types: ["version-update:semver-major"]
17-
- dependency-name: "husky"
18-
update-types: ["version-update:semver-major"]
19-
- dependency-name: "release-it"
20-
update-types: ["version-update:semver-major"]
21-
- dependency-name: "commander"
22-
update-types: ["version-update:semver-major"]
23-
- dependency-name: "eslint-plugin-prettier"
24-
update-types: ["version-update:semver-major"]
25-
- dependency-name: "eslint"
26-
update-types: ["version-update:semver-major"]
27-
- dependency-name: "execa"
28-
update-types: ["version-update:semver-major"]
29-
- dependency-name: "find-process"
30-
update-types: ["version-update:semver-major"]
31-
- dependency-name: "fkill"
32-
update-types: ["version-update:semver-major"]
33-
- dependency-name: "prettier"
34-
update-types: ["version-update:semver-major"]
35-
36-
3+
- package-ecosystem: npm
4+
directory: "/"
5+
schedule:
6+
interval: weekly
7+
time: "11:00"
8+
open-pull-requests-limit: 10
9+
versioning-strategy: increase-if-necessary
10+
ignore:
11+
- dependency-name: "got"
12+
update-types: ["version-update:semver-major"]
13+
- dependency-name: "mocha"
14+
update-types: ["version-update:semver-major"]
15+
- dependency-name: "husky"
16+
update-types: ["version-update:semver-major"]
17+
- dependency-name: "release-it"
18+
update-types: ["version-update:semver-major"]
19+
- dependency-name: "commander"
20+
update-types: ["version-update:semver-major"]
21+
- dependency-name: "eslint-plugin-prettier"
22+
update-types: ["version-update:semver-major"]
23+
- dependency-name: "eslint"
24+
update-types: ["version-update:semver-major"]
25+
- dependency-name: "execa"
26+
update-types: ["version-update:semver-major"]
27+
- dependency-name: "find-process"
28+
update-types: ["version-update:semver-major"]
29+
- dependency-name: "fkill"
30+
update-types: ["version-update:semver-major"]
31+
- dependency-name: "prettier"
32+
update-types: ["version-update:semver-major"]

lib/compute-download-urls.js

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ const {
1010
getIeDriverArchitectureOld,
1111
getFirefoxDriverArchitectureOld,
1212
} = require('./platformDetection');
13-
const { default: axios } = require('axios');
1413

1514
const urls = {
1615
selenium: '%s/%s/selenium-server-standalone-%s.jar',
@@ -278,15 +277,15 @@ function resolveDownloadPath(platform, buildId) {
278277
}
279278

280279
async function getLastChromedriverVersionFromMajor(version) {
281-
const response = await axios({
280+
const response = await got({
282281
method: 'get',
283282
url: 'https://googlechromelabs.github.io/chrome-for-testing/known-good-versions-with-downloads.json',
284283
responseType: 'json',
285284
headers: {
286285
'Content-Type': 'application/json',
287286
},
288287
});
289-
const versionsWithMajor = response.data.versions.filter(
288+
const versionsWithMajor = response.body.versions.filter(
290289
(f) =>
291290
validateMajorVersionPrefix(f.version) === validateMajorVersionPrefix(version) && 'chromedriver' in f.downloads
292291
);
@@ -300,18 +299,18 @@ async function getLastChromedriverVersionFromMajor(version) {
300299
}
301300

302301
async function getLatestChromeVersion(possibleChanel) {
303-
const response = await axios({
302+
const response = await got({
304303
method: 'get',
305304
url: 'https://googlechromelabs.github.io/chrome-for-testing/last-known-good-versions.json',
306305
responseType: 'json',
307306
headers: {
308307
'Content-Type': 'application/json',
309308
},
310309
});
311-
const channel = Object.keys(response.data.channels).find((i) => i.toLowerCase() === possibleChanel.toLowerCase());
310+
const channel = Object.keys(response.body.channels).find((i) => i.toLowerCase() === possibleChanel.toLowerCase());
312311

313312
try {
314-
return response.data.channels[channel].version;
313+
return response.body.channels[channel].version;
315314
} catch (err) {
316315
console.log();
317316
throw new Error(`channel can't be - ${possibleChanel}, possible only Stable, Beta, Dev, Canary`);

package-lock.json

Lines changed: 9 additions & 113 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,6 @@
4242
}
4343
},
4444
"dependencies": {
45-
"axios": "^1.6.2",
4645
"commander": "^8.3.0",
4746
"cross-spawn": "^7.0.3",
4847
"debug": "^4.3.1",

0 commit comments

Comments
 (0)