Skip to content

Commit 91f564c

Browse files
author
George Griffiths
committed
fixes #47
1 parent e73d1cd commit 91f564c

File tree

3 files changed

+24
-3
lines changed

3 files changed

+24
-3
lines changed

.eslintrc.js

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,5 +9,13 @@ module.exports = {
99
"ecmaVersion": 12,
1010
"sourceType": "module"
1111
},
12+
"globals": {
13+
"it": true,
14+
"describe": true,
15+
"expect": true,
16+
"beforeEach": true,
17+
"afterEach": true,
18+
"jasmine": true
19+
},
1220
"rules": { "semi": ["error", "always"]}
1321
};

src/querySelectorDeep.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -177,6 +177,5 @@ export function collectAllElementsDeep(selector = null, root, cachedElements = n
177177
findAllElements(root.querySelectorAll('*'));
178178
}
179179

180-
return allElements.filter(el => el.matches(selector));
181-
}
180+
return selector ? allElements.filter(el => el.matches(selector)) : allElements; }
182181

test/basic.spec.js

Lines changed: 15 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -381,6 +381,21 @@ describe("Basic Suite", function() {
381381
expect(testComponents3.length).toEqual(1);
382382
});
383383

384+
it('empty collectAllElementsDeep find all elements', function() {
385+
const root = document.createElement('div');
386+
parent.appendChild(root);
387+
388+
createTestComponent(root, {
389+
childClassName: 'inner-content'
390+
});
391+
392+
createTestComponent(parent, {
393+
childClassName: 'inner-content'
394+
});
395+
const collectedElements = collectAllElementsDeep('', root);
396+
expect(collectedElements.length).toEqual(4);
397+
});
398+
384399
it('can query nodes in an iframe', function(done) {
385400

386401
const innerframe = `<p class='child'>Content</p>`;
@@ -390,7 +405,6 @@ describe("Basic Suite", function() {
390405
setTimeout(() => {
391406
const iframe = querySelectorDeep('#frame');
392407
const testComponents = querySelectorAllDeep('.child', iframe.contentDocument);
393-
debugger;
394408
expect(testComponents.length).toEqual(1);
395409
expect(testComponents[0].textContent).toEqual("Content");
396410
done();

0 commit comments

Comments
 (0)