Refactoring backup/restore and Makefile

Author: mblaschke

Makefile

@@ -38,24 +38,20 @@ rebuild:
 #############################
 
 mysql-backup:
-	docker-compose run --rm --no-deps app root bash /docker/bin/backup.sh mysql
+	bash ./bin/backup.sh mysql
 
 mysql-restore:
-	docker-compose run --rm --no-deps app root bash /docker/bin/restore.sh mysql
+	bash ./bin/restore.sh mysql
 
 #############################
 # Solr
 #############################
 
 solr-backup:
-	docker-compose stop solr
-	docker-compose run --rm --no-deps app root bash /docker/bin/backup.sh solr
-	docker-compose start solr
+	bash ./bin/backup.sh solr
 
 solr-restore:
-	docker-compose stop solr
-	docker-compose run --rm --no-deps app root bash /docker/bin/restore.sh solr
-	docker-compose start solr
+	bash ./bin/restore.sh solr
 
 #############################
 # General
@@ -68,10 +64,10 @@ build:
 	bash bin/build.sh
 
 bash:
-	docker-compose run --rm app bash
+	docker exec -ti "`docker-compose ps -q app`" 'bash'
 
 root:
-	docker-compose run --rm app root
+	docker exec -ti "`docker-compose ps -q app`" 'root'
 
 #############################
 # Argument fix workaround

bin/.config.sh

@@ -52,3 +52,22 @@ execInDir() {
 
     sh -c "cd \"$1\" && $2"
 }
+
+dockerContainerId() {
+    echo "$(docker-compose ps -q "$1" 2> /dev/null || echo "")"
+}
+
+dockerExec() {
+    docker exec -i "$(docker-compose ps -q app)" $@
+}
+
+dockerCopyFrom() {
+    PATH_DOCKER="$1"
+    PATH_HOST="$2"
+    docker cp "$(docker-compose ps -q app):${PATH_DOCKER}" "${PATH_HOST}"
+}
+dockerCopyTo() {
+    PATH_HOST="$1"
+    PATH_DOCKER="$2"
+    docker cp "${PATH_HOST}" "$(docker-compose ps -q app):${PATH_DOCKER}"
+}

bin/backup.sh

@@ -25,21 +25,28 @@ case "$1" in
         fi
 
         logMsg "Starting MySQL backup..."
-        mysqldump --opt --single-transaction --events --all-databases --routines --comments | bzip2 > "${BACKUP_DIR}/${BACKUP_MYSQL_FILE}"
+        dockerExec mysqldump --opt --single-transaction --events --all-databases --routines --comments | bzip2 > "${BACKUP_DIR}/${BACKUP_MYSQL_FILE}"
         logMsg "Finished"
         ;;
 
     ###################################
     ## Solr
     ###################################
     "solr")
-        if [ -f "${BACKUP_DIR}/${BACKUP_SOLR_FILE}" ]; then
-            logMsg "Removing old backup file..."
-            rm -f -- "${BACKUP_DIR}/${BACKUP_SOLR_FILE}"
+        if [[ -n "$(dockerContainerId solr)" ]]; then
+            logMsg "Starting Solr backup..."
+            docker-compose stop solr
+
+            if [ -f "${BACKUP_DIR}/${BACKUP_SOLR_FILE}" ]; then
+                logMsg "Removing old backup file..."
+                rm -f -- "${BACKUP_DIR}/${BACKUP_SOLR_FILE}"
+            fi
+            dockerExec tar -cP --to-stdout /storage/solr/ | bzip2 > "${BACKUP_DIR}/${BACKUP_SOLR_FILE}"
+
+            docker-compose start solr
+            logMsg "Finished"
+        else
+            echo "[WARNING] Skipping solr backup, no such container"
         fi
-
-        logMsg "Starting Solr backup..."
-        tar jcPf "${BACKUP_DIR}/${BACKUP_SOLR_FILE}" /storage/solr/
-        logMsg "Finished"
         ;;
 esac

bin/restore.sh

@@ -21,7 +21,7 @@ case "$1" in
     "mysql")
         if [ -f "${BACKUP_DIR}/${BACKUP_MYSQL_FILE}" ]; then
             logMsg "Starting MySQL restore..."
-            bzcat "${BACKUP_DIR}/${BACKUP_MYSQL_FILE}" | mysql
+            bzcat "${BACKUP_DIR}/${BACKUP_MYSQL_FILE}" | dockerExec mysql
             logMsg "Finished"
         else
             errorMsg "MySQL backup file not found"
@@ -33,15 +33,25 @@ case "$1" in
     ## Solr
     ###################################
     "solr")
-        if [ -f "${BACKUP_DIR}/${BACKUP_SOLR_FILE}" ]; then
-            logMsg "Starting Solr restore..."
-            rm -rf /storage/solr/* && mkdir -p /storage/solr/
-            chmod 777 /storage/solr/
-            tar jxPf "${BACKUP_DIR}/${BACKUP_SOLR_FILE}" -C /
-            logMsg "Finished"
+        if [[ -n "$(dockerContainerId solr)" ]]; then
+            if [ -f "${BACKUP_DIR}/${BACKUP_SOLR_FILE}" ]; then
+                logMsg "Starting Solr restore..."
+                docker-compose stop solr
+
+                dockerExec rm -rf /storage/solr/
+                dockerExec mkdir -p /storage/solr/
+                dockerExec chmod 777 /storage/solr/
+                dockerCopyTo "${BACKUP_DIR}/${BACKUP_SOLR_FILE}" "/tmp/solr-restore.tbz2"
+                dockerExec tar -jxPf "/tmp/solr-restore.tbz2" -C /
+
+                docker-compose start solr
+                logMsg "Finished"
+            else
+                errorMsg "Solr backup file not found"
+                exit 1
+            fi
         else
-            errorMsg "Solr backup file not found"
-            exit 1
+            echo "[WARNING] Skipping solr restore, no such container"
         fi
         ;;
 esac